Makefile

@@ -32,8 +32,6 @@ run:
 	docker run -it -v $(HOME)/.git-credentials:/root/.git-credentials -v $(HOME)/.gitconfig:/root/.gitconfig -v /var/run/docker.sock:/var/run/docker.sock -v $(shell pwd):/src $(IMAGE) sh
 run-alpine:
 	docker run -it -v $(HOME)/.git-credentials:/root/.git-credentials -v $(HOME)/.gitconfig:/root/.gitconfig -v /var/run/docker.sock:/var/run/docker.sock -v $(shell pwd):/src golang:1.22.6-alpine sh
-build-container:
-	docker run -it -v $(HOME)/.git-credentials:/root/.git-credentials -v $(HOME)/.gitconfig:/root/.gitconfig -v /var/run/docker.sock:/var/run/docker.sock -v $(shell pwd):/src -w /src rosskeenhouse/build-golang:1.22.6-alpine sh
 clean:
 	go clean -modcache
 	rm jx

README.md

@@ -10,9 +10,7 @@ These tools work with YAML descriptions of resources (E.g. files, users, contain
 
 # Releases
 
-**<span style="color:red">v0 releases are unstable and changes may be made to interfaces and specifications.</span>**
+**v0 releases are unstable and changes may be made to interfaces and specifications.**
-
-Use at your own risk.
 
 # JX Documents
 
@@ -43,14 +41,14 @@ resources:
 
 # Testing
 
-Testing the current version involves checking out main and building inside of the alpine go build container.
+Testing the current version involves checking out main and building.
 
 ```
 git clone https://gitea.rosskeen.house/doublejynx/jx.git
 
-make build-container
-
 make test
+
+make build
 ```
 
 # Command-line

build/docker/container-image-build.jx.yaml

@@ -1,16 +0,0 @@
----
-imports:
-- /etc/jx/dockerhub.jx.yaml
-resources:
-- type: container-image
-  config: dockerhub
-  transition: update
-  attributes:
-    name: rosskeenhouse/build-golang:1.22.6-alpine
-    push: true
-    dockerfile: |-
-      FROM golang:1.22.6-alpine
-      COPY . /opt/build
-      WORKDIR /opt/build
-      RUN ./jx apply ./alpine.jx.yaml
-    contextref: file://build/docker/golang/build

build/docker/golang/build/alpine.jx.yaml

@@ -1,36 +0,0 @@
-imports:
-- file://common.jx.yaml
-resources:
-- type: package
-  transition: create
-  attributes:
-    name: musl-dev
-- type: package
-  transition: create
-  attributes:
-    name: luajit
-    verion: =~2.2
-- type: package
-  transition: create
-  attributes:
-    name: luajit-dev
-- type: package
-  transition: create
-  attributes:
-    name: protobuf
-- type: package
-  transition: create
-  attributes:
-    name: openjdk8
-- type: package
-  transition: create
-  attributes:
-    name: docker
-- type: package
-  transition: create
-  attributes:
-    name: openssh-client
-- type: package
-  transition: create
-  attributes:
-    name: golangci-lint

build/docker/golang/build/common.jx.yaml

@@ -1,45 +0,0 @@
-resources:
-- type: file
-  transition: create
-  attributes:
-    path: /usr/local/bin/antlr-4.10-complete.jar
-    sourceref: https://www.antlr.org/download/antlr-4.10-complete.jar
-    owner: root
-    group: root
-    mode: 0755
-- type: package
-  transition: create
-  attributes:
-    name: make
-- type: package
-  transition: create
-  attributes:
-    name: openssl
-- type: package
-  transition: create
-  attributes:
-    name: curl
-- type: package
-  transition: create
-  attributes:
-    name: git
-- type: package
-  transition: create
-  attributes:
-    name: gcc
-- type: exec
-  transition: create
-  attributes:
-    create:
-      path: go
-      args:
-      - install
-      - google.golang.org/protobuf/cmd/protoc-gen-go@latest
-- type: exec
-  transition: create
-  attributes:
-    create:
-      path: go
-      args:
-      - install
-      - golang.org/x/vuln/cmd/govulncheck@latest

cli_test.go

@@ -184,25 +184,6 @@ func TestResourcesRead(t *testing.T) {
 		t.Skip("cli not built")
 	}
 
-
-	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
-		defer req.Body.Close()
-		assert.Equal(t, req.URL.String(), "/resource/user")
-		_, err := io.ReadAll(req.Body)
-		assert.Nil(t, err)
-		userdecl := []byte(`
-type: "user"
-attributes:
-  name: "foo"
-  gecos: "foo user"
-`)
-
-		_, writeErr := rw.Write(userdecl)
-		assert.Nil(t, writeErr)
-	}))
-	defer server.Close()
-	
-
 	assert.Nil(t, TempDir.CreateFile("testread", "data"))
 
 resources := fmt.Sprintf(`
@@ -234,7 +215,7 @@ resources:
 - type: http
   transition: read
   attributes:
-    endpoint: %s/resource/user
+    endpoint: https://gitea.rosskeen.house
 - type: route
   transition: read
   attributes:
@@ -246,7 +227,7 @@ resources:
     rtid: all
     routetype: local
     metric: 100
-`, TempDir.FilePath("testread"), server.URL)
+`, TempDir.FilePath("testread"))
 
 	assert.Nil(t, TempDir.CreateFile("resources.jx.yaml", resources))
 

cmd/cli/main.go

@@ -159,7 +159,7 @@ func main() {
 
 	DefaultConfigurations, configErr := builtin.BuiltInDocuments()
 	if configErr != nil {
-		slog.Warn("Failed loading default configuration", "error", configErr)
+		slog.Error("Failed loading default configuration", "error", configErr)
 	}
 
 	ConfigDoc.AppendConfigurations(DefaultConfigurations)
@@ -167,8 +167,8 @@ func main() {
 	for _, subCmd := range jxSubCommands {
 		cmdFlagSet := flag.NewFlagSet(subCmd.Name, flag.ExitOnError)
 
-		cmdFlagSet.StringVar(&ConfigPath, "config", "/etc/jx/conf.d", "Config file path")
+		cmdFlagSet.StringVar(&ConfigPath, "config", "/etc/jx", "Config file path")
-		cmdFlagSet.StringVar(&ConfigPath, "c", "/etc/jx/conf.d", "Config file path")
+		cmdFlagSet.StringVar(&ConfigPath, "c", "/etc/jx", "Config file path")
 
 		GlobalOformat = cmdFlagSet.String("oformat", "yaml", "Output serialization format")
 		cmdFlagSet.StringVar(&GlobalOutput, "output", "-", "Output target (default stdout)")

cmd/cli/main_test.go

@@ -1,26 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package main
-
-import (
-_	"github.com/stretchr/testify/assert"
-	"testing"
-_	"decl/internal/folio"
-_	"decl/internal/data"
-_	"log/slog"
-)
-
-func TestLoadSourceURIConverter(t *testing.T) {
-/*
-	var uri folio.URI = "file://../../examples/file.jx.yaml"
-	docs, err := LoadSourceURIConverter(uri)
-	assert.Nil(t, err)
-	assert.Greater(t, len(docs), 0)
-	slog.Info("TestLoadSourceURIConverter", "doc", docs[0], "resource", docs[0].(*folio.Document).ResourceDeclarations[0].Attributes)
-	resDecl := docs[0].(*folio.Document).ResourceDeclarations[0]
-	assert.Equal(t, "file", resDecl.Attributes.Type())
-	v, ok := docs[0].Get("file:///tmp/foo.txt")
-	assert.True(t, ok)
-	assert.Equal(t, "/tmp/foo.txt", v.(data.Declaration).Resource().(data.FileResource).FilePath())
-*/
-}

examples/file.jx.yaml

@@ -1,8 +1,8 @@
 resources:
 - type: file
-  transition: create
   attributes:
     path: /tmp/foo.txt
     owner: nobody
+    group: nobody
     mode: 0644
     state: present

examples/user.jx.yaml

@@ -1,7 +1,7 @@
 resources:
 - type: user
-  transition: create
   attributes:
     name: "testuser"
     uid: "12001"
     home: "/home/testuser"
+    state: present

internal/builtin/documents/config.jx.yaml

@@ -1,54 +0,0 @@
-configurations:
-- name: confdir
-  values:
-    prefix: /etc/jx
-resources:
-- type: group
-  transition: create
-  onerror: stop
-  attributes:
-    name: "jx"
-- type: file
-  transition: update
-  attributes:
-    path: "/etc/jx"
-    owner: "root"
-    group: "root"
-    mode: "0755"
-    filetype: directory
-- type: file
-  transition: update
-  config: confdir
-  attributes:
-    path: "conf.d"
-    owner: "root"
-    group: "jx"
-    mode: "0770"
-    filetype: directory
-- type: file
-  transition: update
-  config: confdir
-  attributes:
-    path: "lib"
-    owner: "root"
-    group: "jx"
-    mode: "0770"
-    filetype: directory
-- type: file
-  transition: update
-  config: confdir
-  attributes:
-    path: "pki"
-    owner: "root"
-    group: "jx"
-    mode: "0770"
-    filetype: directory
-- type: file
-  transition: update
-  config: confdir
-  attributes:
-    path: "pki/ca"
-    owner: "root"
-    group: "jx"
-    mode: "0770"
-    filetype: directory

internal/builtin/documents/install.jx.yaml

@@ -1,16 +0,0 @@
-imports:
-- file://documents/config.jx.yaml
-configurations:
-- name: bindir
-  values:
-    prefix: /usr/local/bin
-resources:
-- type: file
-  transition: update
-  config: bindir
-  attributes:
-    path: "jx"
-    owner: "root"
-    group: "root"
-    mode: "0755"
-    sourceref: file://jx

internal/client/client.go

@@ -126,7 +126,7 @@ func (a *App) ImportResource(ctx context.Context, uri string) (err error) {
 		a.Documents = append(a.Documents, folio.DocumentRegistry.NewDocument(""))
 	}
 	resourceURI := folio.URI(uri)
-	u := resourceURI.Parse().URL()
+	u := resourceURI.Parse()
 	if u == nil {
 		return fmt.Errorf("Failed adding resource: %s", uri)
 	}
@@ -147,19 +147,9 @@ func (a *App) ImportResource(ctx context.Context, uri string) (err error) {
 }
 
 func (a *App) ImportSource(uri string) (loadedDocuments []data.Document, err error) {
-	if source := folio.URI(uri).Parse().URL(); source != nil {
+	if loadedDocuments, err = folio.DocumentRegistry.Load(folio.URI(uri)); err == nil && loadedDocuments != nil {
-		if source.Scheme == "" {
-			source.Scheme = "file"
-		}
-
-		slog.Info("Client.ImportSource()", "uri", uri, "source", source, "error", err)
-		if loadedDocuments, err = folio.DocumentRegistry.LoadFromParsedURI(source); err == nil && loadedDocuments != nil {
 		a.Documents = append(a.Documents, loadedDocuments...)
 	}
-	} else {
-		err = folio.ErrInvalidURI
-	}
-
 	slog.Info("Client.ImportSource()", "uri", uri, "error", err)
 	return
 }
@@ -193,7 +183,7 @@ func (a *App) Apply(ctx context.Context, deleteResources bool) (err error) {
 			continue
 		}
 
-		slog.Info("Client.Apply()", "uri", d.GetURI(), "document", d, "state", overrideState, "error", err)
+		slog.Info("Client.Apply()", "document", d, "state", overrideState, "error", err)
 		if e := d.(*folio.Document).Apply(overrideState); e != nil {
 			slog.Info("Client.Apply() error", "error", e)
 			return e

internal/command/command.go

@@ -16,7 +16,6 @@ import (
 	"strings"
 	"text/template"
 	"decl/internal/codec"
-	"syscall"
 )
 
 var ErrUnknownCommand error = errors.New("Unable to find command in path")
@@ -27,8 +26,6 @@ type CommandExists func() error
 
 type CommandArg string
 
-type CommandInput string
-
 type Command struct {
 	Path      string                   `json:"path" yaml:"path"`
 	Args      []CommandArg             `json:"args" yaml:"args"`
@@ -36,13 +33,9 @@ type Command struct {
 	Split     bool                     `json:"split" yaml:"split"`
 	FailOnError bool                   `json:"failonerror" yaml:"failonerror"`
 	StdinAvailable bool                `json:"stdinavailable,omitempty" yaml:"stdinavailable,omitempty"`
-	ExitCode	int			`json:"exitcode,omitempty" yaml:"exitcode,omitempty"`
-	Stdout		string			`json:"stdout,omitempty" yaml:"stdout,omitempty"`
-	Stderr		string			`json:"stderr,omitempty" yaml:"stderr,omitempty"`
 	Executor  CommandExecutor          `json:"-" yaml:"-"`
 	Extractor CommandExtractAttributes `json:"-" yaml:"-"`
 	CommandExists CommandExists        `json:"-" yaml:"-"`
-	Input	CommandInput			`json:"-" yaml:"-"`
 	stdin io.Reader                    `json:"-" yaml:"-"`
 }
 
@@ -52,14 +45,7 @@ func NewCommand() *Command {
 	return c
 }
 
-func (c *Command) ClearOutput() {
-	c.Stdout = ""
-	c.Stderr = ""
-	c.ExitCode = 0
-}
-
 func (c *Command) Defaults() {
-	c.ClearOutput()
 	c.Split = true
 	c.FailOnError = true
 	c.CommandExists = func() error {
@@ -69,14 +55,10 @@ func (c *Command) Defaults() {
 		return nil
 	}
 	c.Executor = func(value any) ([]byte, error) {
-		c.ClearOutput()
 		args, err := c.Template(value)
 		if err != nil {
 			return nil, err
 		}
-		if inputErr := c.SetInput(value); inputErr != nil {
-			return nil, inputErr
-		}
 		cmd := exec.Command(c.Path, args...)
 		c.SetCmdEnv(cmd)
 	
@@ -109,10 +91,6 @@ func (c *Command) Defaults() {
 		}
 		waitErr := cmd.Wait()
 
-		c.Stdout = string(stdOutOutput)
-		c.Stderr = string(stdErrOutput)
-		c.ExitCode = c.GetExitCodeFromError(waitErr)
-
 		if len(stdOutOutput) > 100 {
 			slog.Info("execute()", "path", c.Path, "args", args, "output", string(stdOutOutput[:100]), "error", string(stdErrOutput))
 		} else {
@@ -148,15 +126,6 @@ func (c *Command) Exists() bool {
 	return c.CommandExists() == nil
 }
 
-func (c *Command) GetExitCodeFromError(err error) (ec int) {
-	if exitErr, ok := err.(*exec.ExitError); ok {
-		if status, ok := exitErr.Sys().(syscall.WaitStatus); ok {
-			return status.ExitStatus()
-		}
-	}
-	return
-}
-
 func (c *Command) Template(value any) ([]string, error) {
 	var args []string = make([]string, 0, len(c.Args) * 2)
 	for i, arg := range c.Args {
@@ -185,22 +154,6 @@ func (c *Command) Execute(value any) ([]byte, error) {
 	return c.Executor(value)
 }
 
-func (c *Command) SetInput(value any) error {
-	if len(c.Input) > 0 {
-		if r, err := c.Input.Template(value); err != nil {
-			return err
-		} else {
-			c.SetStdinReader(strings.NewReader(r.String()))
-		}
-	}
-	return nil
-}
-
-func (c *CommandInput) Template(value any) (result strings.Builder, err error) {
-	err = template.Must(template.New("commandInput").Parse(string(*c))).Execute(&result, value)
-	return
-}
-
 func (c *CommandArg) UnmarshalValue(value string) error {
 	*c = CommandArg(value)
 	return nil

internal/command/command_test.go

@@ -81,22 +81,3 @@ stdinavailable: true
 	assert.Nil(t, err)
 	assert.Equal(t, expected, string(out))
 }
-
-func TestCommandExitCode(t *testing.T) {
-	c := NewCommand()
-	assert.NotNil(t, c)
-	decl := `
-path: ls
-args:
-- "amissingfile"
-`
-
-	assert.Nil(t, c.LoadDecl(decl))
-	assert.Equal(t, "ls", c.Path)
-
-	out, err := c.Execute(nil)
-	assert.NotNil(t, err)
-	assert.Greater(t, c.ExitCode, 0)	
-	assert.Equal(t, string(out), c.Stdout)
-	assert.Equal(t, string("ls: amissingfile: No such file or directory\n"), c.Stderr)
-}

internal/config/certificate.go

@@ -37,7 +37,7 @@ func (c *Certificate) SetURI(uri string) error {
 	return nil
 }
 
-func (c *Certificate) SetParsedURI(uri data.URIParser) error {
+func (c *Certificate) SetParsedURI(uri *url.URL) error {
 	return nil
 }
 

internal/config/exec.go

@@ -39,7 +39,7 @@ func (x *Exec) SetURI(uri string) error {
 	return nil
 }
 
-func (x *Exec) SetParsedURI(uri data.URIParser) error {
+func (x *Exec) SetParsedURI(uri *url.URL) error {
 	return nil
 }
 

internal/config/generic.go

@@ -35,7 +35,7 @@ func (g *Generic[Value]) SetURI(uri string) error {
 	return nil
 }
 
-func (g *Generic[Value]) SetParsedURI(uri data.URIParser) error {
+func (g *Generic[Value]) SetParsedURI(uri *url.URL) error {
 	return nil
 }
 

internal/config/system.go

@@ -10,7 +10,6 @@ import (
 	"decl/internal/data"
 	"decl/internal/folio"
 	"runtime"
-	"decl/internal/system"
 )
 
 // Collects facts about the system
@@ -36,24 +35,9 @@ func NewSystem() *System {
 	for k, v := range buildValues {
 		s[k] = v
 	}
-	s.CurrentUser()
-	s["importpath"] = []string {
-		"/etc/jx/lib",
-	}
 	return &s
 }
 
-func (s *System) CurrentUser() {
-	processUser := system.ProcessUser()
-	processGroup := system.ProcessGroup(processUser)
-	(*s)["user"] = processUser.Username
-	(*s)["gecos"] = processUser.Name
-	(*s)["home"] = processUser.HomeDir
-	(*s)["uid"] = processUser.Uid
-	(*s)["group"] = processGroup.Name
-	(*s)["gid"] = processUser.Gid
-}
-
 func (s *System) URI() string {
 	return fmt.Sprintf("%s://%s", s.Type(), "")
 }
@@ -62,7 +46,7 @@ func (s *System) SetURI(uri string) error {
         return nil
 }
 
-func (s *System) SetParsedURI(uri data.URIParser) error {
+func (s *System) SetParsedURI(uri *url.URL) error {
         return nil
 }
 

internal/data/document.go

@@ -8,6 +8,7 @@ import (
 	"decl/internal/codec"
 	"io"
 	"decl/internal/mapper"
+	"net/url"
 )
 
 var (
@@ -43,7 +44,7 @@ type Document interface {
 	mapper.Mapper
 
 	NewResource(uri string) (Resource, error)
-	NewResourceFromParsedURI(uri URIParser) (Resource, error)
+	NewResourceFromParsedURI(uri *url.URL) (Resource, error)
 	AddDeclaration(Declaration)
 	AddResourceDeclaration(resourceType string, resourceDeclaration Resource)
 

internal/data/identifier.go

@@ -5,34 +5,16 @@ package data
 import (
 	"errors"
 	"net/url"
-	"decl/internal/transport"
 )
 
 var (
 	ErrInvalidURI error = errors.New("Invalid URI")
 )
 
-type URIParser interface {
-	URL() *url.URL
-	NewResource(document Document) (newResource Resource, err error)
-	ConstructResource(res Resource) (err error)
-	Converter() (converter Converter, err error)
-	Exists() bool
-
-	ContentReaderStream() (*transport.Reader, error)
-	ContentWriterStream() (*transport.Writer, error)
-
-	String() string
-	SetURL(url *url.URL)
-	Extension() (string, string)
-
-	ContentType() string
-	IsEmpty() bool
-}
-
 type Identifier interface {
 	URI() string
-	SetParsedURI(URIParser) error
+	SetURI(string) error
+	SetParsedURI(*url.URL) error
 }
 
 type DocumentElement interface {

internal/data/resource.go

@@ -22,11 +22,6 @@ type StateTransformer interface {
 	Apply() error
 }
 
-// Used by the resource factory to initialize new resources.
-type ResourceInitializer interface {
-	Init(uri URIParser) error
-}
-
 type Resource interface {
 	Identifier
 	Type() string

internal/data/types.go

@@ -11,7 +11,6 @@ type Factory[Product comparable] func(*url.URL) Product
 type TypesRegistry[Product comparable] interface {
 	New(uri string) (result Product, err error)
 	NewFromParsedURI(uri *url.URL) (result Product, err error)
-	NewFromType(typename string) (result Product, err error)
 	Has(typename string) bool
 	//Get(string) Factory[Product] 
 }

internal/ds/orderedset.go

@@ -1,63 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package ds
-
-import (
-	"log/slog"
-)
-
-type OrderedSet[Value comparable] struct {
-	Values []*Value
-	elements map[Value]int
-}
-
-func NewOrderedSet[Value comparable]() *OrderedSet[Value] {
-	return &OrderedSet[Value]{ elements: make(map[Value]int), Values: make([]*Value, 0, 10) }
-}
-
-func (s *OrderedSet[Value]) Add(value Value) {
-	slog.Info("OrderedSet.Add", "key", value, "s", s)
-	s.Values = append(s.Values, &value)
-	s.elements[value] = len(s.Values)
-	slog.Info("OrderedSet.Add", "key", value, "s", s, "v", &s.Values)
-}
-
-func (s *OrderedSet[Value]) Delete(key Value) {
-	slog.Info("OrderedSet.Delete", "key", key, "s", s, "size", len(s.Values))
-	if i, ok := s.elements[key]; ok {
-		i--
-		s.Values[i] = nil
-		delete(s.elements, key)
-	}
-}
-
-func (s *OrderedSet[Value]) Contains(value Value) (result bool) {
-	slog.Info("OrderedSet.Contains", "key", value, "s", s, "size", len(s.Values), "v", &s.Values)
-	_, result = s.elements[value]
-	return
-}
-
-func (s *OrderedSet[Value]) Len() int {
-    return len(s.elements)
-}
-
-func (s *OrderedSet[Value]) AddItems(value []Value) {
-	for _, v := range value {
-		s.Add(v)
-	}
-}
-
-func (s *OrderedSet[Value]) Items() []*Value {
-	slog.Info("OrderedSet.Items - start", "s", s)
-	result := make([]*Value, 0, len(s.elements) - 1)
-	for _, v := range s.Values {
-		slog.Info("OrderedSet.Items", "value", v)
-		if v != nil {
-			result = append(result, v)
-			s.elements[*v] = len(result)
-		}
-	}
-	slog.Info("OrderedSet.Items", "s", s, "result", result)
-	s.Values = result
-	return result
-}

internal/ds/orderedset_test.go

@@ -1,51 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package ds
-
-import (
-	"github.com/stretchr/testify/assert"
-	"testing"
-	"log/slog"
-)
-
-var (
-)
-
-func TestNewOrderedSet(t *testing.T) {
-	s := NewOrderedSet[string]()
-	assert.NotNil(t, s)
-
-	testValues := []string{
-		"foo",
-		"bar",
-		"baz",
-		"quuz",
-	}
-
-	for _,value := range testValues {
-
-		s.Add(value)
-
-
-		slog.Info("TestNewOrderedSet - ADD", "item", value, "s", s)
-
-		assert.True(t, s.Contains(value))
-		slog.Info("TestNewOrderedSet - CONTAINS", "s", s)
-
-		for x, item := range s.Items() {
-			slog.Info("TestNewOrderedSet", "item", item, "s", s)
-			assert.Equal(t, testValues[x], *item)
-		}
-
-	}
-	s.Delete("bar")
-
-	expectedValues := []string {
-		"foo",
-		"baz",
-		"quuz",
-	}
-	for x, item := range s.Items() {
-		assert.Equal(t, expectedValues[x], *item)
-	}
-}

internal/ds/set.go

@@ -1,34 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package ds
-
-import (
-)
-
-type Set[Value comparable] map[Value]bool
-
-func NewSet[Value comparable]() Set[Value] {
-	return make(map[Value]bool)
-}
-
-func (s Set[Value]) Add(value Value) {
-	s[value] = true
-}
-
-func (s Set[Value]) Delete(value Value) {
-    delete(s, value)
-}
-
-func (s Set[Value]) Contains(value Value) bool {
-    return s[value]
-}
-
-func (s Set[Value]) Len() int {
-    return len(s)
-}
-
-func (s Set[Value]) AddSlice(value []Value) {
-	for _, v := range value {
-		s.Add(v)
-	}
-}

internal/ds/set_test.go

@@ -1,24 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package ds
-
-import (
-	"github.com/stretchr/testify/assert"
-	"testing"
-)
-
-var (
-)
-
-func TestNewSet(t *testing.T) {
-	s := NewSet[string]()
-	assert.NotNil(t, s)
-	s["foo"] = true
-	assert.True(t, s.Contains("foo"))
-
-	s.Add("bar")
-	
-	assert.True(t, s.Contains("bar"))
-
-	
-}

internal/ext/file.go

@@ -1,26 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package ext
-
-import (
-	"os"
-	"path/filepath"
-)
-
-type FilePath string
-
-func (f *FilePath) Exists() bool {
-	_, err := os.Stat(string(*f))
-	return !os.IsNotExist(err)
-}
-
-func (f *FilePath) Add(relative string) {
-	newPath := filepath.Join(string(*f), relative)
-	*f = FilePath(newPath)
-}
-
-
-func (f FilePath) Abs() FilePath {
-	result, _ := filepath.Abs(string(f))
-	return FilePath(result)
-}

internal/fan/dir.go

@@ -105,6 +105,12 @@ func (d *Dir) Emit(document data.Document, filter data.ElementSelector) (resourc
 		return nil, ErrEmptyDocument
 	}
 
+	dirFileDeclaration := folio.NewDeclaration()
+	dirFileDeclaration.Type = "file"
+	if err = dirFileDeclaration.NewResource(nil); err != nil {
+		return
+	}
+
 	parentPaths := make(map[string]int)
 	var containingDirectoryPath string
 	for _,res := range document.Filter(func(d data.Declaration) bool {
@@ -124,12 +130,8 @@ func (d *Dir) Emit(document data.Document, filter data.ElementSelector) (resourc
 
 		containingDirectoryPath, _ = d.isParent(&parentPaths, parent, containingDirectoryPath)
 	}
-
 	uri := fmt.Sprintf("file://%s", containingDirectoryPath)
-
+	if err = dirFileDeclaration.SetURI(uri); err != nil {
-	dirFileDeclaration := folio.NewDeclaration()
-	dirFileDeclaration.Type = "file"
-	if err = dirFileDeclaration.NewResource(&uri); err != nil {
 		return
 	}
 

internal/fan/jx.go

@@ -120,10 +120,8 @@ func (j *JxFile) setdecoder(source data.ContentIdentifier) {
 		for _,v := range strings.Split(source.ContentType(), ".") {
 			_ = j.Format.Set(v)
 		}
-		slog.Info("JxFile.setdecoder()", "type",  source.ContentType(), "format", j.Format)
 		j.decoder = codec.NewDecoder(j.reader, j.Format)
 	}
-	slog.Info("JxFile.setdecoder()", "decoder",  j.decoder)
 }
 
 func (j *JxFile) Type() data.TypeName { return "jx" }
@@ -181,7 +179,6 @@ func (j *JxFile) ExtractMany(resourceSource data.Resource, filter data.ElementSe
 			}
 			break
 		}
-		slog.Info("JxFile.ExtractMany() loading", "document", j.index)
 	}
 	slog.Info("JxFile.ExtractMany()", "jxfile", j, "error", err)
 	return
@@ -189,7 +186,7 @@ func (j *JxFile) ExtractMany(resourceSource data.Resource, filter data.ElementSe
 
 func (j *JxFile) targetResource() (target data.Resource, err error) {
 	if j.emitResource == nil {
-		targetUrl := j.Uri.Parse().URL()
+		targetUrl := j.Uri.Parse()
 		targetUrl.Scheme = "file"
 		q := targetUrl.Query()
 		q.Set("format", string(j.Format))

internal/folio/block.go

@@ -15,32 +15,6 @@ import (
 	"decl/internal/schema"
 )
 
-type ConfigKey string
-
-// Lookup a config value using block.key identifier (E.g. system.GOOS)
-func (c ConfigKey) GetValue() (value any, err error) {
-	fields := strings.SplitN(string(c), ".", 2)
-	if configBlock, ok := DocumentRegistry.ConfigNameMap.Get(fields[0]); ok && len(fields) > 1 {
-		return configBlock.GetValue(fields[1])
-	} else {
-		return nil, fmt.Errorf("%w - %s", data.ErrUnknownConfigurationType, c)
-	}
-}
-
-func (c ConfigKey) Get() any {
-	if v, err := c.GetValue(); err == nil {
-		return v
-	}
-	return nil
-}
-
-func (c ConfigKey) GetStringSlice() []string {
-	if v, err := c.GetValue(); err == nil {
-		return v.([]string)
-	}
-	return nil
-}
-
 type BlockType struct {
 	Name string `json:"name" yaml:"name"`
 	Type TypeName `json:"type" yaml:"type"`
@@ -161,9 +135,9 @@ func (b *Block) SetURI(uri string) (err error) {
 	return
 }
 
-func (b *Block) SetParsedURI(uri data.URIParser) (err error) {
+func (b *Block) SetParsedURI(uri *url.URL) (err error) {
 	if b.Values == nil {
-		if err = b.NewConfigurationFromParsedURI(uri.URL()); err != nil {
+		if err = b.NewConfigurationFromParsedURI(uri); err != nil {
 			return
 		}
 	}

internal/folio/declaration.go

@@ -11,10 +11,12 @@ _	"errors"
 	"gopkg.in/yaml.v3"
 	"log/slog"
 _	"gitea.rosskeen.house/rosskeen.house/machine"
-	"gitea.rosskeen.house/pylon/luaruntime"
+//_	"gitea.rosskeen.house/pylon/luaruntime"
 	"decl/internal/codec"
 	"decl/internal/data"
 	"decl/internal/schema"
+	"net/url"
+	"runtime/debug"
 	"errors"
 )
 
@@ -31,7 +33,6 @@ type DeclarationType struct {
 	OnError OnError   `json:"onerror,omitempty" yaml:"onerror,omitempty"`
 	Error   string    `json:"error,omitempty" yaml:"error,omitempty"`
 	Requires Dependencies `json:"requires,omitempty" yaml:"requires,omitempty"`
-	On *Events `json:"on,omitempty" yaml:"on,omitempty"`
 }
 
 type Declaration struct {
@@ -42,15 +43,14 @@ type Declaration struct {
 	OnError OnError   `json:"onerror,omitempty" yaml:"onerror,omitempty"`
 	Error   string    `json:"error,omitempty" yaml:"error,omitempty"`
 	Requires Dependencies `json:"requires,omitempty" yaml:"requires,omitempty"`
-	On *Events `json:"on,omitempty" yaml:"on,omitempty"`
+//	runtime luaruntime.LuaRunner
-	runtime luaruntime.LuaRunner
 	document *Document
 	configBlock data.Block
 	ResourceTypes data.TypesRegistry[data.Resource] `json:"-" yaml:"-"`
 }
 
 func NewDeclaration() *Declaration {
-	return &Declaration{ ResourceTypes: DocumentRegistry.ResourceTypes, runtime: luaruntime.New() }
+	return &Declaration{ ResourceTypes: DocumentRegistry.ResourceTypes }
 }
 
 func NewDeclarationFromDocument(document *Document) *Declaration {
@@ -98,7 +98,6 @@ func (d *Declaration) Clone() data.Declaration {
 		//runtime: luaruntime.New(),
 		Config: d.Config,
 		Requires: d.Requires,
-		On: d.On,
 	}
 }
 
@@ -138,12 +137,11 @@ func (d *Declaration) Validate() (err error) {
 	return err
 }
 
-func (d *Declaration) NewResourceFromParsedURI(u data.URIParser) (err error) {
+func (d *Declaration) NewResourceFromParsedURI(u *url.URL) (err error) {
 	if u == nil {
-		d.Attributes, err = d.ResourceTypes.NewFromType(string(d.Type))
+		d.Attributes, err = d.ResourceTypes.NewFromParsedURI(&url.URL{ Scheme: string(d.Type) })
 	} else {
-		parsed := u.URL()
+		if d.Attributes, err = d.ResourceTypes.NewFromParsedURI(u); err == nil {
-		if d.Attributes, err = d.ResourceTypes.NewFromParsedURI(parsed); err == nil {
 			err = d.Attributes.SetParsedURI(u)
 		}
 	}
@@ -151,17 +149,15 @@ func (d *Declaration) NewResourceFromParsedURI(u data.URIParser) (err error) {
 }
 
 func (d *Declaration) NewResource(uri *string) (err error) {
-	slog.Info("Declaration.NewResource()")
 	if d.ResourceTypes == nil {
 		panic(fmt.Errorf("Undefined type registry: unable to create new resource %s", *uri))
 	}
-
 	if uri == nil {
-		d.Attributes, err = d.ResourceTypes.NewFromType(string(d.Type))
+		d.Attributes, err = d.ResourceTypes.New(fmt.Sprintf("%s://", d.Type))
 	} else {
-		slog.Info("Declaration.NewResource()", "uri", *uri)
+		if d.Attributes, err = d.ResourceTypes.New(*uri); err == nil {
-		parsedURI := URI(*uri).Parse()
+			err = d.Attributes.SetURI(*uri)
-		d.Attributes, err = d.ResourceTypes.NewFromParsedURI(parsedURI.URL())
+		}
 	}
 	return
 }
@@ -173,6 +169,7 @@ func (d *Declaration) Resource() data.Resource {
 func (d *Declaration) Apply(stateTransition string) (result error) {
 	defer func() {
 		if r := recover(); r != nil {
+			slog.Debug("Declaration.Apply()", "stacktrace", string(debug.Stack()))
 			slog.Info("Declaration.Apply()", "error", r, "resourceerror", d.Error)
 			if d.Error != "" {
 				result = fmt.Errorf("%s - %s", r, d.Error)
@@ -248,7 +245,7 @@ func (d *Declaration) SetConfig(configDoc data.Document) {
 		return
 	}
 	if d.Config != "" { // XXX
-		panic(fmt.Sprintf("failed setting config: %s", d.Config))
+		panic("failed setting config")
 	}
 }
 
@@ -257,7 +254,7 @@ func (d *Declaration) SetURI(uri string) (err error) {
 	if d.Attributes == nil {
 		err = d.NewResource(&uri)
 	} else {
-		err = d.Attributes.SetParsedURI(URI(uri).Parse())
+		err = d.Attributes.SetURI(uri)
 	}
 	if err != nil {
 		return err
@@ -271,7 +268,7 @@ func (d *Declaration) SetURI(uri string) (err error) {
 	return
 }
 
-func (d *Declaration) SetParsedURI(uri data.URIParser) (err error) {
+func (d *Declaration) SetParsedURI(uri *url.URL) (err error) {
 	slog.Info("Declaration.SetParsedURI()", "uri", uri, "declaration", d)
 	if d.Attributes == nil {
 		err = d.NewResourceFromParsedURI(uri)
@@ -301,9 +298,7 @@ func (d *Declaration) UnmarshalValue(value *DeclarationType) error {
 	d.OnError = value.OnError
 	d.Error = value.Error
 	d.Requires = value.Requires
-	d.On = value.On
+	newResource, resourceErr := d.ResourceTypes.New(fmt.Sprintf("%s://", value.Type))
-	newResource, resourceErr := d.ResourceTypes.NewFromType(string(value.Type))
-
 	slog.Info("Declaration.UnmarshalValue", "value", value, "error", resourceErr, "type", value.Type, "resource", newResource, "resourcetypes", d.ResourceTypes)
 	if resourceErr != nil {
 		slog.Info("Declaration.UnmarshalValue", "value", value, "error", resourceErr)
@@ -311,30 +306,10 @@ func (d *Declaration) UnmarshalValue(value *DeclarationType) error {
 	}
 	d.Attributes = newResource
 	d.configBlock = d.Config.GetBlock()
-
-	if d.On != nil {
-		if handler, ok := (*d.On)[EventTypeLoad]; ok {
-			stackSize := d.runtime.Api().GetTop()
-			if e := d.runtime.LoadScriptFromString(string(handler)); e != nil {
-				d.Error = e.Error()
-			}
-			returnsCount := d.runtime.Api().GetTop() - stackSize
-			if ! d.runtime.Api().IsNil(-1) {
-		 		if returnsCount == 0 {
-					// return nil
-				} else {
-					if lr,le := d.runtime.CopyReturnValuesFromCall(int(returnsCount)); le == nil {
-						slog.Info("Event.Load", "result", lr, "error", le)
-					}
-				}
-			}
-		}
-	}
-
 	return nil
 }
 
-func (d *Declaration) UnmarshalYAML(value *yaml.Node) (err error) {
+func (d *Declaration) UnmarshalYAML(value *yaml.Node) error {
 	if d.ResourceTypes == nil {
 		d.ResourceTypes = DocumentRegistry.ResourceTypes
 	}
@@ -356,17 +331,10 @@ func (d *Declaration) UnmarshalYAML(value *yaml.Node) (err error) {
 	if unmarshalResourceErr := resourceAttrs.Attributes.Decode(d.Attributes); unmarshalResourceErr != nil {
 		return unmarshalResourceErr
 	}
-
+	return nil
-	if i, ok := d.Attributes.(data.ResourceInitializer); ok {
-		err = i.Init(nil)
-	} else {
-		err = fmt.Errorf("failed to execute init")
 }
 
-	return
+func (d *Declaration) UnmarshalJSON(jsonData []byte) error {
-}
-
-func (d *Declaration) UnmarshalJSON(jsonData []byte) (err error) {
 	if d.ResourceTypes == nil {
 		d.ResourceTypes = DocumentRegistry.ResourceTypes
 	}
@@ -386,14 +354,24 @@ func (d *Declaration) UnmarshalJSON(jsonData []byte) (err error) {
 		return unmarshalAttributesErr
 	}
 
-	if i, ok := d.Attributes.(data.ResourceInitializer); ok {
+	return nil
-		err = i.Init(nil)
-	} else {
-		err = fmt.Errorf("failed to execute init")
 }
 
-	return
+/*
+func (d *Declaration) MarshalJSON() ([]byte, error) {
+  buf := new(bytes.Buffer)
+  buf.WriteByte('"')
+  buf.WriteString("value"))
+  buf.WriteByte('"')
+  return buf.Bytes(), nil
 }
+*/
+
+/*
+func (d *Declaration) MarshalYAML() (any, error) {
+	return d, nil
+}
+*/
 
 /*
 func (l *LuaWorker) Receive(m message.Envelope) {

internal/folio/declaration_test.go

@@ -57,7 +57,6 @@ func TestNewResourceDeclarationType(t *testing.T) {
 
 	e := resourceDeclaration.LoadString(decl, codec.FormatYaml)
 	assert.Nil(t, e)
-
 	assert.Equal(t, TypeName("foo"), resourceDeclaration.Type)
 	assert.NotNil(t, resourceDeclaration.Attributes)
 }

internal/folio/document.go

@@ -10,6 +10,7 @@ import (
 	"io/fs"
 _	"os"
 	"log/slog"
+	"net/url"
 	"github.com/sters/yaml-diff/yamldiff"
 	"strings"
 	"decl/internal/codec"
@@ -18,7 +19,6 @@ _	"decl/internal/types"
 	"decl/internal/data"
 	"decl/internal/schema"
 	"context"
-	"path/filepath"
 )
 
 type DocumentType struct {
@@ -44,23 +44,13 @@ type Document struct {
 	config data.Document
 	Registry *Registry `json:"-" yaml:"-"`
 	failedResources int `json:"-" yaml:"-"`
-	importPaths *SearchPath `json:"-" yaml:"-"`
 }
 
 func NewDocument(r *Registry) *Document {
 	if r == nil {
 		r = DocumentRegistry
 	}
-
+	return &Document{ Registry: r, Format: codec.FormatYaml, uris: mapper.New[string, data.Declaration](), configNames: mapper.New[string, data.Block]() }
-	var configImportPath ConfigKey = "system.importpath"
-
-	return &Document{
-		Registry: r,
-		Format: codec.FormatYaml,
-		uris: mapper.New[string, data.Declaration](),
-		configNames: mapper.New[string, data.Block](),
-		importPaths: NewSearchPath(configImportPath.GetStringSlice()),
-	 }
 }
 
 func (d *Document) GetURI() string {
@@ -69,19 +59,6 @@ func (d *Document) GetURI() string {
 
 func (d *Document) SetURI(uri string) {
 	d.URI = URI(uri)
-	d.AddProjectPath()
-}
-
-func (d *Document) AddProjectPath() {
-	exists := d.URI.Exists()
-	if exists {
-		if u := d.URI.Parse().(*ParsedURI); u != nil {
-			projectPath := filepath.Dir(filepath.Join(u.Hostname(), u.Path))
-			if err := d.importPaths.AddPath(projectPath); err != nil {
-				panic(err)
-			}
-		}
-	}
 }
 
 func (d *Document) Types() data.TypesRegistry[data.Resource] {
@@ -122,10 +99,6 @@ func (d *Document) Set(key string, value any) {
 	d.uris.Set(key, value.(data.Declaration))
 }
 
-func (d *Document) Delete(key string) {
-	d.uris.Delete(key)
-}
-
 func (d *Document) GetResource(uri string) *Declaration {
 	if decl, ok := d.uris[uri]; ok {
 		return decl.(*Declaration)
@@ -169,15 +142,7 @@ func (d *Document) ImportedDocuments() (documents []data.Document) {
 func (d *Document) loadImports() (err error) {
 	for _, uri := range d.Imports {
 		if ! DocumentRegistry.HasDocument(uri) {
-			var load URI = uri
+			if _, err = DocumentRegistry.Load(uri); err != nil {
-			if ! load.Exists() {
-				foundURI := d.importPaths.FindURI(load)
-				if foundURI != "" {
-					load = foundURI
-				}
-			}
-			slog.Info("Document.loadImports()", "load", load, "uri", uri, "importpaths", d.importPaths, "doc", d.URI)
-			if _, err = DocumentRegistry.Load(load); err != nil {
 				return
 			}
 		}
@@ -358,10 +323,6 @@ func (d *Document) MapResourceURI(uri string, declaration data.Declaration) {
 	d.uris[uri] = declaration
 }
 
-func (d *Document) UnMapResourceURI(uri string) {
-	d.uris.Delete(uri)
-}
-
 func (d *Document) AddDeclaration(declaration data.Declaration) {
 	uri := declaration.URI()
 	decl := declaration.(*Declaration)
@@ -421,7 +382,7 @@ func (d *Document) NewResourceFromURI(uri URI) (newResource data.Resource, err e
 	return d.NewResourceFromParsedURI(uri.Parse())
 }
 
-func (d *Document) NewResourceFromParsedURI(uri data.URIParser) (newResource data.Resource, err error) {
+func (d *Document) NewResourceFromParsedURI(uri *url.URL) (newResource data.Resource, err error) {
 	if uri == nil {
 		return nil, fmt.Errorf("%w: %s", ErrUnknownResourceType, uri)
 	}

internal/folio/document_test.go

@@ -84,9 +84,6 @@ resources:
 
 	f.Name = "mytestresource"
 	f.Size = 3
-
-	assert.Nil(t, f.Init(nil))
-
 	d.AddResourceDeclaration("foo", f)
 
 	ey := d.Generate(&documentYaml)

internal/folio/events.go

@@ -1,31 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package folio
-
-import (
-	"errors"
-_	"gitea.rosskeen.house/pylon/luaruntime"
-_	"fmt"
-)
-
-type EventHandler string
-
-type Events map[EventType]EventHandler
-
-var (
-	ErrInvalidHandler error = errors.New("Invalid event handler")
-)
-
-func NewEvents() *Events {
-	e := make(Events)
-	return &e
-}
-
-func (e *Events) Set(t EventType, h EventHandler) (err error) {
-	if err = t.Validate(); err == nil {
-		(*e)[t] = h
-	}
-	return
-}
-
-

internal/folio/events_test.go

@@ -1,22 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-
-package folio
-
-import (
-	"github.com/stretchr/testify/assert"
-	"testing"
-)
-
-
-func TestNewEvent(t *testing.T) {
-	var et EventType
-	events := NewEvents()
-	assert.NotNil(t, events)
-
-	assert.Nil(t, et.Set(EventTypeLoad))
-	assert.Nil(t, events.Set(et, EventHandler(`
-print('hello world')
-`)))
-
-}

internal/folio/eventtype.go

@@ -1,39 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package folio
-
-import (
-	"errors"
-	"fmt"
-)
-
-type EventType string
-
-const (
-	EventTypeLoad EventType = "load"
-	EventTypeCreate EventType = "create"
-	EventTypeRead EventType = "read"
-	EventTypeUpdate EventType = "update"
-	EventTypeDelete EventType = "delete"
-	EventTypeError EventType = "error"
-)
-
-var (
-	ErrUnknownEventType error = errors.New("Unknown EventType")
-)
-
-func (e EventType) Validate() (err error) {
-	switch e {
-	case EventTypeLoad, EventTypeCreate, EventTypeRead, EventTypeUpdate, EventTypeDelete, EventTypeError:
-	default:
-		return fmt.Errorf("%w: %s", ErrUnknownEventType, e)
-	}
-	return
-}
-
-func (e *EventType) Set(v EventType) (err error) {
-	if err = v.Validate(); err == nil {
-		(*e) = v
-	}
-	return
-}

internal/folio/eventtype_test.go

@@ -1,29 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-
-package folio
-
-import (
-	"github.com/stretchr/testify/assert"
-	"testing"
-)
-
-
-func TestEventType(t *testing.T) {
-	for _, v := range []struct{ et EventType; expected error } {
-		{ et: EventType("load"), expected: nil },
-		{ et: EventType("create"), expected: nil },
-		{ et: EventType("read"), expected: nil },
-		{ et: EventType("update"), expected: nil },
-		{ et: EventType("delete"), expected: nil },
-		{ et: EventType("error"), expected: nil },
-		{ et: EventType("foo"), expected: ErrUnknownEventType },
-	} {
-		assert.ErrorIs(t, v.et.Validate(), v.expected)
-	}
-}
-
-func TestEventTypeSet(t *testing.T) {
-	var et EventType
-	assert.Nil(t, et.Set(EventTypeLoad))
-}

internal/folio/mock_configuration_test.go

@@ -10,6 +10,7 @@ _	"fmt"
 	"decl/internal/data"
 	"decl/internal/codec"
 	"io"
+	"net/url"
 )
 
 type MockConfiguration struct {
@@ -37,7 +38,7 @@ func (m *MockConfiguration) SetURI(uri string) error {
 	return nil
 }
 
-func (m *MockConfiguration) SetParsedURI(uri data.URIParser) error {
+func (m *MockConfiguration) SetParsedURI(uri *url.URL) error {
 	return nil
 }
 

internal/folio/mock_foo_resource_test.go

@@ -17,30 +17,22 @@ _	"gopkg.in/yaml.v3"
 func RegisterMocks() {
 	TestResourceTypes.Register([]string{"foo"}, func(u *url.URL) data.Resource {
 		f := NewFooResource()
-		if u != nil {
 		f.Name = filepath.Join(u.Hostname(), u.Path)
-		}
 		return f
 	})
 	TestResourceTypes.Register([]string{"bar"}, func(u *url.URL) data.Resource {
 		f := NewBarResource()
-		if u != nil {
 		f.Name = filepath.Join(u.Hostname(), u.Path)
-		}
 		return f
 	})
 	TestResourceTypes.Register([]string{"testuser"}, func(u *url.URL) data.Resource {
 		f := NewTestuserResource()
-		if u != nil {
 		f.Name = filepath.Join(u.Hostname(), u.Path)
-		}
 		return f
 	})
 	TestResourceTypes.Register([]string{"file"}, func(u *url.URL) data.Resource {
 		f := NewFileResource()
-		if u != nil {
 		f.Name = filepath.Join(u.Hostname(), u.Path)
-		}
 		return f
 	})
 }
@@ -48,20 +40,23 @@ func RegisterMocks() {
 
 type MockFoo struct {
 	stater machine.Stater `json:"-" yaml:"-"`
-	*MockResource `json:",inline" yaml:",inline"`
+	*MockResource `json:"-" yaml:"-"`
+	Name string `json:"name" yaml:"name"`
 	Size int `json:"size" yaml:"size"`
 }
 
 type MockBar struct {
 	stater machine.Stater `json:"-" yaml:"-"`
-	*MockResource `json:",inline" yaml:",inline"`
+	*MockResource `json:"-" yaml:"-"`
+	Name string `json:"name" yaml:"name"`
 	Size int `json:"size,omitempty" yaml:"size,omitempty"`
 	Owner string `json:"owner,omitempty" yaml:"owner,omitempty"`
 }
 
 type MockTestuser struct {
 	stater machine.Stater `json:"-" yaml:"-"`
-	*MockResource `json:",inline" yaml:",inline"`
+	*MockResource `json:"-" yaml:"-"`
+	Name string `json:"name" yaml:"name"`
 	Uid string `json:"uid" yaml:"uid"`
 	Group string `json:"group" yaml:"group"`
 	Home string `json:"home" yaml:"home"`
@@ -69,12 +64,13 @@ type MockTestuser struct {
 
 type MockFile struct {
 	stater machine.Stater `json:"-" yaml:"-"`
-	*MockResource `json:",inline" yaml:",inline"`
+	*MockResource `json:"-" yaml:"-"`
+	Name string `json:"name" yaml:"name"`
 	Size int `json:"size" yaml:"size"`
 }
 
-func NewMockResource(typename string, stater machine.Stater) (m *MockResource) {
+func NewMockResource(typename string, stater machine.Stater) *MockResource {
-	m = &MockResource {
+	return &MockResource {
 		InjectType: func() string { return typename },
 		InjectResolveId: func(ctx context.Context) string { return "bar" },
 		InjectLoadDecl: func(string) error { return nil },
@@ -93,13 +89,6 @@ func NewMockResource(typename string, stater machine.Stater) (m *MockResource) {
 		InjectURI: func() string { return fmt.Sprintf("%s://bar", typename) },
 		InjectNotify: func(*machine.EventMessage) {},
 	}
-	m.InjectInit = func(u data.URIParser) error { 
-		if u != nil {
-			m.Name = filepath.Join(u.URL().Hostname(), u.URL().Path)
-		}
-		return nil
-	}
-	return m
 }
 
 func NewFooResource() *MockFoo {

internal/folio/mock_resource_test.go

@@ -11,11 +11,10 @@ _	"fmt"
 	"decl/internal/data"
 	"decl/internal/codec"
 	"io"
+	"net/url"
 )
 
 type MockResource struct {
-	Name string `json:"name" yaml:"name"`
-	InjectInit func(data.URIParser) error  `json:"-" yaml:"-"`
 	InjectURI func() string  `json:"-" yaml:"-"`
 	InjectType func() string `json:"-" yaml:"-"`
 	InjectResolveId func(ctx context.Context) string `json:"-" yaml:"-"`
@@ -55,7 +54,7 @@ func (m *MockResource) SetURI(uri string) error {
 	return nil
 }
 
-func (m *MockResource) SetParsedURI(uri data.URIParser) error {
+func (m *MockResource) SetParsedURI(uri *url.URL) error {
 	return nil
 }
 
@@ -127,10 +126,6 @@ func (m *MockResource) Apply() error {
   return m.InjectApply()
 }
 
-func (m *MockResource) Init(u data.URIParser) (error) {
-	return m.InjectInit(u)
-}
-
 func (m *MockResource) Type() string {
   return m.InjectType()
 }

internal/folio/parseduri.go

@@ -1,102 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package folio
-
-import (
-	"net/url"
-	"decl/internal/transport"
-	"decl/internal/data"
-	"decl/internal/identifier"
-	"strings"
-)
-
-
-var (
-)
-
-type ParsedURI url.URL
-
-func NewParsedURI(uri URI) *ParsedURI {
-	return uri.Parse().(*ParsedURI)
-}
-
-func CastParsedURI(u *url.URL) *ParsedURI {
-	return (*ParsedURI)(u)
-}
-
-func (uri *ParsedURI) URL() *url.URL {
-	return (*url.URL)(uri)
-}
-
-func (uri *ParsedURI) Hostname() string {
-	return (*url.URL)(uri).Hostname()
-}
-
-func (uri *ParsedURI) NewResource(document data.Document) (newResource data.Resource, err error) {
-	if document == nil {
-		declaration := NewDeclaration()
-		if err = declaration.NewResourceFromParsedURI(uri); err == nil {
-			return declaration.Attributes, err
-		}
-	} else {
-		newResource, err = document.NewResourceFromParsedURI(uri)
-		return
-	}
-	return
-}
-
-func (uri *ParsedURI) ConstructResource(res data.Resource) (err error) {
-	if ri, ok := res.(data.ResourceInitializer); ok {
-		err = ri.Init(uri)
-	} else {
-		err = res.SetParsedURI(uri)
-	}
-	return
-}
-
-func (uri *ParsedURI) Converter() (converter data.Converter, err error) {
-	return DocumentRegistry.ConverterTypes.NewFromParsedURI(uri.URL())
-}
-
-func (uri *ParsedURI) Exists() bool {
-	return transport.Exists(uri.URL())
-}
-
-func (uri *ParsedURI) ContentReaderStream() (*transport.Reader, error) {
-	return transport.NewReader(uri.URL())
-}
-
-func (uri *ParsedURI) ContentWriterStream() (*transport.Writer, error) {
-	return transport.NewWriter(uri.URL())
-}
-
-func (uri *ParsedURI) String() string {
-	return uri.URL().String()
-}
-
-func (uri *ParsedURI) SetURL(url *url.URL) {
-	*uri = *(*ParsedURI)(url)
-}
-
-func (uri *ParsedURI) Extension() (string, string) {
-	return (identifier.ID)(uri.Path).Extension()
-}
-
-func (uri *ParsedURI) ContentType() string {
-	var ext strings.Builder
-	exttype, fileext := uri.Extension()
-	if fileext == "" {
-		return exttype
-	}
-	ext.WriteString(exttype)
-	ext.WriteRune('.')
-	ext.WriteString(fileext)
-	return ext.String()
-}
-
-func (uri *ParsedURI) IsEmpty() bool {
-	if uri == nil || (identifier.ID)(uri.String()).IsEmpty() {
-		return true
-	}
-	return false
-}

internal/folio/registry.go

@@ -69,7 +69,7 @@ func (r *Registry) SetDocument(key URI, value *Document) {
 
 func (r *Registry) NewDocument(uri URI) (doc *Document) {
 	doc = NewDocument(r)
-	doc.SetURI(string(uri))
+	doc.URI = uri
 	r.Documents = append(r.Documents, doc)
 	if uri != "" {
 		r.UriMap[uri] = doc
@@ -88,17 +88,17 @@ func (r *Registry) AppendParsedURI(uri *url.URL, documents []data.Document) (add
 			case data.ManyExtractor:
 				var docs []data.Document
 				docs, err = extractor.ExtractMany(sourceResource, nil)
-				slog.Info("folio.Registry.AppendParsedURI() - ExtractMany", "uri", uri, "source", sourceResource, "docs", docs, "error", err)
+				slog.Info("folio.Registry.Append() - ExtractMany", "uri", uri, "source", sourceResource, "docs", docs, "error", err)
 				documents = append(documents, docs...)
 			case data.Extractor:
 				var singleDocument data.Document
 				singleDocument, err = extractor.Extract(sourceResource, nil)
-				slog.Info("folio.Registry.AppendParsedURI() - Extract", "uri", uri, "source", sourceResource, "doc", singleDocument, "error", err)
+				slog.Info("folio.Registry.Append() - Extract", "uri", uri, "source", sourceResource, "doc", singleDocument, "error", err)
 				documents = append(documents, singleDocument)
 			}
 		}
 	}
-	slog.Info("folio.Registry.AppendParsedURI()", "uri", uri, "converter", r.ConverterTypes, "error", err)
+	slog.Info("folio.Registry.Append()", "uri", uri, "converter", r.ConverterTypes, "error", err)
 	addedDocuments = documents
 	return
 }
@@ -130,8 +130,6 @@ func (r *Registry) Append(uri URI, documents []data.Document) (addedDocuments []
 				slog.Info("folio.Registry.Append() - Extract", "uri", uri, "source", sourceResource, "doc", singleDocument, "error", err)
 				documents = append(documents, singleDocument)
 			}
-		} else {
-			slog.Warn("folio.Registry.Append(): failed loading extractor as resource")
 		}
 	}
 	slog.Info("folio.Registry.Append()", "uri", uri, "converter", r.ConverterTypes, "error", err)
@@ -148,8 +146,3 @@ func (r *Registry) LoadFromURL(uri *url.URL) (documents []data.Document, err err
 	documents = make([]data.Document, 0, 10)
 	return r.AppendParsedURI(uri, documents)
 }
-
-func (r *Registry) LoadFromParsedURI(uri *url.URL) (documents []data.Document, err error) {
-	documents = make([]data.Document, 0, 10)
-	return r.AppendParsedURI(uri, documents)
-}

internal/folio/resource.go

@@ -15,11 +15,11 @@ var (
 func NewResourceFromParsedURI(u *url.URL, document data.Document) (newResource data.Resource, err error) {
 	if document == nil {
 		declaration := NewDeclaration()
-		if err = declaration.NewResourceFromParsedURI((*ParsedURI)(u)); err == nil {
+		if err = declaration.NewResourceFromParsedURI(u); err == nil {
 			return declaration.Attributes, err
 		}
 	} else {
-		newResource, err = document.NewResourceFromParsedURI((*ParsedURI)(u))
+		newResource, err = document.NewResourceFromParsedURI(u)
 		return
 	}
 	return

internal/folio/resourcereference.go

@@ -56,7 +56,7 @@ func (r ResourceReference) Dereference(look data.ResourceMapper) data.Resource {
 }
 
 func (r ResourceReference) Parse() *url.URL {
-	return URI(r).Parse().URL()
+	return URI(r).Parse()
 }
 
 func (r ResourceReference) Exists() bool {

internal/folio/searchpath.go

@@ -1,65 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package folio
-
-import (
-	"decl/internal/ext"
-	"decl/internal/ds"
-	"errors"
-	"fmt"
-	"log/slog"
-	"path/filepath"
-	"decl/internal/data"
-)
-
-var (
-	ErrSearchPathNotExist error = errors.New("Search path does not exist.")
-)
-
-// A search path should find a file in list of paths
-
-type SearchPath struct {
-	paths *ds.OrderedSet[string]
-}
-
-func NewSearchPath(paths []string) (s *SearchPath) {
-	s = &SearchPath{ paths: ds.NewOrderedSet[string]() }
-	s.paths.AddItems(paths)
-	return
-}
-
-func (s *SearchPath) AddPath(path string) error {
-	if newPath := ext.FilePath(path).Abs(); newPath.Exists() {
-		s.paths.Add(string(newPath))
-	} else {
-		return fmt.Errorf("%w: %s", ErrSearchPathNotExist, path)
-	}
-	return nil
-}
-
-func (s *SearchPath) Find(relative string) string {
-	pathValues := s.paths.Items()
-	for i := len(pathValues) - 1; i >= 0; i-- {
-		p := *pathValues[i]
-		searchPath := ext.FilePath(p)
-		searchPath.Add(relative)
-		slog.Info("SearchPath.Find()", "searchpath", p, "file", relative, "target", searchPath)
-		if searchPath.Exists() {
-			return string(searchPath)
-		}
-	}
-	return ""
-}
-
-func (s *SearchPath) FindParsedURI(uri data.URIParser) (result URI) {
-	u := uri.URL()
-	filePath := filepath.Join(u.Hostname(), u.Path)
-	if absPath := s.Find(filePath); absPath != "" {
-		result = URI(fmt.Sprintf("%s://%s", u.Scheme, string(absPath)))
-	}
-	return
-}
-
-func (s *SearchPath) FindURI(uri URI) (result URI) {
-	return s.FindParsedURI(uri.Parse())
-}

internal/folio/searchpath_test.go

@@ -1,24 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package folio
-
-import (
-	"github.com/stretchr/testify/assert"
-	"testing"
-	"os"
-)
-
-func TestSearchPath(t *testing.T) {
-
-	assert.Nil(t, TempDir.CreateFile("test.jx.yaml", ""))
-
-	sp := NewSearchPath(nil)
-	assert.NotNil(t, sp)
-
-	assert.Nil(t, sp.AddPath(string(TempDir)))
-
-	absPath := sp.Find("test.jx.yaml")
-	_, err := os.Stat(absPath)
-	assert.True(t, !os.IsNotExist(err))
-
-}

internal/folio/uri.go

@@ -35,24 +35,14 @@ func (u URI) NewResource(document data.Document) (newResource data.Resource, err
 	return
 }
 
-func (u URI) ConstructResource(res data.Resource) (err error) {
-	parsedURI := u.Parse()
-	if ri, ok := res.(data.ResourceInitializer); ok {
-		err = ri.Init(parsedURI)
-	} else {
-		err = res.SetParsedURI(parsedURI)
-	}
-	return
-}
-
 func (u URI) Converter() (converter data.Converter, err error) {
 	return DocumentRegistry.ConverterTypes.New(string(u))
 }
 
-func (u URI) Parse() data.URIParser {
+func (u URI) Parse() *url.URL {
 	url, e := url.Parse(string(u))
 	if e == nil {
-		return (*ParsedURI)(url)
+		return url
 	}
 	return nil
 }

internal/folio/uri_test.go

@@ -10,17 +10,17 @@ import (
 
 func TestURI(t *testing.T) {
 	var file URI = URI(fmt.Sprintf("file://%s", TempDir))
-	u := file.Parse().URL()
+	u := file.Parse()
 	assert.Equal(t, "file", u.Scheme)
 	assert.True(t, file.Exists())
 	file = URI(fmt.Sprintf("0file:_/%s", TempDir))
-	x := file.Parse()
+	u = file.Parse()
-	assert.Nil(t, x)
+	assert.Nil(t, u)
 }
 
 func TestURISetURL(t *testing.T) {
 	var file URI = URI(fmt.Sprintf("file://%s", TempDir))
-	u := file.Parse().URL()
+	u := file.Parse()
 	var fileFromURL URI
 	fileFromURL.SetURL(u)
 	assert.Equal(t, fileFromURL, file)

internal/mapper/mapper.go

@@ -18,15 +18,10 @@ func (m Store[Key, Value]) Set(key Key, value Value) {
 	m[key] = value
 }
 
-func (m Store[Key, Value]) Delete(key Key) {
-	delete(m, key)
-}
-
 type Mapper interface {
 	Get(key string) (any, bool)
 	Has(key string) (bool)
 	Set(key string, value any)
-	Delete(key string)
 }
 
 type Getter[Key comparable, Value comparable] interface {
@@ -38,7 +33,6 @@ type Map[Key comparable, Value comparable] interface {
 	Get(key Key) (Value, bool)
 	Has(key Key) (bool)
 	Set(key Key, value Value)
-	Delete(key Key)
 }
 
 func New[Key comparable, Value comparable]() Store[Key, Value] {

internal/resource/command.go

@@ -0,0 +1,129 @@
+// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
+
+package resource
+
+import (
+_	"context"
+	"encoding/json"
+	"fmt"
+	"gopkg.in/yaml.v3"
+	"io"
+	"log/slog"
+_	"net/url"
+_	"os"
+	"os/exec"
+	"strings"
+	"text/template"
+	"decl/internal/codec"
+)
+
+type CommandExecutor func(value any) ([]byte, error)
+type CommandExtractAttributes func(output []byte, target any) error
+
+type CommandArg string
+
+type Command struct {
+	Path      string                   `json:"path" yaml:"path"`
+	Args      []CommandArg             `json:"args" yaml:"args"`
+	Split     bool                     `json:"split" yaml:"split"`
+	Executor  CommandExecutor          `json:"-" yaml:"-"`
+	Extractor CommandExtractAttributes `json:"-" yaml:"-"`
+}
+
+func NewCommand() *Command {
+	c := &Command{ Split: true }
+	c.Executor = func(value any) ([]byte, error) {
+		args, err := c.Template(value)
+		if err != nil {
+			return nil, err
+		}
+		cmd := exec.Command(c.Path, args...)
+
+		slog.Info("execute() - cmd", "path", c.Path, "args", args)
+		output, stdoutPipeErr := cmd.StdoutPipe()
+		if stdoutPipeErr != nil {
+			return nil, stdoutPipeErr
+		}
+
+		stderr, pipeErr := cmd.StderrPipe()
+		if pipeErr != nil {
+			return nil, pipeErr
+		}
+
+		if startErr := cmd.Start(); startErr != nil {
+			return nil, startErr
+		}
+
+		slog.Info("execute() - start", "cmd", cmd)
+		stdOutOutput, _ := io.ReadAll(output)
+		stdErrOutput, _ := io.ReadAll(stderr)
+
+		slog.Info("execute() - io", "stdout", string(stdOutOutput), "stderr", string(stdErrOutput))
+		waitErr := cmd.Wait()
+
+		slog.Info("execute()", "path", c.Path, "args", args, "output", string(stdOutOutput), "error", string(stdErrOutput))
+
+		if len(stdErrOutput) > 0 {
+			return stdOutOutput, fmt.Errorf(string(stdErrOutput))
+		}
+		return stdOutOutput, waitErr
+	}
+	return c
+}
+
+func (c *Command) Load(r io.Reader) error {
+	return codec.NewYAMLDecoder(r).Decode(c)
+}
+
+func (c *Command) LoadDecl(yamlResourceDeclaration string) error {
+	return codec.NewYAMLStringDecoder(yamlResourceDeclaration).Decode(c)
+}
+
+func (c *Command) Template(value any) ([]string, error) {
+	var args []string = make([]string, 0, len(c.Args) * 2)
+	for i, arg := range c.Args {
+		var commandLineArg strings.Builder
+		err := template.Must(template.New(fmt.Sprintf("arg%d", i)).Parse(string(arg))).Execute(&commandLineArg, value)
+		if err != nil {
+			return nil, err
+		}
+		if commandLineArg.Len() > 0 {
+			var splitArg []string
+			if c.Split {
+				splitArg = strings.Split(commandLineArg.String(), " ")
+			} else {
+				splitArg = []string{commandLineArg.String()}
+			}
+			slog.Info("Template()", "split", splitArg, "len", len(splitArg))
+			args = append(args, splitArg...)
+		}
+	}
+	
+	slog.Info("Template()", "Args", c.Args, "lencargs", len(c.Args), "args", args, "lenargs", len(args), "value", value)
+	return args, nil
+}
+
+func (c *Command) Execute(value any) ([]byte, error) {
+	return c.Executor(value)
+}
+
+func (c *CommandArg) UnmarshalValue(value string) error {
+	*c = CommandArg(value)
+	return nil
+}
+
+func (c *CommandArg) UnmarshalJSON(data []byte) error {
+	var s string
+	if unmarshalRouteTypeErr := json.Unmarshal(data, &s); unmarshalRouteTypeErr != nil {
+		return unmarshalRouteTypeErr
+	}
+	return c.UnmarshalValue(s)
+}
+
+func (c *CommandArg) UnmarshalYAML(value *yaml.Node) error {
+	var s string
+	if err := value.Decode(&s); err != nil {
+		return err
+	}
+	return c.UnmarshalValue(s)
+}

internal/resource/command_test.go

@@ -0,0 +1,58 @@
+// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
+
+
+package resource
+
+import (
+_	"fmt"
+	"github.com/stretchr/testify/assert"
+_	"os"
+_	"strings"
+	"testing"
+)
+
+func TestNewCommand(t *testing.T) {
+	c := NewCommand()
+	assert.NotNil(t, c)
+}
+
+func TestCommandLoad(t *testing.T) {
+	c := NewCommand()
+	assert.NotNil(t, c)
+
+	decl := `
+path: find
+args:
+- "{{ .Path }}"
+`
+
+	assert.Nil(t, c.LoadDecl(decl))
+	assert.Equal(t, "find", c.Path)
+}
+
+func TestCommandTemplate(t *testing.T) {
+	c := NewCommand()
+	assert.NotNil(t, c)
+
+	decl := `
+path: find
+args:
+- "{{ .Path }}"
+`
+
+	assert.Nil(t, c.LoadDecl(decl))
+	assert.Equal(t, "find", c.Path)
+	assert.Equal(t, 1, len(c.Args))
+
+	f := NewFile()
+	f.Path = "./"
+	args, templateErr := c.Template(f)
+	assert.Nil(t, templateErr)
+	assert.Equal(t, 1, len(args))
+
+	assert.Equal(t, "./", string(args[0]))
+
+	out, err := c.Execute(f)
+	assert.Nil(t, err)
+	assert.Greater(t, len(out), 0)
+}

internal/resource/common.go

@@ -13,16 +13,14 @@ import (
 )
 
 type UriSchemeValidator func(scheme string) bool
-type UriNormalize func() error
 
 type Common struct {
 	SchemeCheck UriSchemeValidator `json:"-" yaml:"-"`
-	NormalizePath UriNormalize `json:"-" yaml:"-"`
 	includeQueryParamsInURI bool `json:"-" yaml:"-"`
 	resourceType TypeName `json:"-" yaml:"-"`
+	Uri folio.URI `json:"uri,omitempty" yaml:"uri,omitempty"`
 	parsedURI *url.URL `json:"-" yaml:"-"`
 	Path string `json:"path,omitempty" yaml:"path,omitempty"`
-	absPath string `json:"-" yaml:"-"`
 
 	exttype string `json:"-" yaml:"-"`
 	fileext string `json:"-" yaml:"-"`
@@ -36,7 +34,6 @@ type Common struct {
 func NewCommon(resourceType TypeName, includeQueryParams bool) *Common {
 	c := &Common{ includeQueryParamsInURI: includeQueryParams, resourceType: resourceType }
 	c.SchemeCheck = c.IsValidResourceScheme
-	c.NormalizePath = c.NormalizeFilePath
 	return c
 }
 
@@ -57,13 +54,9 @@ func (c *Common) SetResourceMapper(resources data.ResourceMapper) {
 
 func (c *Common) Clone() *Common {
 	return &Common {
-		SchemeCheck: c.SchemeCheck,
+		Uri: c.Uri,
-		NormalizePath: c.NormalizePath,
-		includeQueryParamsInURI: c.includeQueryParamsInURI,
-		resourceType: c.resourceType,
 		parsedURI: c.parsedURI,
 		Path: c.Path,
-		absPath: c.absPath,
 		exttype: c.exttype,
 		fileext: c.fileext,
 		normalizePath: c.normalizePath,
@@ -81,35 +74,41 @@ func (c *Common) URIPath() string {
 	return c.Path
 }
 
-func (c *Common) URI() folio.URI {
+func (c *Common) URI() string {
-	slog.Info("Common.URI", "parsed", c.parsedURI)
+	return string(c.Uri)
-	return folio.URI(c.parsedURI.String())
 }
 
-func (c *Common) SetParsedURI(u data.URIParser) (err error) {
+func (c *Common) SetURI(uri string) (err error) {
+	c.SetURIFromString(uri)
+	err = c.SetParsedURI(c.Uri.Parse())
+	return
+}
+
+func (c *Common) SetURIFromString(uri string) {
+	c.Uri = folio.URI(uri)
+	c.exttype, c.fileext = c.Uri.Extension()
+}
+
+func (c *Common) SetParsedURI(u *url.URL) (err error) {
 	if u != nil {
-
+		slog.Info("Common.SetParsedURI()", "parsed", u, "uri", c.Uri)
-		slog.Info("Common.SetParsedURI()", "parsed", u, "uri", c)
+		if c.Uri.IsEmpty()  {
-
+			c.SetURIFromString(u.String())
-		c.parsedURI = u.URL()
+		}
-
+		c.parsedURI = u
-		c.exttype, c.fileext = u.Extension()
 		if c.SchemeCheck(c.parsedURI.Scheme) {
 			if c.includeQueryParamsInURI {
 				c.Path = filepath.Join(c.parsedURI.Hostname(), c.parsedURI.RequestURI())
 			} else {
 				c.Path = filepath.Join(c.parsedURI.Hostname(), c.parsedURI.Path)
 			}
-			if c.absPath, err = filepath.Abs(c.Path); err != nil {
-				return
-			}
 			if err = c.NormalizePath(); err != nil {
 				return
 			}
 			return
 		}
 	}
-	err = fmt.Errorf("%w: %s is not a %s resource, parsed: %t", ErrInvalidResourceURI, c.URI(), c.Type(), (u != nil))
+	err = fmt.Errorf("%w: %s is not a %s resource, parsed: %t", ErrInvalidResourceURI, c.Uri, c.Type(), (u != nil))
 	return
 }
 
@@ -118,27 +117,26 @@ func (c *Common) UseConfig(config data.ConfigurationValueGetter) {
 }
 
 func (c *Common) ResolveId(ctx context.Context) string {
-	var err error
+	if e := c.NormalizePath(); e != nil {
-	if c.absPath, err = filepath.Abs(c.Path); err != nil {
+		panic(e)
-		panic(err)
-	}
-	if err = c.NormalizePath(); err != nil {
-		panic(err)
 	}
 	return c.Path
 }
 
-// Common path normalization for a file resource.
+func (c *Common) NormalizePath() error {
-func (c *Common) NormalizeFilePath() (err error) {
 	if c.config != nil {
 		if prefixPath, configErr := c.config.GetValue("prefix"); configErr == nil {
 			c.Path = filepath.Join(prefixPath.(string), c.Path)
 		}
 	}
 	if c.normalizePath {
-		c.Path = c.absPath
+		filePath, fileAbsErr := filepath.Abs(c.Path)
+		if fileAbsErr == nil {
+			c.Path = filePath
 		}
-	return
+		return fileAbsErr
+	}
+	return nil
 }
 
 func (c *Common) Type() string { return string(c.resourceType) }

internal/resource/common_test.go

@@ -6,7 +6,6 @@ import (
 	"github.com/stretchr/testify/assert"
 	"testing"
 	"net/url"
-	"decl/internal/folio"
 )
 
 func TestNewCommon(t *testing.T) {
@@ -17,15 +16,16 @@ func TestNewCommon(t *testing.T) {
 func TestCommon(t *testing.T) {
 	expectedCommon := NewCommon(FileTypeName, false)
 	expectedCommon.resourceType = "file"
+	expectedCommon.Uri = "file:///tmp/foo"
 	expectedCommon.parsedURI = &url.URL{ Scheme: "file", Path: "/tmp/foo"}
 	expectedCommon.Path = "/tmp/foo"
-	for _, v := range []struct{ uri folio.URI; expected *Common }{
+	for _, v := range []struct{ uri string; expected *Common }{
 		{ uri: "file:///tmp/foo", expected: expectedCommon },
 	}{
 
 		c := NewCommon(FileTypeName, false)
 		c.resourceType = "file"
-		assert.Nil(t, c.SetParsedURI(v.uri.Parse()))
+		assert.Nil(t, c.SetURI(v.uri))
 		assert.Equal(t, v.expected.resourceType , c.resourceType)
 		assert.Equal(t, v.expected.Path, c.Path)
 		assert.Equal(t, v.expected.parsedURI.Scheme, c.parsedURI.Scheme)

internal/resource/container.go

@@ -28,7 +28,6 @@ _	"os/exec"
 	"gitea.rosskeen.house/rosskeen.house/machine"
 	"decl/internal/codec"
 	"decl/internal/data"
-	"decl/internal/folio"
 )
 
 const (
@@ -51,6 +50,7 @@ type Container struct {
 	stater		machine.Stater		`yaml:"-" json:"-"`
 	Id		string			`json:"ID,omitempty" yaml:"ID,omitempty"`
 	Name		string			`json:"name" yaml:"name"`
+//	Path		string			`json:"path" yaml:"path"`
 	Cmd		[]string		`json:"cmd,omitempty" yaml:"cmd,omitempty"`
 	Entrypoint	strslice.StrSlice	`json:"entrypoint,omitempty" yaml:"entrypoint,omitempty"`
 	Args		[]string		`json:"args,omitempty" yaml:"args,omitempty"`
@@ -81,19 +81,21 @@ type Container struct {
 	   NetworkSettings *NetworkSettings
 	*/
 
+//	State string `yaml:"state,omitempty" json:"state,omitempty"`
+
+//	config ConfigurationValueGetter
 	apiClient ContainerClient
-	Resources data.ResourceMapper		`json:"-" yaml:"-"`
+//	Resources data.ResourceMapper							`json:"-" yaml:"-"`
 }
 
 func init() {
-	ResourceTypes.Register([]string{"container"}, func(u *url.URL) (c data.Resource) {
+	ResourceTypes.Register([]string{"container"}, func(u *url.URL) data.Resource {
-		c = NewContainer(nil)
+		c := NewContainer(nil)
-		if u != nil {
+		c.Name = filepath.Join(u.Hostname(), u.Path)
-			if err := folio.CastParsedURI(u).ConstructResource(c); err != nil {
+		if err := c.Common.SetParsedURI(u); err == nil {
-				panic(err)
+			return c
 		}
-		}
+		return nil
-		return
 	})
 }
 
@@ -112,22 +114,6 @@ func NewContainer(containerClientApi ContainerClient) *Container {
 	}
 }
 
-func (c *Container) Init(u data.URIParser) error {
-	if u == nil {
-		u = folio.URI(c.URI()).Parse()
-	}
-	uri := u.URL()
-	c.Name = filepath.Join(uri.Hostname(), uri.Path)
-	return c.SetParsedURI(u)
-}
-
-func (c *Container) SetParsedURI(u data.URIParser) (err error) {
-	if err = c.Common.SetParsedURI(u); err == nil {
-		c.Name = filepath.Join(c.Common.parsedURI.Hostname(), c.Common.parsedURI.Path)
-	}
-	return
-}
-
 func (c *Container) SetResourceMapper(resources data.ResourceMapper) {
 	c.Resources = resources
 }
@@ -136,7 +122,7 @@ func (c *Container) Clone() data.Resource {
 	return &Container {
 		Id: c.Id,
 		Name: c.Name,
-		Common: c.Common.Clone(),
+		Common: c.Common,
 		Cmd: c.Cmd,
 		Entrypoint: c.Entrypoint,
 		Args: c.Args,
@@ -160,6 +146,7 @@ func (c *Container) Clone() data.Resource {
 		SizeRw: c.SizeRw,
 		SizeRootFs: c.SizeRootFs,
 		Networks: c.Networks,
+//		State: c.State,
 		apiClient: c.apiClient,
 	}
 }
@@ -171,6 +158,10 @@ func (c *Container) StateMachine() machine.Stater {
 	return c.stater
 }
 
+func (c *Container) UseConfig(config data.ConfigurationValueGetter) {
+	c.config = config
+}
+
 func (c *Container) JSON() ([]byte, error) {
 	return json.Marshal(c)
 }
@@ -438,7 +429,7 @@ func (c *Container) Type() string { return "container" }
 func (c *Container) ResolveId(ctx context.Context) string {
 	var err error
 
-	if err = c.Common.SetParsedURI(folio.URI(c.URI()).Parse()); err != nil {
+	if err = c.Common.SetURI(c.URI()); err != nil {
 		triggerErr := c.StateMachine().Trigger("notexists")
 		panic(fmt.Errorf("%w: %s %s, %w", err, c.Type(), c.Name, triggerErr))
 	}

internal/resource/container_image.go

@@ -101,14 +101,11 @@ type ContainerImage struct {
 }
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"container-image"}, func(u *url.URL) (c data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"container-image"}, func(u *url.URL) data.Resource {
-		c = NewContainerImage(nil)
+		c := NewContainerImage(nil)
-		if u != nil {
+		c.Name = ContainerImageNameFromURI(u)
-			if err := folio.CastParsedURI(u).ConstructResource(c); err != nil {
+		slog.Info("NewContainerImage", "container", c)
-				panic(err)
+		return c
-			}
-		}
-		return
 	})
 }
 
@@ -121,24 +118,13 @@ func NewContainerImage(containerClientApi ContainerImageClient) *ContainerImage
 			panic(err)
 		}
 	}
-	c := &ContainerImage{
+	return &ContainerImage{
-		Common: NewCommon(ContainerImageTypeName, true),
+		Common: &Common{ includeQueryParamsInURI: true, resourceType: ContainerImageTypeName },
 		apiClient: apiClient,
 		InjectJX: true,
 		PushImage: false,
 		ConverterTypes: folio.DocumentRegistry.ConverterTypes,
 	}
-	c.Common.NormalizePath = c.NormalizePath
-	return c
-}
-
-func (c *ContainerImage) Init(u data.URIParser) (err error) {
-	if u == nil {
-		u = folio.URI(c.URI()).Parse()
-        }
-	err = c.SetParsedURI(u)
-	c.Name = ContainerImageNameFromURI(u.URL())
-	return
 }
 
 func (c *ContainerImage) RegistryAuthConfig() (authConfig registry.AuthConfig, err error) {
@@ -189,10 +175,6 @@ func (c *ContainerImage) RegistryAuth() (string, error) {
 	}
 }
 
-func (c *ContainerImage) NormalizePath() error {
-	return nil
-}
-
 func (c *ContainerImage) SetResourceMapper(resources data.ResourceMapper) {
 	c.Resources = resources
 }
@@ -267,6 +249,24 @@ func (c *ContainerImage) URI() string {
 	return URIFromContainerImageName(c.Name)
 }
 
+/*
+func (c *ContainerImage) SetURI(uri string) error {
+	resourceUri, e := url.Parse(uri)
+	if e == nil {
+		if resourceUri.Scheme == c.Type() {
+			c.Name = strings.Join([]string{resourceUri.Hostname(), resourceUri.RequestURI()}, ":")
+		} else {
+			e = fmt.Errorf("%w: %s is not a %s", ErrInvalidResourceURI, uri, c.Type())
+		}
+	}
+	return e
+}
+
+func (c *ContainerImage) UseConfig(config data.ConfigurationValueGetter) {
+	c.config = config
+}
+*/
+
 func (c *ContainerImage) JSON() ([]byte, error) {
 	return json.Marshal(c)
 }
@@ -789,6 +789,12 @@ func (c *ContainerImage) Delete(ctx context.Context) error {
 
 	_, err := c.apiClient.ImageRemove(ctx, c.Id, options)
 	return err
+/*
+for _, img := range deletedImages {
+fmt.Printf("Deleted image: %s\n", img.Deleted)
+fmt.Printf("Untagged image: %s\n", img.Untagged)
+}
+*/
 }
 
 func (c *ContainerImage) Type() string { return "container-image" }
@@ -815,3 +821,5 @@ func (c *ContainerImage) ResolveId(ctx context.Context) string {
 	}
 	return c.Id
 }
+
+

internal/resource/container_network.go

@@ -15,6 +15,7 @@ _	"log/slog"
 	"net/url"
 _	"os"
 _	"os/exec"
+	"path/filepath"
 _	"strings"
 	"encoding/json"
 	"io"
@@ -47,24 +48,21 @@ type ContainerNetwork struct {
 	Internal				bool		`json:"internal,omitempty" yaml:"internal,omitempty"`
 	Labels					map[string]string	`json:"labels,omitempty" yaml:"labels,omitempty"`
 	Created					time.Time	`json:"created" yaml:"created"`
+	//State string `yaml:"state"`
 
 	apiClient ContainerNetworkClient
 	Resources data.ResourceMapper `json:"-" yaml:"-"`
 }
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"container-network"}, func(u *url.URL) (n data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"container-network"}, func(u *url.URL) data.Resource {
-		n = NewContainerNetwork(nil)
+		n := NewContainerNetwork(nil)
-		if u != nil {
+		n.Name = filepath.Join(u.Hostname(), u.Path)
-			if err := folio.CastParsedURI(u).ConstructResource(n); err != nil {
+		return n
-				panic(err)
-			}
-		}
-		return
 	})
 }
 
-func NewContainerNetwork(containerClientApi ContainerNetworkClient) (cn *ContainerNetwork) {
+func NewContainerNetwork(containerClientApi ContainerNetworkClient) *ContainerNetwork {
 	var apiClient ContainerNetworkClient = containerClientApi
 	if apiClient == nil {
 		var err error
@@ -73,23 +71,10 @@ func NewContainerNetwork(containerClientApi ContainerNetworkClient) (cn *Contain
 			panic(err)
 		}
 	}
-	cn = &ContainerNetwork{
+	return &ContainerNetwork{
+		Common: &Common{ includeQueryParamsInURI: true, resourceType: ContainerNetworkTypeName },
 		apiClient: apiClient,
 	}
-	cn.Common = NewCommon(ContainerNetworkTypeName, true)
-	cn.Common.NormalizePath = cn.NormalizePath
-	return cn
-}
-
-func (n *ContainerNetwork) Init(u data.URIParser) error {
-	if u == nil {
-		u = folio.URI(n.URI()).Parse()
-	}
-	return n.SetParsedURI(u)
-}
-
-func (n *ContainerNetwork) NormalizePath() error {
-	return nil
 }
 
 func (n *ContainerNetwork) SetResourceMapper(resources data.ResourceMapper) {
@@ -101,6 +86,7 @@ func (n *ContainerNetwork) Clone() data.Resource {
 		Common: n.Common,
 		Id: n.Id,
 		Name: n.Name,
+		//State: n.State,
 		apiClient: n.apiClient,
 	}
 }
@@ -162,6 +148,24 @@ func (n *ContainerNetwork) URI() string {
 	return fmt.Sprintf("container-network://%s", n.Name)
 }
 
+/*
+func (n *ContainerNetwork) SetURI(uri string) error {
+	resourceUri, e := url.Parse(uri)
+	if e == nil {
+		if resourceUri.Scheme == n.Type() {
+			n.Name, e = filepath.Abs(filepath.Join(resourceUri.Hostname(), resourceUri.RequestURI()))
+		} else {
+			e = fmt.Errorf("%w: %s is not a %s", ErrInvalidResourceURI, uri, n.Type())
+		}
+	}
+	return e
+}
+
+func (n *ContainerNetwork) UseConfig(config data.ConfigurationValueGetter) {
+	n.config = config
+}
+*/
+
 func (n *ContainerNetwork) JSON() ([]byte, error) {
 	return json.Marshal(n)
 }

internal/resource/exec.go

@@ -39,22 +39,9 @@ type Exec struct {
 }
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"exec"}, func(u *url.URL) (res data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"exec"}, func(u *url.URL) data.Resource {
 		x := NewExec()
-		res = x
+		return x
-		if u != nil {
-			uri := folio.CastParsedURI(u)
-			if ri, ok := res.(data.ResourceInitializer); ok {
-				if err := ri.Init(uri); err != nil {
-					panic(err)
-				}
-			} else {
-				if err := x.SetParsedURI(uri); err != nil {
-					panic(err)
-				}
-			}
-		}
-                return
 	})
 }
 
@@ -69,7 +56,7 @@ func (x *Exec) SetResourceMapper(resources data.ResourceMapper) {
 
 func (x *Exec) Clone() data.Resource {
 	return &Exec {
-		Common: x.Common.Clone(),
+		Common: x.Common,
 		Id: x.Id,
 		CreateTemplate: x.CreateTemplate,
 		ReadTemplate: x.ReadTemplate,
@@ -89,16 +76,13 @@ func (x *Exec) URI() string {
 	return fmt.Sprintf("exec://%s", x.Id)
 }
 
-func (x *Exec) Init(u data.URIParser) (err error) {
+func (x *Exec) SetURI(uri string) (err error) {
-	if u == nil {
+	err = x.Common.SetURI(uri)
-		u = folio.URI(x.URI()).Parse()
-	}
-	err = x.SetParsedURI(u)
 	x.Id = x.Common.Path
 	return
 }
 
-func (x *Exec) SetParsedURI(uri data.URIParser) (err error) {
+func (x *Exec) SetParsedURI(uri *url.URL) (err error) {
 	err = x.Common.SetParsedURI(uri)
 	x.Id = x.Common.Path
 	return

internal/resource/exec_test.go

@@ -18,7 +18,6 @@ _	"os"
 	_ "strings"
 	"testing"
 	"decl/internal/command"
-	"decl/internal/folio"
 )
 
 func TestNewExecResource(t *testing.T) {
@@ -56,10 +55,9 @@ func TestCreateExec(t *testing.T) {
 }
 
 func TestExecSetURI(t *testing.T) {
-	var uri folio.URI = "exec://12345_key"
 	x := NewExec()
 	assert.NotNil(t, x)
-	e := x.SetParsedURI(uri.Parse())
+	e := x.SetURI("exec://" + "12345_key")
 	assert.Nil(t, e)
 	assert.Equal(t, "exec", x.Type())
 	assert.Equal(t, "12345_key", x.Path)

internal/resource/file.go

@@ -14,6 +14,7 @@ import (
 	"net/url"
 	"os"
 	"os/user"
+	"path/filepath"
 	"strconv"
 	"syscall"
 	"time"
@@ -55,14 +56,19 @@ var ErrInvalidFileGroup error = errors.New("Unknown Group")
 type FileMode string
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"file"}, func(u *url.URL) (res data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"file"}, func(u *url.URL) data.Resource {
 		f := NewFile()
-		slog.Info("FileFactory", "uri", u)
+		f.parsedURI = u
-		if u != nil {
+		//f.Uri.SetURL(u)
-			if err := folio.CastParsedURI(u).ConstructResource(f); err != nil {
+		f.Path = filepath.Join(u.Hostname(), u.Path)
-				panic(err)
+		f.exttype, f.fileext = f.Uri.Extension()
-			}
+
+		slog.Info("folio.DocumentRegistry.ResourceTypes.Register()()", "url", u, "file", f)
+/*
+		if absPath, err := filepath.Abs(f.Path); err == nil {
+			f.Filesystem = os.DirFS(filepath.Dir(absPath))
 		}
+*/
 		return f
 	})
 }
@@ -77,12 +83,18 @@ The `SerializeContent` the flag allows forcing the content to be serialized in t
 
 */
 type File struct {
-	*Common		`json:",inline" yaml:",inline"`
+	Uri folio.URI `json:"uri,omitempty" yaml:"uri,omitempty"`
+	parsedURI *url.URL `json:"-" yaml:"-"`
 	Filesystem fs.FS `json:"-" yaml:"-"`
 
+	exttype string `json:"-" yaml:"-"`
+	fileext string `json:"-" yaml:"-"`
 	stater machine.Stater `json:"-" yaml:"-"`
+	normalizePath bool `json:"-" yaml:"-"`
+	absPath string `json:"-" yaml:"-"`
 	basePath int `json:"-" yaml:"-"`
 
+	Path   string `json:"path" yaml:"path"`
 	Owner  string `json:"owner" yaml:"owner"`
 	Group  string `json:"group" yaml:"group"`
 	Mode   FileMode `json:"mode" yaml:"mode"`
@@ -97,8 +109,10 @@ type File struct {
 	Size			int64		`json:"size,omitempty" yaml:"size,omitempty"`
 	Target			string		`json:"target,omitempty" yaml:"target,omitempty"`
 	FileType		FileType	`json:"filetype" yaml:"filetype"`
+	State			string		`json:"state,omitempty" yaml:"state,omitempty"`
 	SerializeContent	bool		`json:"serializecontent,omitempty" yaml:"serializecontent,omitempty"`
 	GzipContent		bool		`json:"gzipcontent,omitempty" yaml:"gzipcontent,omitempty"`
+	config			data.ConfigurationValueGetter
 	Resources		data.ResourceMapper `json:"-" yaml:"-"`
 }
 
@@ -109,49 +123,23 @@ type ResourceFileInfo struct {
 func NewFile() *File {
 	currentUser, _ := user.Current()
 	group, _ := user.LookupGroupId(currentUser.Gid)
-	f := &File{
+	f := &File{ normalizePath: false, Owner: currentUser.Username, Group: group.Name, Mode: "0644", FileType: RegularFile, SerializeContent: false }
-		Common: NewCommon(FileTypeName, true),
-		Owner: currentUser.Username,
-		Group: group.Name,
-		Mode: "0644",
-		FileType: RegularFile,
-		SerializeContent: false,
-	}
-	f.PathNormalization(false)
 	slog.Info("NewFile()", "file", f)
 	return f
 }
 
 func NewNormalizedFile() *File {
 	f := NewFile()
-	f.PathNormalization(true)
+	f.normalizePath = true
 	return f
 }
 
-func (f *File) Init(u data.URIParser) error {
-	if u == nil {
-		u = folio.URI(f.URI()).Parse()
-	}
-	return f.SetParsedURI(u)
-}
-
-func (f *File) NormalizePath() error {
-	return f.Common.NormalizePath()
-}
-
 func (f *File) ContentType() string {
-	var ext strings.Builder
 	if f.parsedURI.Scheme != "file" {
 		return f.parsedURI.Scheme
 	}
-	if f.fileext == "" {
 	return f.exttype
 }
-	ext.WriteString(f.exttype)
-	ext.WriteRune('.')
-	ext.WriteString(f.fileext)
-	return ext.String()
-}
 
 func (f *File) SetResourceMapper(resources data.ResourceMapper) {
 	f.Resources = resources
@@ -159,7 +147,13 @@ func (f *File) SetResourceMapper(resources data.ResourceMapper) {
 
 func (f *File) Clone() data.Resource {
 	return &File {
-		Common: f.Common.Clone(),
+		Uri: f.Uri,
+		parsedURI: f.parsedURI,
+		exttype: f.exttype,
+		fileext: f.fileext,
+		normalizePath: f.normalizePath,
+		absPath: f.absPath,
+		Path: f.Path,
 		Owner: f.Owner,
 		Group: f.Group,
 		Mode: f.Mode,
@@ -171,6 +165,7 @@ func (f *File) Clone() data.Resource {
 		Size: f.Size,
 		Target: f.Target,
 		FileType: f.FileType,
+		State: f.State,
 	}
 }
 
@@ -202,11 +197,11 @@ func (f *File) Notify(m *machine.EventMessage) {
 					if triggerErr := f.StateMachine().Trigger("state_read"); triggerErr == nil {
 						return
 					} else {
-					f.Common.State = "absent"
+						f.State = "absent"
 						panic(triggerErr)
 					}
 			} else {
-				f.Common.State = "absent"
+				f.State = "absent"
 				if ! errors.Is(readErr, ErrResourceStateAbsent) {
 					panic(readErr)
 				}
@@ -217,36 +212,25 @@ func (f *File) Notify(m *machine.EventMessage) {
 					return
 				}
 			} else {
-				f.Common.State = "absent"
+				f.State = "absent"
 				panic(e)
 			}
-		case "start_update":
-			if updateErr := f.Update(ctx); updateErr == nil {
-				if triggerErr := f.stater.Trigger("updated"); triggerErr == nil {
-					return
-				} else {
-					f.Common.State = "absent"
-				}
-			} else {
-				f.Common.State = "absent"
-				panic(updateErr)
-			}
 		case "start_delete":
 			if deleteErr := f.Delete(ctx); deleteErr == nil {
 				if triggerErr := f.StateMachine().Trigger("deleted"); triggerErr == nil {
 					return
 				} else {
-					f.Common.State = "present"
+					f.State = "present"
 					panic(triggerErr)
 				}
 			} else {
-				f.Common.State = "present"
+				f.State = "present"
 				panic(deleteErr)
 			}
 		case "absent":
-			f.Common.State = "absent"
+			f.State = "absent"
 		case "present", "created", "read":
-			f.Common.State = "present"
+			f.State = "present"
 		}
 	case machine.EXITSTATEEVENT:
 	}
@@ -256,8 +240,12 @@ func (f *File) SetGzipContent(flag bool) {
 	f.GzipContent = flag
 }
 
+func (f *File) PathNormalization(flag bool) {
+	f.normalizePath = flag
+}
+
 func (f *File) FilePath() string {
-	return f.Common.Path
+	return f.Path
 }
 
 func (f *File) SetFS(fsys fs.FS) {
@@ -265,23 +253,63 @@ func (f *File) SetFS(fsys fs.FS) {
 }
 
 func (f *File) URI() string {
-	return fmt.Sprintf("file://%s", f.Common.Path)
+	return fmt.Sprintf("file://%s", f.Path)
 }
 
 func (f *File) RelativePath() string {
-	return f.Common.Path[f.basePath:]
+	return f.Path[f.basePath:]
 }
 
 func (f *File) SetBasePath(index int) {
-	if index < len(f.Common.Path) {
+	if index < len(f.Path) {
 		f.basePath = index
 	}
 }
 
+func (f *File) SetURI(uri string) (err error) {
+	slog.Info("File.SetURI()", "uri", uri, "file", f, "parsed", f.parsedURI)
+	f.SetURIFromString(uri)
+	err = f.SetParsedURI(f.Uri.Parse())
+	return
+}
+
 func (f *File) DetectGzip() bool {
 	return (f.parsedURI.Query().Get("gzip") == "true" || f.fileext == "gz" || f.exttype == "tgz" || f.exttype == "gz" || f.fileext == "tgz" ) 
 }
 
+func (f *File) SetURIFromString(uri string) {
+	f.Uri = folio.URI(uri)
+	f.exttype, f.fileext = f.Uri.Extension()
+}
+
+func (f *File) SetParsedURI(u *url.URL) (err error) {
+	if u != nil {
+		if u.Scheme == "" {
+			u.Scheme = "file"
+			f.Uri = ""
+		}
+		if f.Uri.IsEmpty()  {
+			f.SetURIFromString(u.String())
+		}
+		slog.Info("File.SetParsedURI()", "parsed", u, "path", f.Path)
+		f.parsedURI = u
+		if f.parsedURI.Scheme == "file" {
+			f.Path = filepath.Join(f.parsedURI.Hostname(), f.parsedURI.Path)
+			slog.Info("File.SetParsedURI()", "path", f.Path)
+			if err = f.NormalizePath(); err != nil {
+				return
+			}
+			return
+		}
+	}
+	err = fmt.Errorf("%w: %s is not a file", ErrInvalidResourceURI, f.Uri)
+	return
+}
+
+func (f *File) UseConfig(config data.ConfigurationValueGetter) {
+	f.config = config
+}
+
 func (f *File) JSON() ([]byte, error) {
 	return json.Marshal(f)
 }
@@ -297,7 +325,7 @@ func (f *File) Validate() (err error) {
 
 func (f *File) Apply() error {
 	ctx := context.Background()
-	switch f.Common.State {
+	switch f.State {
 	case "absent":
 		return f.Delete(ctx)
 	case "present":
@@ -339,10 +367,9 @@ func (f *File) ResolveId(ctx context.Context) string {
 	if e := f.NormalizePath(); e != nil {
 		panic(e)
 	}
-	return f.Common.Path
+	return f.Path
 }
 
-/*
 func (f *File) NormalizePath() (err error) {
 	if f.config != nil {
 		if prefixPath, configErr := f.config.GetValue("prefix"); configErr == nil {
@@ -354,7 +381,6 @@ func (f *File) NormalizePath() (err error) {
 	}
 	return
 }
-*/
 
 func (f *File) GetContentSourceRef() string {
 	return string(f.ContentSourceRef)
@@ -367,7 +393,7 @@ func (f *File) SetContentSourceRef(uri string) {
 
 func (f *File) Stat() (info fs.FileInfo, err error) {
 	if _, ok := f.Filesystem.(embed.FS); ok {
-		info, err = fs.Stat(f.Filesystem, f.Common.Path)
+		info, err = fs.Stat(f.Filesystem, f.Path)
 	} else {
 		info, err = os.Lstat(f.absPath)
 	}
@@ -427,12 +453,12 @@ func (f *File) Create(ctx context.Context) error {
 
 	switch f.FileType {
 	case SymbolicLinkFile:
-		linkErr := os.Symlink(f.Target, f.Common.Path)
+		linkErr := os.Symlink(f.Target, f.Path)
 		if linkErr != nil {
 			return linkErr
 		}
 	case DirectoryFile:
-		if mkdirErr := os.MkdirAll(f.Common.Path, mode); mkdirErr != nil {
+		if mkdirErr := os.MkdirAll(f.Path, mode); mkdirErr != nil {
 			return mkdirErr
 		}
 	default:
@@ -460,8 +486,7 @@ func (f *File) Create(ctx context.Context) error {
 		})
 
 		var createdFileWriter io.WriteCloser
-		createdFile, fileErr := os.Create(f.Common.Path)
+		createdFile, fileErr := os.Create(f.Path)
-		slog.Info("File.Create(): os.Create()", "path", f.Common.Path, "error", fileErr)
 		if fileErr != nil {
 			return fileErr
 		}
@@ -475,7 +500,6 @@ func (f *File) Create(ctx context.Context) error {
 
 		defer createdFile.Close()
 
-		slog.Info("File.Create(): Chmod()", "path", f.Common.Path, "mode", mode)
 		if chmodErr := createdFile.Chmod(mode); chmodErr != nil {
 			return chmodErr
 		}
@@ -487,20 +511,16 @@ func (f *File) Create(ctx context.Context) error {
 
 		f.Sha256 = fmt.Sprintf("%x", hash.Sum(nil))
 		if !f.Mtime.IsZero() && !f.Atime.IsZero() {
-			slog.Info("File.Create(): Chtimes()", "path", f.Common.Path, "atime", f.Atime, "mtime", f.Mtime)
+			if chtimesErr := os.Chtimes(f.Path, f.Atime, f.Mtime); chtimesErr != nil {
-			if chtimesErr := os.Chtimes(f.Common.Path, f.Atime, f.Mtime); chtimesErr != nil {
 				return chtimesErr
 			}
-		} else {
-			slog.Info("File.Create(): Chtimes() SKIPPED", "path", f.Common.Path, "atime", f.Atime, "mtime", f.Mtime)
 		}
 	}
-	slog.Info("File.Create(): Chown()", "path", f.Common.Path, "uid", uid, "gid", gid)
 
-	if chownErr := os.Chown(f.Common.Path, uid, gid); chownErr != nil {
+	if chownErr := os.Chown(f.Path, uid, gid); chownErr != nil {
 		return chownErr
 	}
-	f.Common.State = "present"
+	f.State = "present"
 	return nil
 }
 
@@ -509,7 +529,7 @@ func (f *File) Update(ctx context.Context) error {
 }
 
 func (f *File) Delete(ctx context.Context) error {
-	return os.Remove(f.Common.Path)
+	return os.Remove(f.Path)
 }
 
 func (f *File) UpdateContentAttributes() {
@@ -565,11 +585,11 @@ func (f *File) ContentSourceRefStat() (info fs.FileInfo) {
 
 func (f *File) ReadStat() (err error) {
 	var info fs.FileInfo
-	slog.Info("ReadStat()", "filesystem", f.Filesystem, "path", f.Common.Path)
+	slog.Info("ReadStat()", "filesystem", f.Filesystem, "path", f.Path)
 
 	info, err = f.Stat()
 
-	slog.Info("ReadStat()", "filesystem", f.Filesystem, "path", f.Common.Path, "info", info, "error", err)
+	slog.Info("ReadStat()", "filesystem", f.Filesystem, "path", f.Path, "info", info, "error", err)
 
 	if err == nil {
 		_ = f.SetFileInfo(info)
@@ -583,9 +603,9 @@ func (f *File) ReadStat() (err error) {
 	}
 
 
-	slog.Info("ReadStat()", "stat", info, "path", f.Common.Path)
+	slog.Info("ReadStat()", "stat", info, "path", f.Path)
 	if err != nil {
-		f.Common.State = "absent"
+		f.State = "absent"
 		return
 	}
 
@@ -593,29 +613,27 @@ func (f *File) ReadStat() (err error) {
 }
 
 func (f *File) open() (file io.ReadCloser, err error) {
-	slog.Info("open()", "file", f.Common.Path, "fs", f.Filesystem)
+	slog.Info("open()", "file", f.Path, "fs", f.Filesystem)
 	if _, ok := f.Filesystem.(embed.FS); ok {
-		file, err = f.Filesystem.Open(f.Common.Path)
+		file, err = f.Filesystem.Open(f.Path)
 	} else {
-		file, err = os.Open(f.Common.Path)
+		file, err = os.Open(f.Path)
 	}
 	if f.GzipContent && f.DetectGzip() {
 		file, err = gzip.NewReader(file)
 	}
-	slog.Info("open()", "file", f.Common.Path, "error", err)
+	slog.Info("open()", "file", f.Path, "error", err)
 	return
 }
 
 func (f *File) Read(ctx context.Context) ([]byte, error) {
-	/*
 	if normalizePathErr := f.NormalizePath(); normalizePathErr != nil {
 		return nil, normalizePathErr
 	}
-	*/
 	
 	statErr := f.ReadStat()
 	if statErr != nil {
-		return nil, fmt.Errorf("%w - %w: %s", ErrResourceStateAbsent, statErr, f.Path)
+		return nil, fmt.Errorf("%w - %w", ErrResourceStateAbsent, statErr)
 	}
 
 	switch f.FileType {
@@ -635,13 +653,13 @@ func (f *File) Read(ctx context.Context) ([]byte, error) {
 			f.Sha256 = fmt.Sprintf("%x", sha256.Sum256(fileContent))
 		}
 	case SymbolicLinkFile:
-		linkTarget, pathErr := os.Readlink(f.Common.Path)
+		linkTarget, pathErr := os.Readlink(f.Path)
 		if pathErr != nil {
 			return nil, pathErr
 		}
 		f.Target = linkTarget
 	}
-	f.Common.State = "present"
+	f.State = "present"
 	return yaml.Marshal(f)
 }
 

internal/resource/file_test.go

@@ -23,7 +23,6 @@ _	"net/url"
 	"io/fs"
 	"decl/internal/codec"
 	"decl/internal/data"
-	"decl/internal/folio"
 	"log/slog"
 )
 
@@ -38,8 +37,7 @@ func TestNewFileNormalized(t *testing.T) {
 
 	f := NewNormalizedFile()
 	assert.NotNil(t, f)
-	f.Path = indirectFile
+	assert.Nil(t, f.SetURI("file://" + indirectFile))
-	assert.Nil(t, f.Init(nil))
 
 	assert.NotEqual(t, indirectFile, f.Path)
 	assert.Equal(t, absFilePath, f.Path)
@@ -86,21 +84,13 @@ func TestReadFile(t *testing.T) {
 	testFile := NewFile()
 	e := testFile.LoadDecl(decl)
 	assert.Nil(t, e)
-
-	assert.Equal(t, "present", testFile.Common.State)
-	assert.Equal(t, file, testFile.Common.Path)
-
 	applyErr := testFile.Apply()
 	assert.Nil(t, applyErr)
 
-	assert.FileExists(t, file)
-
 	f := NewFile()
-	assert.NotNil(t, f)
+	assert.NotEqual(t, nil, f)
 
 	f.Path = file
-	assert.Nil(t, f.Init(nil))
-
 	r, e := f.Read(ctx)
 	assert.Nil(t, e)
 	assert.Equal(t, ProcessTestUserName, f.Owner)
@@ -128,8 +118,7 @@ func TestUseConfig(t *testing.T) {
 		return nil, data.ErrUnknownConfigurationKey
 	}))
 
-	uri := folio.URI(fmt.Sprintf("file://%s", file))
+	assert.Nil(t, f.SetURI(fmt.Sprintf("file://%s", file)))
-	assert.Nil(t, f.Init(uri.Parse()))
 	assert.Equal(t, filepath.Join("/tmp", file), f.FilePath())
 }
 
@@ -274,8 +263,8 @@ func TestFileSetURI(t *testing.T) {
 	file, _ := filepath.Abs(TempDir.FilePath("testuri.txt"))
 	f := NewFile()
 	assert.NotNil(t, f)
-	uri := folio.URI("file://" + file).Parse()
+	e := f.SetURI("file://" + file)
-	assert.Nil(t, f.Init(uri))
+	assert.Nil(t, e)
 	assert.Equal(t, "file", f.Type())
 	assert.Equal(t, file, f.Path)
 }
@@ -313,7 +302,6 @@ func TestFileUpdateAttributesFromFileInfo(t *testing.T) {
 
 func TestFileReadStat(t *testing.T) {
 	ctx := context.Background()
-
 	link := TempDir.FilePath("link.txt")
 	linkTargetFile := TempDir.FilePath("testuri.txt")
 
@@ -321,8 +309,8 @@ func TestFileReadStat(t *testing.T) {
 	assert.NotNil(t, f)
 
 	f.Path = linkTargetFile
-	f.PathNormalization(true)
+	e := f.NormalizePath()
-	assert.Nil(t, f.Init(nil))
+	assert.Nil(t, e)
 
 	statErr := f.ReadStat()
 	assert.Error(t, statErr)
@@ -336,9 +324,8 @@ func TestFileReadStat(t *testing.T) {
 
 	l := NewFile()
 	assert.NotNil(t, l)
-	l.PathNormalization(true)
-	assert.Nil(t, l.Init(nil))
 
+	assert.Nil(t, l.NormalizePath())
 	l.FileType = SymbolicLinkFile
 	l.Path = link
 	l.Target = linkTargetFile
@@ -353,9 +340,6 @@ func TestFileReadStat(t *testing.T) {
 
 	testRead := NewFile()
 	testRead.Path = link
-
-	assert.Nil(t, testRead.Init(nil))
-
 	_,testReadErr := testRead.Read(ctx)
 	assert.Nil(t, testReadErr)
 	assert.Equal(t, linkTargetFile, testRead.Target)
@@ -371,8 +355,6 @@ func TestFileResourceFileInfo(t *testing.T) {
 	f.Mode = "0600"
 	f.Content = "some test data"
 	f.State = "present"
-	assert.Nil(t, f.Init(nil))
-	
 	assert.Nil(t, f.Apply())
 
 	_, readErr := f.Read(context.Background())
@@ -396,45 +378,20 @@ func TestFileClone(t *testing.T) {
 	assert.NotNil(t, f)
 
 	f.Path = testFile
-	assert.Nil(t, f.Init(nil))
 	f.Mode = "0600"
 	f.State = "present"
 	assert.Nil(t, f.Apply())
 	
-	origin := time.Now()
-
 	_,readErr := f.Read(ctx)
 	assert.Nil(t, readErr)
 
 	time.Sleep(100 * time.Millisecond)
-	assert.Greater(t, origin, f.Mtime)
 
 	clone := f.Clone().(*File)
-	assert.Equal(t, f.Common.Path, clone.Common.Path)
+	assert.Equal(t, f, clone)
-	assert.Equal(t, f.Common.absPath, clone.Common.absPath)
+	clone.Mtime = time.Time{}
-	assert.Equal(t, f.Common.parsedURI, clone.Common.parsedURI)
-	assert.Equal(t, f.Common.exttype, clone.Common.exttype)
-	assert.Equal(t, f.Common.fileext, clone.Common.fileext)
-	assert.Equal(t, f.Common.State, clone.Common.State)
-	assert.Equal(t, f.Size, clone.Size)
-	assert.Equal(t, f.Owner, clone.Owner)
-	assert.Equal(t, f.Group, clone.Group)
-	assert.Equal(t, f.Mode, clone.Mode)
-	assert.Equal(t, f.Atime, clone.Atime)
-	assert.Equal(t, f.Mtime, clone.Mtime)
-	assert.Equal(t, f.Ctime, clone.Ctime)
-	assert.Equal(t, f.Content, clone.Content)
-	assert.Equal(t, f.Sha256, clone.Sha256)
-
-	clone.Mtime = time.Now()
 	clone.Path = testCloneFile
-	assert.Nil(t, clone.Init(nil))
-
-	assert.NotEqual(t, f.absPath, clone.absPath)
-
-	slog.Info("TestFileClone", "clone", clone)
 	assert.Nil(t, clone.Apply())
-	slog.Info("TestFileClone - applied mtime change", "clone", clone)
 
 	_,updateReadErr := f.Read(ctx)
 	assert.Nil(t, updateReadErr)
@@ -442,8 +399,7 @@ func TestFileClone(t *testing.T) {
 	_, cloneReadErr := clone.Read(ctx)
 	assert.Nil(t, cloneReadErr)
 
-	slog.Info("TestFileClone - read mtime change", "orig", f.Mtime, "clone", clone.Mtime)
+	fmt.Printf("file %#v\nclone %#v\n", f, clone) 
-	fmt.Printf("file %#v\n %#v\nclone %#v\n %#v\n", f, f.Common, clone, clone.Common) 
 	assert.NotEqual(t, f.Mtime, clone.Mtime)
 }
 
@@ -456,16 +412,12 @@ func TestFileErrors(t *testing.T) {
 	stater := f.StateMachine()
 
 	f.Path = testFile
-	assert.Nil(t, f.Init(nil))
 	f.Mode = "631"
 	assert.Nil(t, stater.Trigger("create"))
 	
-	assert.FileExists(t, f.Path)
-
 	read := NewFile()
 	readStater := read.StateMachine()
 	read.Path = testFile
-	assert.Nil(t, read.Init(nil))
 	assert.Nil(t, readStater.Trigger("read"))
 	assert.Equal(t, FileMode("0631"), read.Mode)
 
@@ -582,8 +534,7 @@ func TestFilePathURI(t *testing.T) {
 	e := f.LoadDecl(decl)
 	assert.Nil(t, e)
 	assert.Equal(t, "", f.FilePath())
-//	assert.ErrorContains(t, f.Validate(), "path: String length must be greater than or equal to 1")
+	assert.ErrorContains(t, f.Validate(), "path: String length must be greater than or equal to 1")
-	assert.ErrorContains(t, f.Validate(), "path is required")
 }
 
 func TestFileAbsent(t *testing.T) {
@@ -642,8 +593,8 @@ func TestFileSetURIError(t *testing.T) {
 	file := TempDir.FilePath("fooread.txt")
 	f := NewFile()
 	assert.NotNil(t, f)
-	uri := folio.URI("foo://" + file).Parse()
+	e := f.SetURI("foo://" + file)
-	e := f.Init(uri)
+	assert.NotNil(t, e)
 	assert.ErrorIs(t, e, ErrInvalidResourceURI)
 }
 
@@ -651,8 +602,8 @@ func TestFileContentType(t *testing.T) {
 	file := TempDir.FilePath("fooread.txt")
 	f := NewFile()
 	assert.NotNil(t, f)
-	uri := folio.URI("file://" + file).Parse()
+	e := f.SetURI("file://" + file)
-	assert.Nil(t, f.Init(uri))
+	assert.Nil(t, e)
 	assert.Equal(t, "txt", f.ContentType())
 }
 

internal/resource/group.go

@@ -27,9 +27,8 @@ type decodeGroup Group
 type GroupType string
 
 const (
-	GroupTypeName TypeName = "group"
+	GroupTypeAddGroup = "addgroup"
-	GroupTypeAddGroup GroupType = "addgroup"
+	GroupTypeGroupAdd = "groupadd"
-	GroupTypeGroupAdd GroupType = "groupadd"
 )
 
 var ErrUnsupportedGroupType error = errors.New("The GroupType is not supported on this system")
@@ -48,26 +47,28 @@ type Group struct {
 	ReadCommand *command.Command   `json:"-" yaml:"-"`
 	UpdateCommand *command.Command `json:"-" yaml:"-"`
 	DeleteCommand *command.Command `json:"-" yaml:"-"`
+	State string           `json:"state,omitempty" yaml:"state,omitempty"`
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `json:"-" yaml:"-"`
-	groupStatus *user.Group `json:"-" yaml:"-"`
 }
 
-func NewGroup() (g *Group) {
+func NewGroup() *Group {
-	g = &Group{}
+	return &Group{}
-	g.Common = NewCommon(GroupTypeName, true)
-	g.Common.NormalizePath = g.NormalizePath
-	return
 }
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"group"}, func(u *url.URL) (group data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"group"}, func(u *url.URL) data.Resource {
-		group = NewGroup()
+		group := NewGroup()
-		if u != nil {
+		group.Name = u.Hostname()
-			if err := folio.CastParsedURI(u).ConstructResource(group); err != nil {
+		group.GID = LookupGIDString(u.Hostname())
-				panic(err)
+		if _, addGroupPathErr := exec.LookPath("addgroup"); addGroupPathErr == nil {
+			group.GroupType = GroupTypeAddGroup
 		}
+		if _, pathErr := exec.LookPath("groupadd"); pathErr == nil {
+			group.GroupType = GroupTypeGroupAdd
 		}
-		return
+		group.CreateCommand, group.ReadCommand, group.UpdateCommand, group.DeleteCommand = group.GroupType.NewCRUD()
+		return group
 	})
 }
 
@@ -81,36 +82,15 @@ func FindSystemGroupType() GroupType {
 	return GroupTypeAddGroup
 }
 
-func (g *Group) Init(u data.URIParser) error {
-	if u == nil {
-		u = folio.URI(g.URI()).Parse()
-	}
-	uri := u.URL()
-	g.Name = uri.Hostname()
-	g.GID = LookupGIDString(uri.Hostname())
-	if _, addGroupPathErr := exec.LookPath("addgroup"); addGroupPathErr == nil {
-		g.GroupType = GroupTypeAddGroup
-	}
-	if _, pathErr := exec.LookPath("groupadd"); pathErr == nil {
-		g.GroupType = GroupTypeGroupAdd
-	}
-	g.CreateCommand, g.ReadCommand, g.UpdateCommand, g.DeleteCommand = g.GroupType.NewCRUD()
-	return g.SetParsedURI(u)
-}
-
-func (g *Group) NormalizePath() error {
-	return nil
-}
-
 func (g *Group) SetResourceMapper(resources data.ResourceMapper) {
 	g.Resources = resources
 }
 
 func (g *Group) Clone() data.Resource {
 	newg := &Group {
-		Common: g.Common,
 		Name: g.Name,
 		GID: g.GID,
+		State: g.State,
 		GroupType: g.GroupType,
 	}
 	newg.CreateCommand, newg.ReadCommand, newg.UpdateCommand, newg.DeleteCommand = g.GroupType.NewCRUD()
@@ -129,62 +109,40 @@ func (g *Group) Notify(m *machine.EventMessage) {
 	switch m.On {
 	case machine.ENTERSTATEEVENT:
 		switch m.Dest {
-		case "start_stat":
-			if statErr := g.ReadStat(); statErr == nil {
-				if triggerErr := g.StateMachine().Trigger("exists"); triggerErr == nil {
-					return
-				}
-			} else {
-				if triggerErr := g.StateMachine().Trigger("notexists"); triggerErr == nil {
-					return
-				}
-			}
-		case "start_read":
-			if _,readErr := g.Read(ctx); readErr == nil {
-				if triggerErr := g.StateMachine().Trigger("state_read"); triggerErr == nil {
-					return
-				} else {
-					g.Common.State = "absent"
-					panic(triggerErr)
-				}
-			} else {
-				g.Common.State = "absent"
-				panic(readErr)
-			}
 		case "start_create":
 			if e := g.Create(ctx); e == nil {
 				if triggerErr := g.stater.Trigger("created"); triggerErr == nil {
 					return
 				}
 			}
-			g.Common.State = "absent"
+			g.State = "absent"
-
+		case "present":
-
+			g.State = "present"
-		case "start_update":
-			if updateErr := g.Update(ctx); updateErr == nil {
-				if triggerErr := g.stater.Trigger("updated"); triggerErr == nil {
-					return
-				} else {
-					g.Common.State = "absent"
-				}
-			} else {
-				g.Common.State = "absent"
-				panic(updateErr)
-			}
-
-		case "absent":
-			g.Common.State = "absent"
-		case "present", "created", "read":
-			g.Common.State = "present"
 		}
 	case machine.EXITSTATEEVENT:
 	}
 }
 
+func (g *Group) SetURI(uri string) error {
+	resourceUri, e := url.Parse(uri)
+	if e == nil {
+		if resourceUri.Scheme == "group" {
+			g.Name = resourceUri.Hostname()
+		} else {
+			e = fmt.Errorf("%w: %s is not a group", ErrInvalidResourceURI, uri)
+		}
+	}
+	return e
+}
+
 func (g *Group) URI() string {
 	return fmt.Sprintf("group://%s", g.Name)
 }
 
+func (g *Group) UseConfig(config data.ConfigurationValueGetter) {
+	g.config = config
+}
+
 func (g *Group) ResolveId(ctx context.Context) string {
 	return LookupUIDString(g.Name)
 }
@@ -195,7 +153,7 @@ func (g *Group) Validate() error {
 
 func (g *Group) Apply() error {
 	ctx := context.Background()
-	switch g.Common.State {
+	switch g.State {
 	case "present":
 		_, NoGroupExists := LookupGID(g.Name)
 		if NoGroupExists != nil {
@@ -240,26 +198,10 @@ func (g *Group) Create(ctx context.Context) (error) {
 	return e
 }
 
-func (g *Group) ReadStat() (err error) {
-	if g.groupStatus == nil {
-		if g.groupStatus, err = user.LookupGroup(g.Name); err != nil {
-			g.Common.State = "absent"
-			return err
-		}
-	}
-	if len(g.groupStatus.Gid) < 1 {
-		g.Common.State = "absent"
-		return ErrResourceStateAbsent
-	}
-	g.GID = g.groupStatus.Gid
-	return
-}
-
-
 func (g *Group) Read(ctx context.Context) ([]byte, error) {
 	exErr := g.ReadCommand.Extractor(nil, g)
 	if exErr != nil {
-		g.Common.State = "absent"
+		g.State = "absent"
 	}
 	if yaml, yamlErr := yaml.Marshal(g); yamlErr != nil {
 		return yaml, yamlErr
@@ -268,9 +210,8 @@ func (g *Group) Read(ctx context.Context) ([]byte, error) {
 	}
 }
 
-func (g *Group) Update(ctx context.Context) (err error) {
+func (g *Group) Update(ctx context.Context) (error) {
-	_, err = g.UpdateCommand.Execute(g)
+	return g.Create(ctx)
-	return
 }
 
 func (g *Group) Delete(ctx context.Context) (error) {
@@ -404,7 +345,7 @@ func NewGroupReadCommand() *command.Command {
 	c := command.NewCommand()
 	c.Extractor = func(out []byte, target any) error {
 		g := target.(*Group)
-		g.Common.State = "absent"
+		g.State = "absent"
 		var readGroup *user.Group
 		var e error
 		if g.Name != "" {
@@ -419,7 +360,7 @@ func NewGroupReadCommand() *command.Command {
 			g.Name = readGroup.Name
 			g.GID = readGroup.Gid
 			if g.GID != "" {
-				g.Common.State = "present"
+				g.State = "present"
 			}
 		}
 		return e
@@ -428,18 +369,8 @@ func NewGroupReadCommand() *command.Command {
 }
 
 func NewGroupUpdateCommand() *command.Command {
-	c := command.NewCommand()
-	c.Path = "addgroup"
-	c.FailOnError = false
-	c.Args = []command.CommandArg{
-		command.CommandArg("{{ if .GID }}-g {{ .GID }}{{ end }}"),
-		command.CommandArg("{{ .Name }}"),
-	}
-	c.Extractor = func(out []byte, target any) error {
 	return nil
 }
-	return c
-}
 
 func NewGroupDelDeleteCommand() *command.Command {
 	c := command.NewCommand()
@@ -485,7 +416,7 @@ func NewReadGroupsCommand() *command.Command {
 			g := (*Groups)[lineIndex]
 			g.Name = groupRecord[0]
 			g.GID = groupRecord[2]
-			g.Common.State = "present"
+			g.State = "present"
 			g.GroupType = SystemGroupType
 			lineIndex++
 		}

internal/resource/http.go

@@ -60,11 +60,16 @@ func init() {
 }
 
 func HTTPFactory(u *url.URL) data.Resource {
+	var err error
 	h := NewHTTP()
-	if u != nil {
+
-		if err := folio.CastParsedURI(u).ConstructResource(h); err != nil {
+	slog.Info("HTTP.Factory", "http", h, "url", u)
+	if err = h.SetParsedURI(u); err != nil {
 		panic(err)
 	}
+
+	if err = h.Open(); err != nil {
+		panic(err)
 	}
 	return h
 }
@@ -97,34 +102,15 @@ type HTTP struct {
 }
 
 func NewHTTP() *HTTP {
-	h := &HTTP{ client: &http.Client{} }
+	h := &HTTP{ client: &http.Client{}, Common: &Common{ includeQueryParamsInURI: true, resourceType: HTTPTypeName, SchemeCheck: func(scheme string) bool {
-	h.Common = NewCommon(HTTPTypeName, true)
-	h.Common.SchemeCheck = h.SchemeCheck
-	h.Common.NormalizePath = h.NormalizePath
-	slog.Info("NewHTTP()", "http", h)
-	return h
-}
-
-func (h *HTTP) SchemeCheck(scheme string) bool {
 		switch scheme {
 		case "http", "https":
 			return true
 		}
 		return false
-}
+	} } }
-
+	slog.Info("NewHTTP()", "http", h)
-func (h *HTTP) Init(u data.URIParser) (err error) {
+	return h
-	if u == nil {
-		u = folio.URI(h.URI()).Parse()
-	}
-	if err = h.SetParsedURI(u); err == nil {
-		err = h.Open()
-	}
-	return
-}
-
-func (h *HTTP) NormalizePath() error {
-	return nil
 }
 
 func (h *HTTP) SetResourceMapper(resources data.ResourceMapper) {
@@ -233,9 +219,16 @@ func (h *HTTP) URI() string {
 	return h.Endpoint.String()
 }
 
-func (h *HTTP) SetParsedURI(u data.URIParser) (err error) {
+func (h *HTTP) SetURI(uri string) (err error) {
+	if err = h.Common.SetURI(uri); err == nil {
+		h.Endpoint = h.Common.Uri
+	}
+	return
+}
+
+func (h *HTTP) SetParsedURI(u *url.URL) (err error) {
 	if err = h.Common.SetParsedURI(u); err == nil {
-		h.Endpoint = h.Common.URI()
+		h.Endpoint = h.Common.Uri
 	}
 	return
 }
@@ -273,13 +266,11 @@ func (h *HTTP) ContentSourceRefStat() (info fs.FileInfo) {
 }
 
 func (h *HTTP) ReadStat() (err error) {
-
 	if h.reader == nil {
 		if err = h.OpenGetter(); err != nil {
 			return
 		}
 	}
-
 	var info fs.FileInfo
 	info, err = h.reader.Stat()
 
@@ -341,14 +332,14 @@ func (h *HTTP) Apply() error {
 
 func (h *HTTP) Load(docData []byte, f codec.Format) (err error) {
 	if err = f.StringDecoder(string(docData)).Decode(h); err == nil {
-		err = h.Common.SetParsedURI(folio.URI(h.Endpoint).Parse())
+		err = h.Common.SetURI(string(h.Endpoint))
 	}
 	return
 }
 
 func (h *HTTP) LoadReader(r io.ReadCloser, f codec.Format) (err error) {
 	if err = f.Decoder(r).Decode(h); err == nil {
-		err = h.Common.SetParsedURI(folio.URI(h.Endpoint).Parse())
+		err = h.Common.SetURI(string(h.Endpoint))
 		//err = h.setParsedURI(h.Endpoint)
 	}
 	return
@@ -356,7 +347,7 @@ func (h *HTTP) LoadReader(r io.ReadCloser, f codec.Format) (err error) {
 
 func (h *HTTP) LoadString(docData string, f codec.Format) (err error) {
 	if err = f.StringDecoder(docData).Decode(h); err == nil {
-		err = h.Common.SetParsedURI(folio.URI(h.Endpoint).Parse())
+		err = h.Common.SetURI(string(h.Endpoint))
 		//err = h.setParsedURI(h.Endpoint)
 	}
 	return
@@ -367,7 +358,7 @@ func (h *HTTP) LoadDecl(yamlResourceDeclaration string) error {
 }
 
 func (h *HTTP) ResolveId(ctx context.Context) string {
-	_ = h.Common.SetParsedURI(folio.URI(h.Endpoint).Parse())
+	_ = h.Common.SetURI(h.Endpoint.String())
 	slog.Info("HTTP.ResolveId()", "uri", h.Endpoint.String())
 	return h.Endpoint.String()
 }

internal/resource/iptables.go

@@ -30,11 +30,20 @@ const (
 func init() {
 	folio.DocumentRegistry.ResourceTypes.Register([]string{"iptable"}, func(u *url.URL) data.Resource {
 		i := NewIptable()
-		if u != nil {
+		i.Table = IptableName(u.Hostname())
-			if err := folio.CastParsedURI(u).ConstructResource(i); err != nil {
+		if len(u.Path) > 0 {
-				panic(err)
+			fields := strings.FieldsFunc(u.Path, func(c rune) bool { return c == '/' })
+			slog.Info("iptables factory", "iptable", i, "uri", u, "fields", fields, "number_fields", len(fields))
+			if len(fields) > 0 {
+				i.Chain = IptableChain(fields[0])
+				if len(fields) < 3 {
+					i.ResourceType = IptableTypeChain
+				} else {
+					i.ResourceType = IptableTypeRule
+					id, _ := strconv.ParseUint(fields[1], 10, 32)
+					i.Id = uint(id)
+				}
 			}
-
 			i.CreateCommand, i.ReadCommand, i.UpdateCommand, i.DeleteCommand = i.ResourceType.NewCRUD()
 		}
 		return i
@@ -92,8 +101,6 @@ type ExtensionFlag struct {
 	Value string `json:"value" yaml:"value"`
 }
 
-type TargetFlag ExtensionFlag
-
 type IptablePort uint16
 
 type IptableType string
@@ -103,8 +110,6 @@ const (
 	IptableTypeChain = "chain"
 )
 
-type IptableRule string
-
 var (
 	ErrInvalidIptableName error = errors.New("The IptableName is not a valid table")
 )
@@ -114,6 +119,7 @@ var (
 type Iptable struct {
 	*Common                       `json:",inline" yaml:",inline"`
 	stater				machine.Stater	`json:"-" yaml:"-"`
+	parsedURI			*url.URL				`json:"-" yaml:"-"`
 	Id						uint						`json:"id,omitempty" yaml:"id,omitempty"`
 	Table					IptableName			`json:"table" yaml:"table"`
 	Chain					IptableChain		`json:"chain" yaml:"chain"`
@@ -127,16 +133,15 @@ type Iptable struct {
 	Flags					[]ExtensionFlag	`json:"extension_flags,omitempty" yaml:"extension_flags,omitempty"`
 	Proto					IptableProto		`json:"proto,omitempty" yaml:"proto,omitempty"`
 	Jump					string					`json:"jump,omitempty" yaml:"jump,omitempty"`
-	TargetFlags		[]TargetFlag		`json:"target_flags,omitempty" yaml:"target_flags,omitempty"`
 	ChainLength		uint						`json:"-" yaml:"-"`
 
 	ResourceType	IptableType `json:"resourcetype,omitempty" yaml:"resourcetype,omitempty"`
   CreateCommand *command.Command `yaml:"-" json:"-"`
   ReadCommand   *command.Command `yaml:"-" json:"-"`
-	ReadChainCommand	*command.Command	`yaml:"-" json:"-"`
   UpdateCommand *command.Command `yaml:"-" json:"-"`
   DeleteCommand *command.Command `yaml:"-" json:"-"`
 
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `yaml:"-" json:"-"`
 }
 
@@ -150,39 +155,10 @@ func (n IptableName) Validate() error {
 	}
 }
 
-func NewIptable() (i *Iptable) {
+func NewIptable() *Iptable {
-	i = &Iptable{ ResourceType: IptableTypeRule }
+	i := &Iptable{ ResourceType: IptableTypeRule, Common: &Common{ resourceType: IptableTypeName } }
- 	i.Common = NewCommon(IptableTypeName, false)
-	i.Common.NormalizePath = i.NormalizePath
 	i.CreateCommand, i.ReadCommand, i.UpdateCommand, i.DeleteCommand = i.ResourceType.NewCRUD()
-	i.ReadChainCommand = NewIptableChainReadCommand()
+	return i
-	return
-}
-
-func (i *Iptable) Init(u data.URIParser) (err error) {
-	if u == nil {
-		u = folio.URI(i.URI()).Parse()
-	}
-	uri := u.URL()
-	err = i.SetParsedURI(u)
-
-	i.Table = IptableName(uri.Hostname())
-	if len(uri.Path) > 0 {
-		fields := strings.FieldsFunc(uri.Path, func(c rune) bool { return c == '/' })
-		slog.Info("iptables factory", "iptable", i, "uri", uri, "fields", fields, "number_fields", len(fields))
-		if len(fields) > 0 {
-			i.Chain = IptableChain(fields[0])
-			if len(fields) < 3 {
-				i.ResourceType = IptableTypeChain
-			} else {
-				i.ResourceType = IptableTypeRule
-				id, _ := strconv.ParseUint(fields[1], 10, 32)
-				i.SetId(uint(id))
-			}
-		}
-		i.CreateCommand, i.ReadCommand, i.UpdateCommand, i.DeleteCommand = i.ResourceType.NewCRUD()
-	}
-	return
 }
 
 func (i *Iptable) SetResourceMapper(resources data.ResourceMapper) {
@@ -219,109 +195,36 @@ func (i *Iptable) Notify(m *machine.EventMessage) {
 	switch m.On {
 	case machine.ENTERSTATEEVENT:
 		switch m.Dest {
-		case "start_stat":
-			if statErr := i.ReadStat(ctx); statErr == nil {
-				if triggerErr := i.StateMachine().Trigger("exists"); triggerErr == nil {
-					return
-				}
-			} else {
-				if triggerErr := i.StateMachine().Trigger("notexists"); triggerErr == nil {
-					return
-				}
-			}
-		case "start_read":
-			if _,readErr := i.Read(ctx); readErr == nil {
-				if triggerErr := i.stater.Trigger("state_read"); triggerErr == nil {
-					return
-				} else {
-					i.Common.State = "absent"
-					panic(triggerErr)
-				}
-			} else {
-				i.Common.State = "absent"
-				panic(readErr)
-			}
 		case "start_create":
-			if createErr := i.Create(ctx); createErr == nil {
+			if e := i.Create(ctx); e == nil {
 				if triggerErr := i.stater.Trigger("created"); triggerErr == nil {
-					slog.Info("ContainerImage.Notify()", "created", i, "error", triggerErr)
-					return
-				} else {
-					slog.Info("ContainerImage.Notify()", "created", i, "error", triggerErr)
-					i.Common.State = "absent"
-					panic(triggerErr)
-				}
-			} else {
-				i.Common.State = "absent"
-				panic(createErr)
-			}
-		case "start_update":
-			if createErr := i.Update(ctx); createErr == nil {
-				if triggerErr := i.stater.Trigger("updated"); triggerErr == nil {
-					return
-				} else {
-					i.Common.State = "absent"
-				}
-			} else {
-				i.Common.State = "absent"
-				panic(createErr)
-			}
-		case "start_delete":
-			if deleteErr := i.Delete(ctx); deleteErr == nil {
-				if triggerErr := i.stater.Trigger("deleted"); triggerErr == nil {
 					return
 				}
-			} else {
-				panic(deleteErr)
 			}
-		case "present", "created", "read":
+			i.Common.State = "absent"
+		case "present":
 			i.Common.State = "present"
-		case "absent":
-			i.Common.State = "absent"
 		}
 	case machine.EXITSTATEEVENT:
 	}
 }
 
-// Set the chain ID and update the mapped URI
-func (i *Iptable) SetId(id uint) {
-	if i.Id != id {
-		uri := i.URI()
-		i.Id = id
-		decl, ok := i.Resources.Get(uri)
-		if ok {
-			i.Resources.Delete(uri)
-		}
-		i.Resources.Set(i.URI(), decl)
-	}
-}
-
 func (i *Iptable) URI() string {
 	return fmt.Sprintf("iptable://%s/%s/%d", i.Table, i.Chain, i.Id)
 }
 
-
+func (i *Iptable) SetURI(uri string) (err error) {
-func (i *Iptable) SetParsedURI(uri data.URIParser) (err error) {
+	i.parsedURI, err = url.Parse(uri)
-	if err = i.Common.SetParsedURI(uri); err == nil {
+	if err == nil {
-		err = i.setFieldsFromPath()
+		fields := strings.FieldsFunc(i.parsedURI.Path, func(c rune) bool { return c == '/' })
-	}
-	return
-}
-
-func (i *Iptable) NormalizePath() error {
-	return nil
-}
-
-func (i *Iptable) setFieldsFromPath() (err error) {
-	fields := strings.FieldsFunc(i.Common.Path, func(c rune) bool { return c == '/' })
 		fieldsLen := len(fields)
-	if fieldsLen > 0 {
+		if i.parsedURI.Scheme == "iptable" && fieldsLen > 0 {
-		i.Table = IptableName(fields[0])
+			i.Table = IptableName(i.parsedURI.Hostname())
 			if err = i.Table.Validate(); err != nil {
 				return err
 			}
-		i.Chain = IptableChain(fields[1])
+			i.Chain = IptableChain(fields[0])
-		if fieldsLen < 3 {
+			if fieldsLen < 2 {
 				i.ResourceType = IptableTypeChain
 			} else {
 				i.ResourceType = IptableTypeRule
@@ -329,11 +232,16 @@ func (i *Iptable) setFieldsFromPath() (err error) {
 				i.Id = uint(id)
 			}
 		} else {
-		err = fmt.Errorf("%w: %s is not an iptable rule", ErrInvalidResourceURI, i.Common.URI())
+			err = fmt.Errorf("%w: %s is not an iptable rule", ErrInvalidResourceURI, uri)
+		}
 	}
 	return
 }
 
+func (i *Iptable) UseConfig(config data.ConfigurationValueGetter) {
+	i.config = config
+}
+
 func (i *Iptable) Validate() error {
 	s := NewSchema(i.Type())
 	jsonDoc, jsonErr := i.JSON()
@@ -408,46 +316,6 @@ func (i *Iptable) ResolveId(ctx context.Context) string {
 	return fmt.Sprintf("%d", i.Id)
 }
 
-func (f *ExtensionFlag) Match(name string, value string) bool {
-	start := 0
-	if name[1] == '-' {
-		start = 2
-	} else if name[0] == '-' {
-		start = 1
-	}
-	return f.Name == name[start:] && f.Value == value
-}
-
-func (i *Iptable) HasExtensionFlag(name string) bool {
-	optName := strings.Trim(name, "-")
-	for _, ext := range i.Flags {
-		if ext.Name == optName {
-			return true
-		}
-	}
-	return false
-}
-
-func (i *Iptable) HasTargetFlag(name string) bool {
-	optName := strings.Trim(name, "-")
-	for _, ext := range i.TargetFlags {
-		if ext.Name == optName {
-			return true
-		}
-	}
-	return false
-}
-
-func (f *TargetFlag) Match(name string, value string) bool {
-	start := 0
-	if name[1] == '-' {
-		start = 2
-	} else if name[0] == '-' {
-		start = 1
-	}
-	return f.Name == name[start:] && f.Value == value
-}
-
 func (i *Iptable) SetFlagValue(opt, value string) bool {
 	switch opt {
 	case "-i":
@@ -486,11 +354,7 @@ func (i *Iptable) SetFlagValue(opt, value string) bool {
 		return true
 	default:
     if opt[0] == '-' {
-			if len(i.Jump) > 0 {
-				i.TargetFlags = append(i.TargetFlags, TargetFlag{ Name: strings.Trim(opt, "-"), Value: strings.TrimSpace(value)})
-			} else {
       i.Flags = append(i.Flags, ExtensionFlag{ Name: strings.Trim(opt, "-"), Value: strings.TrimSpace(value)})
-			}
 			return true
     }
 	}
@@ -519,14 +383,8 @@ func (i *Iptable) GetFlagValue(opt string) any {
 		return strconv.Itoa(int(i.Sport))
 	default:
     if opt[0] == '-' {
-			slog.Info("Iptable.GetFlagValue()", "opt", opt, "iptable", i)
-			if i.HasExtensionFlag(opt) {
       return i.Flags
     }
-			if i.HasTargetFlag(opt) {
-				return i.TargetFlags
-			}
-		}
 	}
 	return nil
 }
@@ -549,11 +407,9 @@ func (i *Iptable) SetRule(flags []string) (assigned bool) {
 
 func (i *Iptable) MatchRule(flags []string) (match bool) {
 	match = true
-	next:
 	for index, flag := range flags {
 		if flag[0] == '-' {
 			value := flags[index + 1]
-			slog.Info("Iptable.MatchRule()", "flag", flag, "value", value)
 			switch v := i.GetFlagValue(flag).(type) {
 			case []string:
 				for _,element := range v {
@@ -561,57 +417,48 @@ func (i *Iptable) MatchRule(flags []string) (match bool) {
 						continue
 					}
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			case []ExtensionFlag:
 				for _,element := range v {
-					if element.Match(flag, value) {
+					if element.Name == flag && element.Value == value {
-						continue next
+						continue
 					}
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
-				match = false
-			case []TargetFlag:
-				for _,element := range v {
-					if element.Match(flag, value) {
-						continue next
-					}
-				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			case IptableCIDR:
 				if v == IptableCIDR(value) {
 					continue
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			case IptableName:
 				if v == IptableName(value) {
 					continue
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			case IptableChain:
 				if v == IptableChain(value) {
 					continue
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			default:
 				if v.(string) == value {
 					continue
 				}
-				slog.Info("Iptable.MatchRule() - FAILED", "flag", flag, "value", v)
 				match = false
 			}
 		}
 	}
-	slog.Info("Iptable.MatchRule()", "flags", flags, "match", match)
 	return
 }
 
 func (i *Iptable) ReadChainLength() error {
-	output,err := i.ReadChainCommand.Execute(i)
+	c := command.NewCommand()
+	c.Path = "iptables"
+	c.Args = []command.CommandArg{
+		command.CommandArg("-S"),
+		command.CommandArg("{{ .Chain }}"),
+	}
+	output,err := c.Execute(i)
 	if err == nil {
 		linesCount := strings.Count(string(output), "\n")
 		if linesCount > 0 {
@@ -623,16 +470,13 @@ func (i *Iptable) ReadChainLength() error {
 	return err
 }
 
-func (i *Iptable) Create(ctx context.Context) (err error) {
+func (i *Iptable) Create(ctx context.Context) error {
-	slog.Info("Iptable.Create()", "iptable", i)
 	if i.Id > 0 {
 		if lenErr := i.ReadChainLength(); lenErr != nil {
 			return lenErr
 		}
 	}
-
+	_, err := i.CreateCommand.Execute(i)
-	_, err = i.CreateCommand.Execute(i)
-	slog.Info("Iptable.Create()", "err", err, "iptable", i, "createcommand", i.CreateCommand)
 	//slog.Info("IptableChain Create()", "err", err, "errstr", err.Error(), "iptable", i, "createcommand", i.CreateCommand)
 	// TODO add Command status/error handler rather than using the read extractor
 	if i.CreateCommand.Extractor != nil {
@@ -640,20 +484,7 @@ func (i *Iptable) Create(ctx context.Context) (err error) {
 			return i.CreateCommand.Extractor([]byte(err.Error()), i)
 		}
 	}
-	return err
+	return nil
-}
-
-func (i *Iptable) ReadStat(ctx context.Context) (err error) {
-	if i.ReadCommand.Exists() {
-		var out []byte
-		if out, err = i.ReadCommand.Execute(i); err == nil {
-			err = i.ReadCommand.Extractor(out, i)
-		}
-	}
-	if i.Id == 0 {
-		return ErrResourceStateAbsent
-	}
-	return err
 }
 
 func (i *Iptable) Read(ctx context.Context) ([]byte, error) {
@@ -672,15 +503,8 @@ func (i *Iptable) Update(ctx context.Context) error {
 	return i.Create(ctx)
 }
 
-func (i *Iptable) Delete(ctx context.Context) (err error) {
+func (i *Iptable) Delete(ctx context.Context) error {
-	if i.Id < 1 {
+	return nil
-		return fmt.Errorf("Failed to find rule to delete")
-	}
-	var out []byte
-	if out, err = i.DeleteCommand.Execute(i); err == nil {
-		err = i.DeleteCommand.Extractor(out, i)
-	}
-	return
 }
 
 func (i *Iptable) Type() string { return "iptable" }
@@ -728,7 +552,9 @@ func NewIptableCreateCommand() *command.Command {
 	c.Args = []command.CommandArg{
 		command.CommandArg("-t"),
 		command.CommandArg("{{ .Table }}"),
-		command.CommandArg("{{ if and (le .Id .ChainLength) (gt .Id 0) }}-R {{ .Chain }} {{ .Id }}{{ else }}-A {{ .Chain }}{{ end }}"),
+		command.CommandArg("{{ if le .Id .ChainLength }}-R{{ else }}-A{{ end }}"),
+		command.CommandArg("{{ .Chain }}"),
+		command.CommandArg("{{ if le .Id .ChainLength }}{{ .Id }}{{ end }}"),
 		command.CommandArg("{{ if .In }}-i {{ .In }}{{ else if .Out }}-o {{ .Out }}{{ end }}"),
 		command.CommandArg("{{ range .Match }}-m {{ . }} {{- end }}"),
 		command.CommandArg("{{ if .Source }}-s {{ .Source }}{{ end }}"),
@@ -736,9 +562,8 @@ func NewIptableCreateCommand() *command.Command {
 		command.CommandArg("{{ if .Destination }}-d {{ .Destination }}{{ end }}"),
 		command.CommandArg("{{ if .Dport }}--dport {{ .Dport }}{{ end }}"),
 		command.CommandArg("{{ if .Proto }}-p {{ .Proto }}{{ end }}"),
-		command.CommandArg("{{ range .Flags -}} --{{ .Name }} {{ .Value }} {{- end }}"),
+		command.CommandArg("{{ range .Flags }} --{{ .Name }} {{ .Value }} {{ end }}"),
 		command.CommandArg("{{ if .Jump }}-j {{ .Jump }}{{ end }}"),
-		command.CommandArg("{{ range .TargetFlags -}} --{{ .Name }} {{ .Value }}{{- end }}"),
 	}
 	return c
 }
@@ -759,7 +584,7 @@ func IptableExtractRule(lineNumber uint, ruleLine string, target *Iptable) (stat
 			}
 		} else {
 			if target.MatchRule(flags) {
-				target.SetId(lineNumber)
+				target.Id = lineNumber
 				state = "present"
 				err = nil
 			}
@@ -836,7 +661,7 @@ func NewIptableReadChainCommand() *command.Command {
 		}
 		for lineIndex, line := range lines[1:] {
 			i := (*IptableChainRules)[lineIndex]
-			i.SetId(uint(lineIndex + 1))
+			i.Id = uint(lineIndex + 1)
 			ruleFields := strings.Split(strings.TrimSpace(line), " ")
 			if ruleFields[0] == "-A" {
 				flags := ruleFields[2:]
@@ -857,16 +682,7 @@ func NewIptableUpdateCommand() *command.Command {
 }
 
 func NewIptableDeleteCommand() *command.Command {
-	c := command.NewCommand()
+	return nil
-	c.Path = "iptables"
-	c.Args = []command.CommandArg{
-		command.CommandArg("-t"),
-		command.CommandArg("{{ .Table }}"),
-		command.CommandArg("-D"),
-		command.CommandArg("{{ .Chain }}"),
-		command.CommandArg("{{ .Id }}"),
-	}
-	return c
 }
 
 func NewIptableChainCreateCommand() *command.Command {
@@ -950,7 +766,7 @@ func RuleExtractorMatchFlags(out []byte, target any) (err error) {
 					slog.Info("RuleExtractorMatchFlags()", "flags", flags, "ipt", ipt)
 					err = nil
 					ipt.Common.State = "present"
-					ipt.SetId(uint(linesIndex))
+					ipt.Id = uint(linesIndex)
 					return
 				}
 			}
@@ -1022,14 +838,6 @@ func NewIptableChainUpdateCommand() *command.Command {
 }
 
 func NewIptableChainDeleteCommand() *command.Command {
-	c := command.NewCommand()
+	return nil
-	c.Path = "iptables"
-	c.Args = []command.CommandArg{
-		command.CommandArg("-t"),
-		command.CommandArg("{{ .Table }}"),
-		command.CommandArg("-X"),
-		command.CommandArg("{{ .Chain }}"),
-	}
-	return c
 }
 

internal/resource/iptables_test.go

@@ -20,7 +20,6 @@ _ "syscall"
 	"testing"
 _ "time"
 	"decl/internal/command"
-	"decl/internal/data"
 )
 
 func TestNewIptableResource(t *testing.T) {
@@ -78,59 +77,10 @@ func TestReadIptable(t *testing.T) {
 }
 
 func TestCreateIptable(t *testing.T) {
-	ctx := context.Background()
 	testRule := NewIptable()
 	assert.NotNil(t, testRule)
 
-	declarationAttributes := `
-  table: "filter"
-  id: 5
-  chain: "INPUT"
-  source: "192.168.0.0/24"
-  destination: "192.168.0.1"
-  jump: "ACCEPT"
-  state: present
-`
 	
-	m := &MockCommand{
-		Executor: func(value any) ([]byte, error) {
-			return nil, nil
-		},
-		Extractor: func(output []byte, target any) error {
-			testRule.Table = "filter"
-			testRule.Id = 3
-			testRule.Chain = "INPUT"
-			testRule.In = "eth0"
-			testRule.Source = "192.168.0.0/24"
-			testRule.State = "present"
-			return nil
-		},
-	}
-
-	mockReadChain := &MockCommand{
-		Executor: func(value any) ([]byte, error) {
-			return []byte(`
--P INPUT ACCEPT
--A INPUT -j LIBVIRT_INP
-`), nil
-		},
-	}
-
-	e := testRule.LoadDecl(declarationAttributes)
-	assert.Nil(t, e)
-
-	testRule.ReadChainCommand = (*command.Command)(mockReadChain)
-	testRule.ReadCommand = (*command.Command)(m)
-	testRule.CreateCommand = (*command.Command)(m)
-
-	assert.Nil(t, testRule.Create(ctx))
-
-	assert.Equal(t, uint(2), testRule.ChainLength)
-	_, err := testRule.Read(ctx)
-	assert.Nil(t, err)
-
-	//assert.Equal(t, uint(3), testRule.ChainLength)
-	assert.Equal(t, uint(3), testRule.Id)
 }
 
 func TestIptableSetFlagValue(t *testing.T) {
@@ -167,7 +117,6 @@ func TestIptableRuleExtractorById(t *testing.T) {
 
 func TestIptableRuleExtractorByFlags(t *testing.T) {
 	ipt := NewIptable()
-	ipt.Resources = data.NewResourceMapper()
 	assert.NotNil(t, ipt)
 	ipt.Table = IptableName("filter")
 	ipt.Chain = IptableChain("FOO")

internal/resource/network_route.go

@@ -18,7 +18,6 @@ _	"strconv"
 	"decl/internal/codec"
 	"decl/internal/data"
 	"decl/internal/folio"
-	"decl/internal/command"
 )
 
 const (
@@ -26,17 +25,52 @@ const (
 )
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"route"}, func(u *url.URL) (n data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"route"}, func(u *url.URL) data.Resource {
-		n = NewNetworkRoute()
+		n := NewNetworkRoute()
-		if u != nil {
-			if err := folio.CastParsedURI(u).ConstructResource(n); err != nil {
-				panic(err)
-			}
-		}
 		return n
 	})
 }
 
+/*
+
+ROUTE := NODE_SPEC [ INFO_SPEC ]
+NODE_SPEC := [ TYPE ] PREFIX [ tos TOS ]
+             [ table TABLE_ID ] [ proto RTPROTO ]
+             [ scope SCOPE ] [ metric METRIC ]
+             [ ttl-propagate { enabled | disabled } ]
+INFO_SPEC := { NH | nhid ID } OPTIONS FLAGS [ nexthop NH ]...
+
+NH := [ encap ENCAPTYPE ENCAPHDR ] [ via [ FAMILY ] ADDRESS ]
+      [ dev STRING ] [ weight NUMBER ] NHFLAGS
+FAMILY := [ inet | inet6 | mpls | bridge | link ]
+OPTIONS := FLAGS [ mtu NUMBER ] [ advmss NUMBER ] [ as [ to ] ADDRESS ]
+           [ rtt TIME ] [ rttvar TIME ] [ reordering NUMBER ]
+           [ window NUMBER ] [ cwnd NUMBER ] [ initcwnd NUMBER ]
+           [ ssthresh NUMBER ] [ realms REALM ] [ src ADDRESS ]
+           [ rto_min TIME ] [ hoplimit NUMBER ] [ initrwnd NUMBER ]
+           [ features FEATURES ] [ quickack BOOL ] [ congctl NAME ]
+           [ pref PREF ] [ expires TIME ] [ fastopen_no_cookie BOOL ]
+NHFLAGS := [ onlink | pervasive ]
+PREF := [ low | medium | high ]
+TIME := NUMBER[s|ms]
+BOOL := [1|0]
+FEATURES := ecn
+ENCAPTYPE := [ mpls | ip | ip6 | seg6 | seg6local | rpl | ioam6 ]
+ENCAPHDR := [ MPLSLABEL | SEG6HDR | SEG6LOCAL | IOAM6HDR ]
+SEG6HDR := [ mode SEGMODE ] segs ADDR1,ADDRi,ADDRn [hmac HMACKEYID] [cleanup]
+SEGMODE := [ encap | inline ]
+SEG6LOCAL := action ACTION [ OPTIONS ] [ count ]
+ACTION := { End | End.X | End.T | End.DX2 | End.DX6 | End.DX4 |
+            End.DT6 | End.DT4 | End.DT46 | End.B6 | End.B6.Encaps |
+            End.BM | End.S | End.AS | End.AM | End.BPF }
+OPTIONS := OPTION [ OPTIONS ]
+OPTION := { srh SEG6HDR | nh4 ADDR | nh6 ADDR | iif DEV | oif DEV |
+            table TABLEID | vrftable TABLEID | endpoint PROGNAME }
+IOAM6HDR := trace prealloc type IOAM6_TRACE_TYPE ns IOAM6_NAMESPACE size IOAM6_TRACE_SIZE
+ROUTE_GET_FLAGS := [ fibmatch ]
+
+*/
+
 type NetworkRouteType string
 
 const (
@@ -92,33 +126,21 @@ type NetworkRoute struct {
 	Scope     NetworkRouteScope   `json:"scope" yaml:"scope"`
 	Proto     NetworkRouteProto   `json:"proto" yaml:"proto"`
 
-	CreateCommand	*command.Command `yaml:"-" json:"-"`
+	CreateCommand *Command `yaml:"-" json:"-"`
-	ReadCommand	*command.Command `yaml:"-" json:"-"`
+	ReadCommand   *Command `yaml:"-" json:"-"`
-	UpdateCommand	*command.Command `yaml:"-" json:"-"`
+	UpdateCommand *Command `yaml:"-" json:"-"`
-	DeleteCommand	*command.Command `yaml:"-" json:"-"`
+	DeleteCommand *Command `yaml:"-" json:"-"`
 
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `json:"-" yaml:"-"`
 }
 
 func NewNetworkRoute() *NetworkRoute {
-	n := &NetworkRoute{Rtid: NetworkRouteTableMain}
+	n := &NetworkRoute{Rtid: NetworkRouteTableMain, Common: &Common{ resourceType: NetworkRouteTypeName } }
- 	n.Common = NewCommon(NetworkRouteTypeName, false)
-	n.Common.NormalizePath = n.NormalizePath
 	n.CreateCommand, n.ReadCommand, n.UpdateCommand, n.DeleteCommand = n.NewCRUD()
 	return n
 }
 
-func (n *NetworkRoute) Init(u data.URIParser) (err error) {
-	if u == nil {
-		u = folio.URI(n.URI()).Parse()
-	}
-	return n.SetParsedURI(u)
-}
-
-func (n *NetworkRoute) NormalizePath() error {
-	return nil
-}
-
 func (n *NetworkRoute) SetResourceMapper(resources data.ResourceMapper) {
 	n.Resources = resources
 }
@@ -188,6 +210,14 @@ func (n *NetworkRoute) URI() string {
 	return fmt.Sprintf("route://%s", n.Id)
 }
 
+func (n *NetworkRoute) SetURI(uri string) error {
+	return nil
+}
+
+func (n *NetworkRoute) UseConfig(config data.ConfigurationValueGetter) {
+	n.config = config
+}
+
 func (n *NetworkRoute) Validate() error {
 	return fmt.Errorf("failed")
 }
@@ -442,41 +472,41 @@ func (n *NetworkRoute) UnmarshalJSON(data []byte) error {
 }
 
 
-func (n *NetworkRoute) NewCRUD() (create *command.Command, read *command.Command, update *command.Command, del *command.Command) {
+func (n *NetworkRoute) NewCRUD() (create *Command, read *Command, update *Command, del *Command) {
 	return NewNetworkRouteCreateCommand(), NewNetworkRouteReadCommand(), NewNetworkRouteUpdateCommand(), NewNetworkRouteDeleteCommand()
 }
 
-func NewNetworkRouteCreateCommand() *command.Command {
+func NewNetworkRouteCreateCommand() *Command {
-	c := command.NewCommand()
+	c := NewCommand()
 	c.Path = "ip"
-	c.Args = []command.CommandArg{
+	c.Args = []CommandArg{
-		command.CommandArg("route"),
+		CommandArg("route"),
-		command.CommandArg("add"),
+		CommandArg("add"),
-		command.CommandArg("{{ if .To }}to {{ .To }}{{ end }}"),
+		CommandArg("{{ if .To }}to {{ .To }}{{ end }}"),
-		command.CommandArg("{{ if .Rtid }}table {{ .Rtid }}{{ end }}"),
+		CommandArg("{{ if .Rtid }}table {{ .Rtid }}{{ end }}"),
-		command.CommandArg("{{ if .Gateway }}via {{ .Gateway }}{{ end }}"),
+		CommandArg("{{ if .Gateway }}via {{ .Gateway }}{{ end }}"),
-		command.CommandArg("{{ if .Proto }}protocol {{ .Proto }}{{ end }}"),
+		CommandArg("{{ if .Proto }}protocol {{ .Proto }}{{ end }}"),
-		command.CommandArg("{{ if .Scope }}scope {{ .Scope }}{{ end }}"),
+		CommandArg("{{ if .Scope }}scope {{ .Scope }}{{ end }}"),
-		command.CommandArg("{{ if .RouteType }}type {{ .RouteType }}{{ end }}"),
+		CommandArg("{{ if .RouteType }}type {{ .RouteType }}{{ end }}"),
-		command.CommandArg("{{ if .Interface }}dev {{ .Interface }}{{ end }}"),
+		CommandArg("{{ if .Interface }}dev {{ .Interface }}{{ end }}"),
-		command.CommandArg("{{ if .Metric }}metric {{ .Metric }}{{ end }}"),
+		CommandArg("{{ if .Metric }}metric {{ .Metric }}{{ end }}"),
 	}
 	return c
 }
 
-func NewNetworkRouteReadCommand() *command.Command {
+func NewNetworkRouteReadCommand() *Command {
-	c := command.NewCommand()
+	c := NewCommand()
 	c.Path = "ip"
-	c.Args = []command.CommandArg{
+	c.Args = []CommandArg{
-		command.CommandArg("route"),
+		CommandArg("route"),
-		command.CommandArg("show"),
+		CommandArg("show"),
-		command.CommandArg("{{ if .To }}to {{ .To }}{{ end }}"),
+		CommandArg("{{ if .To }}to {{ .To }}{{ end }}"),
-		command.CommandArg("{{ if .Rtid }}table {{ .Rtid }}{{ end }}"),
+		CommandArg("{{ if .Rtid }}table {{ .Rtid }}{{ end }}"),
-		command.CommandArg("{{ if .Gateway }}via {{ .Gateway }}{{ end }}"),
+		CommandArg("{{ if .Gateway }}via {{ .Gateway }}{{ end }}"),
-		command.CommandArg("{{ if .Proto }}protocol {{ .Proto }}{{ end }}"),
+		CommandArg("{{ if .Proto }}protocol {{ .Proto }}{{ end }}"),
-		command.CommandArg("{{ if .Scope }}scope {{ .Scope }}{{ end }}"),
+		CommandArg("{{ if .Scope }}scope {{ .Scope }}{{ end }}"),
-		command.CommandArg("{{ if .RouteType }}type {{ .RouteType }}{{ end }}"),
+		CommandArg("{{ if .RouteType }}type {{ .RouteType }}{{ end }}"),
-		command.CommandArg("{{ if .Interface }}dev {{ .Interface }}{{ end }}"),
+		CommandArg("{{ if .Interface }}dev {{ .Interface }}{{ end }}"),
 	}
 	c.Extractor = func(out []byte, target any) error {
 		n := target.(*NetworkRoute)
@@ -499,16 +529,16 @@ func NewNetworkRouteReadCommand() *command.Command {
 	return c
 }
 
-func NewNetworkRouteUpdateCommand() *command.Command {
+func NewNetworkRouteUpdateCommand() *Command {
-	c := command.NewCommand()
+	c := NewCommand()
 	c.Path = "ip"
-	c.Args = []command.CommandArg{
+	c.Args = []CommandArg{
-		command.CommandArg("del"),
+		CommandArg("del"),
-		command.CommandArg("{{ .Name }}"),
+		CommandArg("{{ .Name }}"),
 	}
 	return c
 }
 
-func NewNetworkRouteDeleteCommand() *command.Command {
+func NewNetworkRouteDeleteCommand() *Command {
 	return nil
 }

internal/resource/package.go

@@ -23,9 +23,6 @@ import (
 	"decl/internal/tempdir"
 )
 
-const (
-	PackageTypeName TypeName = "package"
-)
 var (
 	PackageTempDir tempdir.Path = "jx_package_resource"
 )
@@ -53,7 +50,6 @@ var SupportedPackageTypes []PackageType = []PackageType{PackageTypeApk, PackageT
 var SystemPackageType PackageType = FindSystemPackageType()
 
 type Package struct {
-	*Common					`yaml:",inline" json:",inline"`
 	stater			machine.Stater `yaml:"-" json:"-"`
 	Source			string      `yaml:"source,omitempty" json:"source,omitempty"`
 	Name        string	`yaml:"name" json:"name"`
@@ -66,12 +62,18 @@ type Package struct {
 	ReadCommand   *command.Command `yaml:"-" json:"-"`
 	UpdateCommand *command.Command `yaml:"-" json:"-"`
 	DeleteCommand *command.Command `yaml:"-" json:"-"`
+	// state attributes
+	State string `yaml:"state,omitempty" json:"state,omitempty"`
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `yaml:"-" json:"-"`
 }
 
 func init() {
 	folio.DocumentRegistry.ResourceTypes.Register([]string{"package", string(PackageTypeApk), string(PackageTypeApt), string(PackageTypeDeb), string(PackageTypeDnf), string(PackageTypeRpm), string(PackageTypePip), string(PackageTypeYum)}, func(u *url.URL) data.Resource {
-		return ConstructNewPackage(u)
+		p := NewPackage()
+		e := p.SetParsedURI(u)
+		slog.Info("PackageFactory SetParsedURI()", "error", e)
+		return p
 	})
 }
 
@@ -86,41 +88,7 @@ func FindSystemPackageType() PackageType {
 }
 
 func NewPackage() *Package {
-	return &Package{
+	return &Package{ PackageType: SystemPackageType }
-		Common: NewCommon(PackageTypeName, true),
-		PackageType: SystemPackageType,
-	}
-}
-
-func ConstructNewPackage(uri *url.URL) (p *Package) {
-	p = NewPackage()
-	if uri != nil {
-		if err := folio.CastParsedURI(uri).ConstructResource(p); err != nil {
-			panic(err)
-		}
-	}
-	return
-}
-
-func (p *Package) Init(u data.URIParser) error {
-	if u == nil {
-		u = folio.URI(p.URI()).Parse()
-	}
-	uri := u.URL()
-
-	p.Name = filepath.Join(uri.Hostname(), uri.Path)
-	p.Version = uri.Query().Get("version")
-	if p.Version == "" {
-		p.Version = "latest"
-	}
-	indicatedPackageType := PackageType(uri.Query().Get("type"))
-	if indicatedPackageType.Validate() != nil {
-		p.PackageType = SystemPackageType
-	}
-
-	p.CreateCommand, p.ReadCommand, p.UpdateCommand, p.DeleteCommand = p.PackageType.NewCRUD()
-
-	return p.SetParsedURI(u)
 }
 
 func (p *Package) SetResourceMapper(resources data.ResourceMapper) {
@@ -129,11 +97,11 @@ func (p *Package) SetResourceMapper(resources data.ResourceMapper) {
 
 func (p *Package) Clone() data.Resource {
 	newp := &Package {
-		Common: p.Common.Clone(),
 		Name: p.Name,
 		Required: p.Required,
 		Version: p.Version,
 		PackageType: p.PackageType,
+		State: p.State,
 	}
 	newp.CreateCommand, newp.ReadCommand, newp.UpdateCommand, newp.DeleteCommand = newp.PackageType.NewCRUD()
 	return newp
@@ -167,11 +135,11 @@ func (p *Package) Notify(m *machine.EventMessage) {
 				if triggerErr := p.StateMachine().Trigger("state_read"); triggerErr == nil {
 					return
 				} else {
-					p.Common.State = "absent"
+					p.State = "absent"
 					panic(triggerErr)
 				}
 			} else {
-				p.Common.State = "absent"
+				p.State = "absent"
 				if ! errors.Is(readErr, ErrResourceStateAbsent) {
 					panic(readErr)
 				}
@@ -196,17 +164,17 @@ func (p *Package) Notify(m *machine.EventMessage) {
 				if triggerErr := p.StateMachine().Trigger("deleted"); triggerErr == nil {
 					return
 				} else {
-					p.Common.State = "present"
+					p.State = "present"
 					panic(triggerErr)
 				}
 			} else {
-				p.Common.State = "present"
+				p.State = "present"
 				panic(deleteErr)
 			}
 		case "absent":
-			p.Common.State = "absent"
+			p.State = "absent"
 		case "present", "created", "updated", "read":
-			p.Common.State = "present"
+			p.State = "present"
 		}
 	case machine.EXITSTATEEVENT:
 	}
@@ -224,25 +192,36 @@ func (p *Package) URI() string {
 }
 
 
-func (p *Package) SetParsedURI(uri data.URIParser) (err error) {
+func (p *Package) SetURI(uri string) error {
-	u := uri.URL()
+	resourceUri, e := url.Parse(uri)
-	if u.Scheme == "package" {
+	if e == nil {
-		p.Name = filepath.Join(u.Hostname(), u.Path)
+		e = p.SetParsedURI(resourceUri)
-		p.Version = u.Query().Get("version")
+	}
+	return e
+}
+
+func (p *Package) SetParsedURI(uri *url.URL) (err error) {
+	if uri.Scheme == "package" {
+		p.Name = filepath.Join(uri.Hostname(), uri.Path)
+		p.Version = uri.Query().Get("version")
 		if p.Version == "" {
 			p.Version = "latest"
 		}
-		indicatedPackageType := PackageType(u.Query().Get("type"))
+		indicatedPackageType := PackageType(uri.Query().Get("type"))
 		if indicatedPackageType.Validate() != nil {
 			p.PackageType = SystemPackageType
 		}
 	} else {
-		err = fmt.Errorf("%w: %s is not a package resource ", ErrInvalidResourceURI, u.String())
+		err = fmt.Errorf("%w: %s is not a package resource ", ErrInvalidResourceURI, uri.String())
 	}
 	p.CreateCommand, p.ReadCommand, p.UpdateCommand, p.DeleteCommand = p.PackageType.NewCRUD()
 	return
 }
 
+func (p *Package) UseConfig(config data.ConfigurationValueGetter) {
+	p.config = config
+}
+
 func (p *Package) JSON() ([]byte, error) {
 	return json.Marshal(p)
 }
@@ -352,9 +331,6 @@ func (p *Package) LoadDecl(yamlResourceDeclaration string) error {
 func (p *Package) Type() string { return "package" }
 
 func (p *Package) Read(ctx context.Context) (resourceYaml []byte, err error) {
-	if p.Version == "latest" {
-		p.Version = ""
-	}
 	if p.ReadCommand.Exists() {
 		var out []byte
 		out, err = p.ReadCommand.Execute(p)
@@ -519,10 +495,10 @@ func NewApkReadCommand() *command.Command {
 		if packageName == p.Name {
 			p.Name = packageName
 			p.Version = packageVersion
-			p.Common.State = "present"
+			p.State = "present"
 		} else {
 			slog.Info("NewApkReadCommand().Extrctor() mismatch", "name", p.Name, "parsed", packageName)
-			p.Common.State = "absent"
+			p.State = "absent"
 		}
 		return nil
 	}
@@ -578,7 +554,7 @@ func NewApkReadPackagesCommand() *command.Command {
 				packageName := strings.Join(packageFields[0:numberOfFields - 2], "-")
 				packageVersion := strings.Join(packageFields[numberOfFields - 2:numberOfFields - 1], "-")
 				p.Name = packageName
-				p.Common.State = "present"
+				p.State = "present"
 				p.Version = packageVersion
 			}
 		}
@@ -619,16 +595,16 @@ func NewAptReadCommand() *command.Command {
 					switch key {
 					case "Package":
 						if value != p.Name {
-							p.Common.State = "absent"
+							p.State = "absent"
 							return nil
 						}
 					case "Status":
 						statusFields := strings.SplitN(value, " ", 3)
 						if len(statusFields) > 1 {
 							if statusFields[2] == "installed" {
-								p.Common.State = "present"
+								p.State = "present"
 							} else {
-								p.Common.State = "absent"
+								p.State = "absent"
 							}
 						}
 					case "Version":
@@ -695,7 +671,7 @@ func NewAptReadPackagesCommand() *command.Command {
 			packageName := packageFields[0]
 			packageVersion := installedPackage[1]
 			p.Name = packageName
-			p.Common.State = "present"
+			p.State = "present"
 			p.Version = packageVersion
 			p.PackageType = PackageTypeApt
 		}
@@ -735,16 +711,16 @@ func NewDebReadCommand() *command.Command {
 					switch key {
 					case "Package":
 						if value != p.Name {
-							p.Common.State = "absent"
+							p.State = "absent"
 							return nil
 						}
 					case "Status":
 						statusFields := strings.SplitN(value, " ", 3)
 						if len(statusFields) > 1 {
 							if statusFields[2] == "installed" {
-								p.Common.State = "present"
+								p.State = "present"
 							} else {
-								p.Common.State = "absent"
+								p.State = "absent"
 							}
 						}
 					case "Version":
@@ -811,7 +787,7 @@ func NewDebReadPackagesCommand() *command.Command {
 					p.Version = packageVersionFields[0]
 				}
 				p.Name = packageName
-				p.Common.State = "present"
+				p.State = "present"
 				p.PackageType = PackageTypeDeb
 				lineIndex++
 			}
@@ -857,7 +833,7 @@ func NewDnfReadCommand() *command.Command {
 				packageName := strings.TrimSpace(strings.Join(packageNameField[0:lenName - 1], "."))
 			
 				if packageName == p.Name {
-					p.Common.State = "present"
+					p.State = "present"
 					packageVersionField := strings.Split(fields[1], ":")
 					if len(packageVersionField) > 1 {
 						//packageEpoch := strings.TrimSpace(packageVersionField[0])
@@ -870,7 +846,7 @@ func NewDnfReadCommand() *command.Command {
 				slog.Info("DnfReadCommaond.Extract()", "package", packageName, "package", p)
 			}
 		}
-		p.Common.State = "absent"
+		p.State = "absent"
 		slog.Info("Extract()", "package", p)
 		return nil
 	}
@@ -931,7 +907,7 @@ func NewDnfReadPackagesCommand() *command.Command {
 				p.Version = packageVersionFields[0]
 			}
 			p.Name = packageName
-			p.Common.State = "present"
+			p.State = "present"
 			p.PackageType = PackageTypeDnf
 			lineIndex++
 		}
@@ -973,13 +949,13 @@ func NewRpmReadCommand() *command.Command {
 				packageVersion := strings.Join(packageFields[numberOfFields - 2:numberOfFields - 1], "-")
 				slog.Info("Package[RPM].Extract()", "name", packageName, "version", packageVersion, "package", p)
 				if packageName == p.Name {
-					p.Common.State = "present"
+					p.State = "present"
 					p.Version = packageVersion
 					return nil
 				}
 			}
 		}
-		p.Common.State = "absent"
+		p.State = "absent"
 		slog.Info("Extract()", "package", p)
 		return nil
 	}
@@ -1037,13 +1013,13 @@ func NewPipReadCommand() *command.Command {
 				packageName := packageFields[0]
 				packageVersion := packageFields[1]
 				if packageName == p.Name {
-					p.Common.State = "present"
+					p.State = "present"
 					p.Version = packageVersion
 					return nil
 				}
 			}
 		}
-		p.Common.State = "absent"
+		p.State = "absent"
 		slog.Info("Extract()", "package", p)
 		return nil
 	}
@@ -1107,7 +1083,7 @@ func NewYumReadCommand() *command.Command {
 			//packageArch := strings.TrimSpace(packageNameField[1])
 			
 			if packageName == p.Name {
-				p.Common.State = "present"
+				p.State = "present"
 				packageVersionField := strings.Split(fields[1], ":")
 				//packageEpoch := strings.TrimSpace(packageVersionField[0])
 				packageVersion := strings.TrimSpace(packageVersionField[1])
@@ -1115,7 +1091,7 @@ func NewYumReadCommand() *command.Command {
 				return nil
 			}
 		}
-		p.Common.State = "absent"
+		p.State = "absent"
 		slog.Info("Extract()", "package", p)
 		return nil
 	}

internal/resource/package_test.go

@@ -4,12 +4,19 @@ package resource
 
 import (
 	"context"
+_	"encoding/json"
 	"fmt"
 	"github.com/stretchr/testify/assert"
+_ "gopkg.in/yaml.v3"
+_ "io"
 	"log/slog"
+_ "net/http"
+_ "net/http/httptest"
+_ "net/url"
+_ "os"
+_ "strings"
 	"testing"
 	"decl/internal/command"
-	"decl/internal/folio"
 )
 
 func TestNewPackageResource(t *testing.T) {
@@ -347,8 +354,6 @@ type: %s
 	assert.NotNil(t, p)
 	loadErr := p.LoadDecl(decl)
 	assert.Nil(t, loadErr)
-	assert.Nil(t, p.Init(nil))
-
 	p.ReadCommand = SystemPackageType.NewReadCommand()
 /*
 	p.ReadCommand.Executor = func(value any) ([]byte, error) {
@@ -358,7 +363,6 @@ type: %s
 	p.ResolveId(ctx)
 	yaml, readErr := p.Read(ctx)
 	assert.ErrorIs(t, readErr, ErrResourceStateAbsent)
-	slog.Info("TestReadPackageError", "package", p, "common", p.Common, "yaml", yaml)
 	assert.YAMLEq(t, expected, string(yaml))
 	slog.Info("read()", "yaml", yaml)
 	assert.Equal(t, "", p.Version)
@@ -371,9 +375,7 @@ func TestCreatePackage(t *testing.T) {
 func TestPackageSetURI(t *testing.T) {
 	p := NewPackage()
 	assert.NotNil(t, p)
-	
+	e := p.SetURI("package://" + "12345_key?type=apk")
-	uri := folio.URI("package://" + "12345_key?type=apk").Parse()
-	e := p.Init(uri)
 	assert.Nil(t, e)
 	assert.Equal(t, "package", p.Type())
 	assert.Equal(t, "12345_key", p.Name)

internal/resource/pki.go

@@ -44,17 +44,12 @@ var ErrPKIInvalidEncodingType error = errors.New("Invalid EncodingType")
 var ErrPKIFailedDecodingPemBlock error = errors.New("Failed decoding pem block")
 
 func init() {
-	ResourceTypes.Register([]string{"pki"}, func(u *url.URL) (data.Resource) {
+	ResourceTypes.Register([]string{"pki"}, func(u *url.URL) data.Resource {
 		k := NewPKI()
-		if u != nil {
-			if err := folio.CastParsedURI(u).ConstructResource(k); err != nil {
-                                panic(err)
-                        }
 		ref := folio.ResourceReference(filepath.Join(u.Hostname(), u.Path))
 		if len(ref) > 0 {
 			k.PrivateKeyRef = ref
 		}
-		}
 		return k
 	})
 }
@@ -88,6 +83,8 @@ type PKI struct {
 
 	Bits int `json:"bits" yaml:"bits"`
 	EncodingType EncodingType `json:"type" yaml:"type"`
+	//State    string   `json:"state,omitempty" yaml:"state,omitempty"`
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `json:"-" yaml:"-"`
 }
 
@@ -105,6 +102,7 @@ func (k *PKI) Clone() data.Resource {
 	return &PKI {
 		Common: k.Common.Clone(),
 		EncodingType: k.EncodingType,
+		//State: k.State,
 	}
 }
 
@@ -121,16 +119,6 @@ func (k *PKI) Notify(m *machine.EventMessage) {
 	switch m.On {
 	case machine.ENTERSTATEEVENT:
 		switch m.Dest {
-			case "start_stat":
-				if statErr := k.ReadStat(); statErr == nil {
-					if triggerErr := k.StateMachine().Trigger("exists"); triggerErr == nil {
-						return
-					}
-				} else {
-					if triggerErr := k.StateMachine().Trigger("notexists"); triggerErr == nil {
-						return
-					}
-				}
 			case "start_read":
 				if _,readErr := k.Read(ctx); readErr == nil {
 					if triggerErr := k.StateMachine().Trigger("state_read"); triggerErr == nil {
@@ -187,6 +175,22 @@ func (k *PKI) URI() string {
 	return fmt.Sprintf("pki://%s", filepath.Join(u.Hostname(), u.RequestURI()))
 }
 
+func (k *PKI) SetURI(uri string) error {
+	resourceUri, e := url.Parse(uri)
+	if e == nil {
+		if resourceUri.Scheme == "pki" {
+			k.PrivateKeyRef = folio.ResourceReference(fmt.Sprintf("pki://%s", filepath.Join(resourceUri.Hostname(), resourceUri.Path)))
+		} else {
+			e = fmt.Errorf("%w: %s is not a cert", ErrInvalidResourceURI, uri)
+		}
+	}
+	return e
+}
+
+func (k *PKI) UseConfig(config data.ConfigurationValueGetter) {
+	k.config = config
+}
+
 func (k *PKI) Validate() error {
 	return fmt.Errorf("failed")
 }
@@ -224,27 +228,6 @@ func (k *PKI) LoadDecl(yamlResourceDeclaration string) error {
 	return k.LoadString(yamlResourceDeclaration, codec.FormatYaml)
 }
 
-func (k *PKI) ReadStat() (err error) {
-	var resourcesErr []string
-	if ! k.PrivateKeyRef.Exists() {
-		resourcesErr = append(resourcesErr, string(k.PrivateKeyRef))
-	}
-
-	if ! k.PublicKeyRef.Exists() {
-		resourcesErr = append(resourcesErr, string(k.PublicKeyRef))
-	}
-
-	if ! k.CertificateRef.Exists() {
-		resourcesErr = append(resourcesErr, string(k.CertificateRef))
-	}
-
-	if len(resourcesErr) > 0 {
-		err = fmt.Errorf("PKI resources missing: %s", strings.Join(resourcesErr, ","))
-//	k.State = "absent"
-	}
-	return
-}
-
 func (k *PKI) ResolveId(ctx context.Context) string {
 	return string(k.PrivateKeyRef)
 }
@@ -480,6 +463,62 @@ func (k *PKI) Update(ctx context.Context) (err error) {
 
 func (k *PKI) Type() string { return "pki" }
 
+/*
+func (k *PKI) UnmarshalValue(value *PKIContent) error {
+        d.Type = value.Type
+        d.Transition = value.Transition
+        d.Config = value.Config
+        newResource, resourceErr := ResourceTypes.New(fmt.Sprintf("%s://", value.Type))
+        if resourceErr != nil {
+                slog.Info("Declaration.UnmarshalValue", "value", value, "error", resourceErr)
+                return resourceErr
+        }
+        d.Attributes = newResource
+        return nil
+}
+
+func (k *PKI) UnmarshalYAML(value *yaml.Node) error {
+        t := &DeclarationType{}
+        if unmarshalResourceTypeErr := value.Decode(t); unmarshalResourceTypeErr != nil {
+                return unmarshalResourceTypeErr
+        }
+
+        if err := d.UnmarshalValue(t); err != nil {
+                return err
+        }
+
+        resourceAttrs := struct {
+                Attributes yaml.Node `json:"attributes"`
+        }{}
+        if unmarshalAttributesErr := value.Decode(&resourceAttrs); unmarshalAttributesErr != nil {
+                return unmarshalAttributesErr
+        }
+        if unmarshalResourceErr := resourceAttrs.Attributes.Decode(d.Attributes); unmarshalResourceErr != nil {
+                return unmarshalResourceErr
+        }
+        return nil
+}
+
+func (d *Declaration) UnmarshalJSON(data []byte) error {
+        t := &DeclarationType{}
+        if unmarshalResourceTypeErr := json.Unmarshal(data, t); unmarshalResourceTypeErr != nil {
+                return unmarshalResourceTypeErr
+        }
+
+        if err := d.UnmarshalValue(t); err != nil {
+                return err
+        }
+
+        resourceAttrs := struct {
+                Attributes Resource `json:"attributes"`
+        }{Attributes: d.Attributes}
+        if unmarshalAttributesErr := json.Unmarshal(data, &resourceAttrs); unmarshalAttributesErr != nil {
+                return unmarshalAttributesErr
+        }
+return nil
+}
+*/
+
 func (t *EncodingType) UnmarshalValue(value string) error {
 	switch value {
 	case string(EncodingTypePem):

internal/resource/pki_test.go

@@ -19,6 +19,7 @@ _	"os"
 	"strings"
 	"testing"
 	"path/filepath"
+	"net/url"
 )
 
 type TestResourceMapper func(key string) (data.Declaration, bool)
@@ -35,9 +36,6 @@ func (rm TestResourceMapper) Has(key string) (ok bool) {
 func (rm TestResourceMapper) Set(key string, value data.Declaration) {
 }
 
-func (rm TestResourceMapper) Delete(key string) {
-}
-
 type StringContentReadWriter func() (any, error)
 
 func (s StringContentReadWriter) ContentWriterStream() (*transport.Writer, error) {
@@ -58,7 +56,7 @@ func (s StringContentReadWriter) LoadString(docData string, f codec.Format) (err
 func (s StringContentReadWriter) LoadDecl(yamlResourceDeclaration string) error { return nil }
 func (s StringContentReadWriter) ResolveId(ctx context.Context) (string) { return "" }
 func (s StringContentReadWriter) SetURI(uri string) (error) { return nil }
-func (s StringContentReadWriter) SetParsedURI(uri data.URIParser) (error) { return nil }
+func (s StringContentReadWriter) SetParsedURI(uri *url.URL) (error) { return nil }
 func (s StringContentReadWriter) URI() (string) { return "" }
 func (s StringContentReadWriter) Validate() (error) { return nil }
 func (s StringContentReadWriter) ResourceType() data.TypeName { return "" }

internal/resource/resource.go

@@ -20,6 +20,67 @@ var (
 )
 
 type ResourceReference string
+/*
+type ResourceSelector func(r *Declaration) bool
+
+type Resource interface {
+	Type() string
+	StateMachine() machine.Stater
+	URI() string
+	SetURI(string) error
+	UseConfig(config ConfigurationValueGetter)
+	ResolveId(context.Context) string
+	ResourceLoader
+	StateTransformer
+	ResourceReader
+	ResourceValidator
+	Clone() Resource
+	SetResourceMapper(resources ResourceMapper)
+}
+
+type ContentReader interface {
+	ContentReaderStream() (*transport.Reader, error)
+}
+
+type ContentWriter interface {
+	ContentWriterStream() (*transport.Writer, error)
+}
+
+type ContentReadWriter interface {
+	ContentReader
+	ContentWriter
+}
+
+type ResourceValidator interface {
+	Validate() error
+}
+
+type ResourceCreator interface {
+	Create(context.Context) error
+}
+
+type ResourceReader interface {
+	Read(context.Context) ([]byte, error)
+}
+
+type ResourceUpdater interface {
+	Update(context.Context) error
+}
+
+type ResourceDeleter interface {
+	Delete(context.Context) error
+}
+
+type ResourceDecoder struct {
+}
+
+type ResourceCrudder struct {
+	ResourceCreator
+	ResourceReader
+	ResourceUpdater
+	ResourceDeleter
+}
+*/
 
 func NewResource(uri string) data.Resource {
 	r, e := ResourceTypes.New(uri)
@@ -29,17 +90,50 @@ func NewResource(uri string) data.Resource {
 	return nil
 }
 
-func ResourceConstructor(res data.Resource, uri data.URIParser) (err error) {
+/*
-	if uri != nil {
+
-		return uri.ConstructResource(res)
+// Return a Content ReadWriter for the resource referred to.
-	} else {
+func (r ResourceReference) Lookup(look data.ResourceMapper) data.ContentReadWriter {
-		if ri, ok := res.(data.ResourceInitializer); ok {
+	slog.Info("ResourceReference.Lookup()", "resourcereference", r, "resourcemapper", look)
-			return ri.Init(uri)
+	if look != nil {
+		if v,ok := look.Get(string(r)); ok {
+			return v.(data.ContentReadWriter)
 		}
 	}
-	return
+	return r
 }
 
+func (r ResourceReference) Dereference(look data.ResourceMapper) data.Resource {
+	slog.Info("ResourceReference.Dereference()", "resourcereference", r, "resourcemapper", look)
+	if look != nil {
+		if v,ok := look.Get(string(r)); ok {
+			return v.(*Declaration).Attributes
+		}
+	}
+	return nil
+}
+
+func (r ResourceReference) Parse() *url.URL {
+	u, e := url.Parse(string(r))
+	if e == nil {
+		return u
+	}
+	return nil
+}
+
+func (r ResourceReference) Exists() bool {
+	return transport.ExistsURI(string(r))
+}
+
+func (r ResourceReference) ContentReaderStream() (*transport.Reader, error) {
+	return transport.NewReaderURI(string(r))
+}
+
+func (r ResourceReference) ContentWriterStream() (*transport.Writer, error) {
+	return transport.NewWriterURI(string(r))
+}
+*/
+
 func StorageMachine(sub machine.Subscriber) machine.Stater {
 // start_destroy -> absent -> start_create -> present -> start_destroy
 	stater := machine.New("unknown")

internal/resource/schema_test.go

@@ -58,8 +58,6 @@ func TestSchemaValidateJSON(t *testing.T) {
 	testFile := NewFile()
 	e := testFile.LoadDecl(decl)
 	assert.Nil(t, e)
-	assert.Equal(t, file, testFile.ResolveId(ctx))
-
 	fileApplyErr := testFile.Apply()
 	assert.Nil(t, fileApplyErr)
 
@@ -73,10 +71,8 @@ func TestSchemaValidateJSON(t *testing.T) {
 	assert.NotNil(t, f)
 
 	f.Path = file
-	assert.Nil(t, f.Init(nil))
 	r, e := f.Read(ctx)
 	assert.Nil(t, e)
-
 	assert.Equal(t, ProcessTestUserName, f.Owner)
 
 	info, statErr := os.Stat(file)

internal/resource/service.go

@@ -6,7 +6,7 @@ package resource
 import (
 	"context"
 	"fmt"
-	"log/slog"
+_	"log/slog"
 	"net/url"
 	"path/filepath"
 	"io"
@@ -14,15 +14,8 @@ import (
 	"gitea.rosskeen.house/rosskeen.house/machine"
 	"decl/internal/codec"
 	"decl/internal/data"
-	"decl/internal/command"
-	"decl/internal/folio"
 	"encoding/json"
 	"strings"
-	"errors"
-)
-
-var (
-	ErrUnsupportedServiceManagerType error = errors.New("Unsupported service manager")
 )
 
 const (
@@ -36,72 +29,32 @@ const (
 	ServiceManagerTypeSysV ServiceManagerType = "sysv"
 )
 
-const (
-	SysVStatusRunning int = 0
-	SysVStatusStopped int = 1
-	SysVStatusUnknown int = 2
-	SysVStatusMissing int = 3
-)
-
-var (
-	SupportedServiceManagerTypes []ServiceManagerType = []ServiceManagerType{ServiceManagerTypeSystemd, ServiceManagerTypeSysV}
-	SystemServiceManagerType ServiceManagerType = FindSystemServiceManagerType()
-)
-
 type Service struct {
 	*Common `yaml:",inline" json:",inline"`
 	stater	machine.Stater `yaml:"-" json:"-"`
 	Name	string	`json:"name" yaml:"name"`
 	ServiceManagerType ServiceManagerType `json:"servicemanager,omitempty" yaml:"servicemanager,omitempty"`
 
-	CreateCommand *command.Command `yaml:"-" json:"-"`
+	CreateCommand *Command `yaml:"-" json:"-"`
-	ReadCommand   *command.Command `yaml:"-" json:"-"`
+	ReadCommand   *Command `yaml:"-" json:"-"`
-	UpdateCommand *command.Command `yaml:"-" json:"-"`
+	UpdateCommand *Command `yaml:"-" json:"-"`
-	DeleteCommand *command.Command `yaml:"-" json:"-"`
+	DeleteCommand *Command `yaml:"-" json:"-"`
 
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `yaml:"-" json:"-"`
 }
 
 func init() {
 	ResourceTypes.Register([]string{"service"}, func(u *url.URL) data.Resource {
 		s := NewService()
-		if err := folio.CastParsedURI(u).ConstructResource(s); err != nil {
+		s.Name = filepath.Join(u.Hostname(), u.Path)
-			panic(err)
+		s.CreateCommand, s.ReadCommand, s.UpdateCommand, s.DeleteCommand = s.ServiceManagerType.NewCRUD()
-		}
 		return s
 	})
 }
 
-func FindSystemServiceManagerType() ServiceManagerType {
+func NewService() *Service {
-	for _, servicemanagerType := range SupportedServiceManagerTypes {
+	return &Service{ ServiceManagerType: ServiceManagerTypeSystemd, Common: &Common{ resourceType: ServiceTypeName } }
-		if c := servicemanagerType.NewReadCommand(); c != nil && c.Exists() {
-			return servicemanagerType
-		}
-	}
-	return ServiceManagerTypeSystemd
-}
-
-func NewService() (s *Service) {
-	s = &Service{ ServiceManagerType: SystemServiceManagerType }
-	s.Common = NewCommon(ServiceTypeName, false)
-	s.Common.NormalizePath = s.NormalizePath
-	s.CreateCommand, s.ReadCommand, s.UpdateCommand, s.DeleteCommand = s.ServiceManagerType.NewCRUD()
-	return
-}
-
-func (s *Service) Init(u data.URIParser) (err error) {
-	if u == nil {
-		u = folio.URI(s.URI()).Parse()
-	}
-	uri := u.URL()
-	err = s.SetParsedURI(u)
-	s.Name = filepath.Join(uri.Hostname(), uri.Path)
-	s.CreateCommand, s.ReadCommand, s.UpdateCommand, s.DeleteCommand = s.ServiceManagerType.NewCRUD()
-	return
-}
-
-func (s *Service) NormalizePath() error {
-	return nil
 }
 
 func (s *Service) StateMachine() machine.Stater {
@@ -116,16 +69,6 @@ func (s *Service) Notify(m *machine.EventMessage) {
 	switch m.On {
 	case machine.ENTERSTATEEVENT:
 		switch m.Dest {
-		case "start_stat":
-			if statErr := s.ReadStat(); statErr == nil {
-				if triggerErr := s.StateMachine().Trigger("exists"); triggerErr == nil {
-					return
-				}
-			} else {
-				if triggerErr := s.StateMachine().Trigger("notexists"); triggerErr == nil {
-					return
-				}
-			}
 		case "start_create":
 			if e := s.Create(ctx); e == nil {
 				if triggerErr := s.stater.Trigger("created"); triggerErr == nil {
@@ -133,24 +76,10 @@ func (s *Service) Notify(m *machine.EventMessage) {
 				}
 			}
 			s.Common.State = "absent"
-		case "start_read":
+		case "created":
-			if _,readErr := s.Read(ctx); readErr == nil {
-				if triggerErr := s.stater.Trigger("state_read"); triggerErr == nil {
-					return
-				} else {
-					s.Common.State = "absent"
-					panic(triggerErr)
-				}
-			} else {
-				s.Common.State = "absent"
-				panic(readErr)
-			}
-		case "present", "created", "read":
 			s.Common.State = "present"
 		case "running":
 			s.Common.State = "running"
-		case "absent":
-			s.Common.State = "absent"
 		}
 	case machine.EXITSTATEEVENT:
 	}
@@ -160,20 +89,20 @@ func (s *Service) URI() string {
 	return fmt.Sprintf("service://%s", s.Name)
 }
 
-func (s *Service) SetParsedURI(uri data.URIParser) (err error) {
+func (s *Service) SetURI(uri string) error {
-	if err = s.Common.SetParsedURI(uri); err == nil {
+	resourceUri, e := url.Parse(uri)
-		err = s.setFieldsFromPath()
+	if e == nil {
+		if resourceUri.Scheme == s.Type() {
+			s.Name = filepath.Join(resourceUri.Hostname(), resourceUri.RequestURI())
+		} else {
+			e = fmt.Errorf("%w: %s is not a %s", ErrInvalidResourceURI, uri, s.Type())
 		}
-	return
+	}
+	return e
 }
 
-func (s *Service) setFieldsFromPath() (err error) {
+func (s *Service) UseConfig(config data.ConfigurationValueGetter) {
-	if len(s.Common.Path) > 0 {
+	s.config = config
-		s.Name = s.Common.Path
-	} else {
-		err = fmt.Errorf("%w: %s is not an iptable rule", ErrInvalidResourceURI, s.Common.URI())
-	}
-	return
 }
 
 func (s *Service) JSON() ([]byte, error) {
@@ -238,7 +167,7 @@ func (s *Service) UnmarshalYAML(value *yaml.Node) error {
 	return nil
 }
 
-func (s *ServiceManagerType) NewCRUD() (create *command.Command, read *command.Command, update *command.Command, del *command.Command) {
+func (s *ServiceManagerType) NewCRUD() (create *Command, read *Command, update *Command, del *Command) {
 	switch *s {
 	case ServiceManagerTypeSystemd:
 		return NewSystemdCreateCommand(), NewSystemdReadCommand(), NewSystemdUpdateCommand(), NewSystemdDeleteCommand()
@@ -249,52 +178,14 @@ func (s *ServiceManagerType) NewCRUD() (create *command.Command, read *command.C
 	return nil, nil, nil, nil
 }
 
-func (s *ServiceManagerType) NewReadCommand() (read *command.Command) {
+
-	switch *s {
+func (s *Service) Create(ctx context.Context) error {
-	case ServiceManagerTypeSystemd:
-		return NewSystemdReadCommand()
-	case ServiceManagerTypeSysV:
-		return NewSysVReadCommand()
-	default:
-	}
 	return nil
 }
 
-func (s *Service) Create(ctx context.Context) (err error) {
+func (s *Service) Read(ctx context.Context) ([]byte, error) {
-	var out []byte
-	out, err = s.CreateCommand.Execute(s)
-	slog.Info("Service.Create()", "out", out, "error", err)
-	return
-}
 	
-func (s *Service) ReadStat() (err error) {
+	return yaml.Marshal(s)
-	if s.ReadCommand.Exists() {
-		_, err = s.ReadCommand.Execute(s)
-	} else {
-		err = ErrUnsupportedServiceManagerType
-	}
-	return
-}
-
-func (s *Service) Read(ctx context.Context) (resourceYaml []byte, err error) {
-	if s.ReadCommand.Exists() {
-		var out []byte
-		out, err = s.ReadCommand.Execute(s)
-		if err == nil {
-			err = s.ReadCommand.Extractor(out, s)
-		} else {
-			err = fmt.Errorf("%w - %w", ErrResourceStateAbsent, err)
-		}
-		slog.Info("Service.Read()", "service", s, "error", err)
-	} else {
-		err = ErrUnsupportedServiceManagerType
-	}
-	var yamlErr error
-	resourceYaml, yamlErr = yaml.Marshal(s)
-	if err == nil {
-		err = yamlErr
-	}
-	return
 }
 
 func (s *Service) Update(ctx context.Context) error {
@@ -311,22 +202,22 @@ func (s *Service) ResolveId(ctx context.Context) string {
 	return ""
 }
 
-func NewSystemdCreateCommand() *command.Command {
+func NewSystemdCreateCommand() *Command {
-	c := command.NewCommand()
+	c := NewCommand()
 	c.Path = "systemctl"
-	c.Args = []command.CommandArg{
+	c.Args = []CommandArg{
-		command.CommandArg("enable"),
+		CommandArg("enable"),
-		command.CommandArg("{{ .Name }}"),
+		CommandArg("{{ .Name }}"),
 	}
 	return c
 }
 
-func NewSystemdReadCommand() *command.Command {
+func NewSystemdReadCommand() *Command {
-	c := command.NewCommand()
+	c := NewCommand()
 	c.Path = "systemctl"
-	c.Args = []command.CommandArg{
+	c.Args = []CommandArg{
-		command.CommandArg("show"),
+		CommandArg("show"),
-		command.CommandArg("{{ .Name }}"),
+		CommandArg("{{ .Name }}"),
 	}
 	c.Extractor = func(out []byte, target any) error {
 		s := target.(*Service)
@@ -362,63 +253,26 @@ func NewSystemdReadCommand() *command.Command {
 	return c
 }
 
-func NewSystemdUpdateCommand() *command.Command {
+func NewSystemdUpdateCommand() *Command {
 	return nil
 }
 
-func NewSystemdDeleteCommand() *command.Command {
+func NewSystemdDeleteCommand() *Command {
 	return nil
 }
 
-func NewSysVCreateCommand() *command.Command {
+func NewSysVCreateCommand() *Command {
 	return nil
 }
 
-func NewSysVReadCommand() *command.Command {
+func NewSysVReadCommand() *Command {
-	c := command.NewCommand()
-	c.Path = "service"
-	c.Args = []command.CommandArg{
-		command.CommandArg("status"),
-		command.CommandArg("{{ .Name }}"),
-	}
-	c.Extractor = func(out []byte, target any) (err error) {
-		s := target.(*Service)
-		/*
-		serviceStatus := strings.Split(string(out), "\n")
-		for _, statusLine := range(serviceStatus) {
-			if len(statusLine) > 1 {
-				statusFields := strings.Fields(statusLine)
-			}
-		}
-		*/
-		if len(out) < 1 {
-			if err = s.stater.Trigger("notexist"); err != nil {
-				return
-			}
-		}
-		switch c.ExitCode {
-		case SysVStatusRunning:
-			if err = s.stater.Trigger("running"); err != nil {
-				return
-			}
-		case SysVStatusStopped:
-			if err = s.stater.Trigger("created"); err != nil {
-				return
-			}
-		case SysVStatusUnknown, SysVStatusMissing:
-			if err = s.stater.Trigger("notexist"); err != nil {
-				return
-			}
-		}
-		return
-	}
 	return nil
 }
 
-func NewSysVUpdateCommand() *command.Command {
+func NewSysVUpdateCommand() *Command {
 	return nil
 }
 
-func NewSysVDeleteCommand() *command.Command {
+func NewSysVDeleteCommand() *Command {
 	return nil
 }

internal/resource/service_test.go

@@ -4,10 +4,10 @@ package resource
 
 import (
 	"context"
-	"decl/internal/command"
+_	"decl/tests/mocks"
+_ "fmt"
 	"github.com/stretchr/testify/assert"
 	"testing"
-	"decl/internal/folio"
 )
 
 func TestNewServiceResource(t *testing.T) {
@@ -17,35 +17,20 @@ func TestNewServiceResource(t *testing.T) {
 
 func TestUriServiceResource(t *testing.T) {
 	c := NewService()
-	uri := folio.URI("service://ssh").Parse()
+	assert.Nil(t, c.SetURI("service://ssh"))
-
-	assert.Nil(t, c.Init(uri))
 	assert.Equal(t, "ssh", c.Name)
 }
 
 func TestReadServiceResource(t *testing.T) {
-
-	s := NewService()
-	s.Name = "ssh"
-
 	yamlResult := `
   name: "ssh"
   servicemanager: "systemd"
   state: "present"
 `
-	m := &MockCommand{
+	c := NewService()
-		CommandExists: func() error { return nil },
+	c.Name = "ssh"
-		Executor: func(value any) ([]byte, error) {
+	c.State = "present"
-			return nil, nil
+	yamlData, err := c.Read(context.Background())
-		},
-		Extractor: func(output []byte, target any) error {
-			s.Common.State = "present"
-			return nil
-		},
-	}
-
-	s.ReadCommand = (*command.Command)(m)
-	yamlData, err := s.Read(context.Background())
 	assert.Nil(t, err)
 	assert.YAMLEq(t, yamlResult, string(yamlData))
 }

internal/resource/user.go

@@ -28,15 +28,13 @@ type UserType string
 
 const (
 	UserTypeName TypeName = "user"
-	UserTypeBusyBox UserType = "busybox"
+	UserTypeAddUser UserType = "adduser"
-	UserTypeShadow UserType = "shadow"
+	UserTypeUserAdd UserType = "useradd"
 )
 
 var ErrUnsupportedUserType error = errors.New("The UserType is not supported on this system")
 var ErrInvalidUserType error = errors.New("invalid UserType value")
 
-var SupportedUserTypes []UserType = []UserType{UserTypeShadow, UserTypeBusyBox}
-
 var SystemUserType UserType = FindSystemUserType()
 
 type User struct {
@@ -46,65 +44,48 @@ type User struct {
 	UID        string   `json:"uid,omitempty" yaml:"uid,omitempty"`
 	Group      string   `json:"group,omitempty" yaml:"group,omitempty"`
 	Groups     []string `json:"groups,omitempty" yaml:"groups,omitempty"`
-	AppendGroups bool   `json:"appendgroups,omitempty" yaml:"appendgroups,omitempty"`
 	Gecos      string   `json:"gecos,omitempty" yaml:"gecos,omitempty"`
 	Home       string   `json:"home" yaml:"home"`
 	CreateHome bool     `json:"createhome,omitempty" yaml:"createhome,omitempty"`
 	Shell      string   `json:"shell,omitempty" yaml:"shell,omitempty"`
-	UserType   UserType `json:"type,omitempty" yaml:"type,omitempty"`
+	UserType   UserType `json:"-" yaml:"-"`
-
-	userStatus  *user.User  `json:"-" yaml:"-"`
-	groupStatus *user.Group `json:"-" yaml:"-"`
 
 	CreateCommand *command.Command `json:"-" yaml:"-"`
 	ReadCommand *command.Command   `json:"-" yaml:"-"`
 	UpdateCommand *command.Command `json:"-" yaml:"-"`
 	DeleteCommand *command.Command `json:"-" yaml:"-"`
+	config data.ConfigurationValueGetter
 	Resources data.ResourceMapper `json:"-" yaml:"-"`
 }
 
 func NewUser() *User {
-	u := &User{ CreateHome: true, AppendGroups: true, UserType: SystemUserType }
+	return &User{ CreateHome: true, Common: &Common{ resourceType: UserTypeName } }
-	u.Common = NewCommon(UserTypeName, false)
-	u.Common.NormalizePath = u.NormalizePath
-	return u
 }
 
 func init() {
-	folio.DocumentRegistry.ResourceTypes.Register([]string{"user"}, func(u *url.URL) (user data.Resource) {
+	folio.DocumentRegistry.ResourceTypes.Register([]string{"user"}, func(u *url.URL) data.Resource {
-		user = NewUser()
+		user := NewUser()
-		if u != nil {
+		user.Name = u.Hostname()
-			if err := folio.CastParsedURI(u).ConstructResource(user); err != nil {
+		user.UID = LookupUIDString(u.Hostname())
-				panic(err)
+		if _, addUserPathErr := exec.LookPath("adduser"); addUserPathErr == nil {
+			user.UserType = UserTypeAddUser
 		}
+		if _, pathErr := exec.LookPath("useradd"); pathErr == nil {
+			user.UserType = UserTypeUserAdd
 		}
-		return
+		user.CreateCommand, user.ReadCommand, user.UpdateCommand, user.DeleteCommand = user.UserType.NewCRUD()
+		return user
 	})
 }
 
 func FindSystemUserType() UserType {
-	for _, userType := range SupportedUserTypes {
+	for _, userType := range []UserType{UserTypeAddUser, UserTypeUserAdd} {
 		c := userType.NewCreateCommand()
 		if c.Exists() {
 			return userType
 		}
 	}
-	return UserTypeShadow
+	return UserTypeAddUser
-}
-
-func (u *User) Init(uri data.URIParser) error {
-	if uri == nil {
-		uri = folio.URI(u.URI()).Parse()
-	} else {
-		u.Name = uri.URL().Hostname()
-	}
-	u.UID = LookupUIDString(uri.URL().Hostname())
-	u.CreateCommand, u.ReadCommand, u.UpdateCommand, u.DeleteCommand = u.UserType.NewCRUD()
-	return u.SetParsedURI(uri)
-}
-
-func (u *User) NormalizePath() error {
-	return nil
 }
 
 func (u *User) SetResourceMapper(resources data.ResourceMapper) {
@@ -140,16 +121,6 @@ func (u *User) Notify(m *machine.EventMessage) {
 	switch m.On {
 	case machine.ENTERSTATEEVENT:
 		switch m.Dest {
-		case "start_stat":
-			if statErr := u.ReadStat(); statErr == nil {
-				if triggerErr := u.StateMachine().Trigger("exists"); triggerErr == nil {
-					return
-				}
-			} else {
-				if triggerErr := u.StateMachine().Trigger("notexists"); triggerErr == nil {
-					return
-				}
-			}
 		case "start_read":
 			if _,readErr := u.Read(ctx); readErr == nil {
 				if triggerErr := u.StateMachine().Trigger("state_read"); triggerErr == nil {
@@ -162,17 +133,6 @@ func (u *User) Notify(m *machine.EventMessage) {
 				u.Common.State = "absent"
 				panic(readErr)
 			}
-		case "start_update":
-			if updateErr := u.Update(ctx); updateErr == nil {
-				if triggerErr := u.stater.Trigger("updated"); triggerErr == nil {
-					return
-				} else {
-					u.Common.State = "absent"
-				}
-			} else {      
-				u.Common.State = "absent"
-				panic(updateErr)
-			}
 		case "start_delete":
 			if deleteErr := u.Delete(ctx); deleteErr == nil {
 				if triggerErr := u.StateMachine().Trigger("deleted"); triggerErr == nil {
@@ -201,16 +161,27 @@ func (u *User) Notify(m *machine.EventMessage) {
 	}
 }
 
+func (u *User) SetURI(uri string) error {
+	resourceUri, e := url.Parse(uri)
+	if e == nil {
+		if resourceUri.Scheme == "user" {
+			u.Name = resourceUri.Hostname()
+		} else {
+			e = fmt.Errorf("%w: %s is not a user", ErrInvalidResourceURI, uri)
+		}
+	}
+	return e
+}
+
 func (u *User) URI() string {
 	return fmt.Sprintf("user://%s", u.Name)
 }
 
+func (u *User) UseConfig(config data.ConfigurationValueGetter) {
+	u.config = config
+}
+
 func (u *User) ResolveId(ctx context.Context) string {
-	if u.config != nil {
-		if configUser, configUserErr := u.config.GetValue("user"); configUserErr == nil && u.Name == "self" {
-			u.Name = configUser.(string)
-		}
-	}
 	return LookupUIDString(u.Name)
 }
 
@@ -265,74 +236,20 @@ func (u *User) Create(ctx context.Context) (error) {
 	return e
 }
 
-func (u *User) ReadStat() (err error) {
-	if u.userStatus == nil {
-		if u.userStatus, err = user.Lookup(u.Name); err != nil {
-			return err
-		}
-	}
-	if len(u.userStatus.Uid) < 1 {
-		return ErrResourceStateAbsent
-	}
-	u.UID = u.userStatus.Uid
-	if len(u.Group) > 1 {
-		if u.groupStatus == nil {
-			if u.groupStatus, err = user.LookupGroup(u.Group); err != nil {
-				return err
-			}
-		}
-		if len(u.groupStatus.Gid) < 1 {
-			return ErrResourceStateAbsent
-		}
-	}
-	return
-}
-
 func (u *User) Read(ctx context.Context) ([]byte, error) {
 	exErr := u.ReadCommand.Extractor(nil, u)
 	if exErr != nil {
 		u.Common.State = "absent"
 	}
-	_ = u.ReadGroups()
+	if yaml, yamlErr := yaml.Marshal(u); yamlErr != nil {
-	if yamlDoc, yamlErr := yaml.Marshal(u); yamlErr != nil {
+		return yaml, yamlErr
-		return yamlDoc, yamlErr
 	} else {
-		return yamlDoc, exErr
+		return yaml, exErr
 	}
 }
 
-func (u *User) ReadGroups() (err error) {
-	knownSecondaryGroups := make(map[string]bool)
-	for _, secondaryGroupName := range u.Groups {
-		knownSecondaryGroups[secondaryGroupName] = true
-	}
-	if u.ReadStat() == nil {
-		if groups, groupsErr := u.userStatus.GroupIds(); groupsErr == nil {
-			for _, secondaryGroup := range groups {
-				if readGroup, groupErr := user.LookupGroupId(secondaryGroup); groupErr == nil {
-					if ! knownSecondaryGroups[readGroup.Name] {
-						u.Groups = append(u.Groups, readGroup.Name)
-						knownSecondaryGroups[readGroup.Name] = true
-					}
-				} else {
-					err = groupErr
-				}
-			}
-		} else {
-			err = groupsErr
-		}
-	}
-	return
-}
-
 func (u *User) Update(ctx context.Context) (error) {
-	_, err := u.UpdateCommand.Execute(u)
+	return u.Create(ctx)
-	if err != nil {
-		return err
-	}
-
-	_,e := u.Read(ctx)
-	return e
 }
 
 func (u *User) Delete(ctx context.Context) (error) {
@@ -362,38 +279,38 @@ func (u *User) UnmarshalYAML(value *yaml.Node) error {
 
 func (u *UserType) NewCRUD() (create *command.Command, read *command.Command, update *command.Command, del *command.Command) {
 	switch *u {
-	case UserTypeShadow:
+	case UserTypeUserAdd:
-		return NewUserShadowCreateCommand(), NewUserReadCommand(), NewUserShadowUpdateCommand(), NewUserShadowDeleteCommand()
+		return NewUserAddCreateCommand(), NewUserReadCommand(), NewUserUpdateCommand(), NewUserDelDeleteCommand()
-	case UserTypeBusyBox:
+	case UserTypeAddUser:
-		return NewUserBusyBoxCreateCommand(), NewUserReadCommand(), NewUserBusyBoxUpdateCommand(), NewUserBusyBoxDeleteCommand()
+		return NewAddUserCreateCommand(), NewUserReadCommand(), NewUserUpdateCommand(), NewDelUserDeleteCommand()
 	default:
 		if _, addUserPathErr := exec.LookPath("adduser"); addUserPathErr == nil {
-			*u = UserTypeBusyBox
+			*u = UserTypeAddUser
-			return NewUserBusyBoxCreateCommand(), NewUserReadCommand(), NewUserBusyBoxUpdateCommand(), NewUserBusyBoxDeleteCommand()
+			return NewAddUserCreateCommand(), NewUserReadCommand(), NewUserUpdateCommand(), NewDelUserDeleteCommand()
 		}
 		if _, pathErr := exec.LookPath("useradd"); pathErr == nil {
-			*u = UserTypeShadow
+			*u = UserTypeUserAdd
-			return NewUserShadowCreateCommand(), NewUserReadCommand(), NewUserShadowUpdateCommand(), NewUserShadowDeleteCommand()
+			return NewUserAddCreateCommand(), NewUserReadCommand(), NewUserUpdateCommand(), NewUserDelDeleteCommand()
 		}
-		return NewUserShadowCreateCommand(), NewUserReadCommand(), NewUserShadowUpdateCommand(), NewUserShadowDeleteCommand()
+		return NewUserAddCreateCommand(), NewUserReadCommand(), NewUserUpdateCommand(), NewUserDelDeleteCommand()
 	}
 }
 
-func (u *UserType) NewReadCommand() (read *command.Command) {
-	return NewUserReadCommand()
-}
-
 func (u *UserType) NewCreateCommand() (create *command.Command) {
 	switch *u {
-	case UserTypeShadow:
+	case UserTypeUserAdd:
-		return NewUserShadowCreateCommand()
+		return NewUserAddCreateCommand()
-	case UserTypeBusyBox:
+	case UserTypeAddUser:
-		return NewUserBusyBoxCreateCommand()
+		return NewAddUserCreateCommand()
 	default:
 	}
 	return nil
 }
 
+func (u *UserType) NewReadCommand() (*command.Command) {
+	return NewUserReadCommand()
+}
+
 func (p *UserType) NewReadUsersCommand() (*command.Command) {
 	return NewReadUsersCommand()
 }
@@ -401,7 +318,7 @@ func (p *UserType) NewReadUsersCommand() (*command.Command) {
 
 func (u *UserType) UnmarshalValue(value string) error {
 	switch value {
-	case string(UserTypeShadow), string(UserTypeBusyBox):
+	case string(UserTypeUserAdd), string(UserTypeAddUser):
 		*u = UserType(value)
 	return nil
 	default:
@@ -468,7 +385,7 @@ func NewReadUsersCommand() *command.Command {
 	return c
 }
 
-func NewUserShadowCreateCommand() *command.Command {
+func NewUserAddCreateCommand() *command.Command {
 	c := command.NewCommand()
 	c.Path = "useradd"
 	c.Args = []command.CommandArg{
@@ -482,11 +399,19 @@ func NewUserShadowCreateCommand() *command.Command {
 	}
 	c.Extractor = func(out []byte, target any) error {
 		return nil
+/*
+		for _,line := range strings.Split(string(out), "\n") {
+			if line == "iptables: Chain already exists." {
+				return nil
+			}
+		}
+		return fmt.Errorf(string(out))
+*/
 	}
 	return c
 }
 
-func NewUserBusyBoxCreateCommand() *command.Command {
+func NewAddUserCreateCommand() *command.Command {
 	c := command.NewCommand()
 	c.Path = "adduser"
 	c.Args = []command.CommandArg{
@@ -500,6 +425,14 @@ func NewUserBusyBoxCreateCommand() *command.Command {
 	}
 	c.Extractor = func(out []byte, target any) error {
 		return nil
+/*
+		for _,line := range strings.Split(string(out), "\n") {
+			if line == "iptables: Chain already exists." {
+				return nil
+			}
+		}
+		return fmt.Errorf(string(out))
+*/
 	}
 	return c
 }
@@ -538,40 +471,11 @@ func NewUserReadCommand() *command.Command {
 	return c
 }
 
-func NewUserBusyBoxUpdateCommand() *command.Command {
+func NewUserUpdateCommand() *command.Command {
-	c := command.NewCommand()
-	c.Path = "xargs"
-	c.StdinAvailable = true
-	c.Input = command.CommandInput("{{ if .Groups }}{{ range .Groups }}{{ . }}\n{{ end }}{{ end }}")
-	c.Args = []command.CommandArg{
-		command.CommandArg("adduser"),
-		command.CommandArg("{{ .Name }}"),
-	}
-	c.Extractor = func(out []byte, target any) error {
 	return nil
 }
-	return c
-}
 
-func NewUserShadowUpdateCommand() *command.Command {
+func NewUserDelDeleteCommand() *command.Command {
-	c := command.NewCommand()
-	c.Path = "usermod"
-	c.Args = []command.CommandArg{
-		command.CommandArg("{{ if .UID }}-u {{ .UID }}{{ end }}"),
-		command.CommandArg("{{ if .Gecos }}-c {{ .Gecos }}{{ end }}"),
-		command.CommandArg("{{ if .Group }}-g {{ .groupStatus.Gid }}{{ end }}"),
-		command.CommandArg("{{ if .Home }}-d {{ .Home }}{{ if .CreateHome }} -m{{- end }}{{ end }}"),
-		command.CommandArg("{{ if .Groups }}-G {{- range $i, $g := .Groups -}}{{ if $i }}, {{- end }}{{ . }}{{- end }}{{ if .AppendGroups }} -a{{- end }}{{- end }}"),
-		command.CommandArg("{{ if .Shell }}-s {{ .Shell }}{{ end }}"),
-		command.CommandArg("{{ .Name }}"),
-	}
-	c.Extractor = func(out []byte, target any) error {
-		return nil
-	}
-	return c
-}
-
-func NewUserShadowDeleteCommand() *command.Command {
 	c := command.NewCommand()
 	c.Path = "userdel"
 	c.Args = []command.CommandArg{
@@ -583,7 +487,7 @@ func NewUserShadowDeleteCommand() *command.Command {
 	return c
 }
 
-func NewUserBusyBoxDeleteCommand() *command.Command {
+func NewDelUserDeleteCommand() *command.Command {
 	c := command.NewCommand()
 	c.Path = "deluser"
 	c.Args = []command.CommandArg{

internal/resource/user_test.go

@@ -13,7 +13,6 @@ _	"net/url"
 	_ "os"
 	_ "strings"
 	"testing"
-	"decl/internal/data"
 )
 
 func TestNewUserResource(t *testing.T) {
@@ -78,43 +77,3 @@ func TestCreateUser(t *testing.T) {
 	applyDeleteErr := u.Apply()
 	assert.Equal(t, nil, applyDeleteErr)
 }
-
-func TestSystemUser(t *testing.T) {
-	u := NewUser()
-	u.Name = "self"
-	u.UseConfig(MockConfigValueGetter(func(key string) (any, error) {
-		switch key {
-		case "user":
-			return "bar", nil
-		case "group":
-			return "foo", nil
-		case "uid":
-			return "", nil
-		}
-		return nil, fmt.Errorf("%w: %s", data.ErrUnknownConfigurationKey, key)
-	}))
-
-	assert.Nil(t, u.Init(nil))
-	u.ResolveId(context.Background())
-
-	assert.Equal(t, "bar", u.Name)
-}
-
-func TestUserSecondaryGroups(t *testing.T) {
-	groupCounts := make(map[string]int)
-	u := NewUser()
-	u.Name = "root"
-	u.ResolveId(context.Background())
-	u.Groups = []string{
-		"root",
-		"wheel",
-	}
-	assert.Nil(t, u.ReadGroups())
-
-	for _, groupName := range u.Groups {
-		groupCounts[groupName]++
-	}
-	assert.Greater(t, len(u.Groups), 2)
-	assert.Equal(t, 1, groupCounts["root"])
-	assert.Equal(t, 1, groupCounts["wheel"])
-}

internal/system/os.go

@@ -1,126 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-package system
-
-import (
-	"os/user"
-	"strconv"
-	"regexp"
-	"log/slog"
-)
-
-var MatchId	*regexp.Regexp = regexp.MustCompile(`^[0-9]+$`)
-
-func LookupUIDString(userName string) string {
-	user, userLookupErr := user.Lookup(userName)
-	if userLookupErr != nil {
-		return ""
-	}
-	return user.Uid
-}
-
-func LookupUID(userName string) (int, error) {
-	var userLookupErr error
-	var UID string
-	if MatchId.MatchString(userName) {
-		user, err := user.LookupId(userName)
-		slog.Info("LookupUID() numeric", "user", user, "userLookupErr", err)
-		if err != nil {
-			userLookupErr = err
-			UID = userName
-		} else {
-			UID = user.Uid
-		}
-	} else {
-		if user, err := user.Lookup(userName); err != nil {
-			return -1, err
-		} else {
-			UID = user.Uid
-		}
-	}
-
-	uid, uidErr := strconv.Atoi(UID)
-	slog.Info("LookupUID()", "uid", uid, "uidErr", uidErr)
-	if uidErr != nil {
-		if userLookupErr != nil {
-			return -1, userLookupErr
-		} else {
-			return -1, uidErr
-		}
-	}
-
-	return uid, userLookupErr
-}
-
-func LookupGID(groupName string) (int, error) {
-	var GID string
-	if MatchId.MatchString(groupName) {
-		group, groupLookupErr := user.LookupGroupId(groupName)
-		if groupLookupErr != nil {
-			//return -1, groupLookupErr
-			GID = groupName
-		} else {
-			GID = group.Gid
-		}
-	} else {
-		group, groupLookupErr := user.LookupGroup(groupName)
-		if groupLookupErr != nil {
-			return -1, groupLookupErr
-		}
-		GID = group.Gid
-	}
-
-	gid, gidErr := strconv.Atoi(GID)
-	if gidErr != nil {
-		return -1, gidErr
-	}
-
-	return gid, nil
-}
-
-func LookupGIDString(groupName string) string {
-	group, groupLookupErr := user.LookupGroup(groupName)
-	if groupLookupErr != nil {
-		return ""
-	}
-	return group.Gid
-}
-
-func ProcessUser() *user.User {
-	processUser, userErr := user.Current()
-	if userErr != nil {
-		panic(userErr)
-	}
-	return processUser
-}
-
-func ProcessGroup(u *user.User) *user.Group {
-	if u == nil {
-		u = ProcessUser()
-	}
-	processGroup, groupErr := user.LookupGroupId(u.Gid)
-	if groupErr != nil {
-		panic(groupErr)
-	}
-	return processGroup
-}
-
-func ProcessUserName() string {
-	processUser, userErr := user.Current()
-	if userErr != nil {
-		panic(userErr)
-	}
-	return processUser.Username
-}
-
-func ProcessGroupName() string {
-	processUser, userErr := user.Current()
-	if userErr != nil {
-		panic(userErr)
-	}
-	processGroup, groupErr := user.LookupGroupId(processUser.Gid)
-	if groupErr != nil {
-		panic(groupErr)
-	}
-	return processGroup.Name
-}

internal/system/os_test.go

@@ -1,38 +0,0 @@
-// Copyright 2024 Matthew Rich <matthewrich.conf@gmail.com>. All rights reserved.
-
-
-package system
-
-import (
-	_ "context"
-	_ "encoding/json"
-	"github.com/stretchr/testify/assert"
-	_ "io"
-	_ "net/http"
-	_ "net/http/httptest"
-	_ "net/url"
-	_ "strings"
-	"testing"
-)
-
-func TestLookupUID(t *testing.T) {
-	uid, e := LookupUID("nobody")
-
-	assert.Nil(t, e)
-	assert.Equal(t, 65534, uid)
-
-	nuid, ne := LookupUID("10101")
-	assert.Error(t, ne, "user: unknonwn userid ", ne)
-	assert.Equal(t, 10101, nuid)
-}
-
-func TestLookupGID(t *testing.T) {
-	gid, e := LookupGID("adm")
-
-	assert.Nil(t, e)
-	assert.Equal(t, 4, gid)
-
-	ngid, ne := LookupGID("1001")
-	assert.Nil(t, ne)
-	assert.Equal(t, 1001, ngid)
-}

internal/transport/http.go

@@ -91,10 +91,6 @@ func (h *HTTP) Stat() (info fs.FileInfo, err error) {
 	}
 	defer response.Body.Close()
 
-	if response.StatusCode > 399 {
-		err = ErrTransportResourceAbsent
-		return
-	}
 	fi := NewHTTPFileInfo(uri)
 	contentLength := response.Header.Get("Content-Length")
 	if contentLength != "" {

internal/transport/transport.go

@@ -3,7 +3,7 @@
 package transport
 
 import (
-	"errors"
+_	"errors"
 _	"fmt"
 	"net/url"
 	"net/http"
@@ -15,10 +15,6 @@ _	"os"
 	"context"
 )
 
-var (
-	ErrTransportResourceAbsent error = errors.New("Transport resource is absent")
-)
-
 type Handler interface {
 	URI() *url.URL
 	ContentType() string
@@ -166,17 +162,11 @@ func (r *Reader) AddHeader(name string, value string) {
 }
 
 func (r *Reader) Status() string {
-	if httpReader, ok := r.handle.(*HTTPReader); ok {
+	return r.handle.(*HTTPReader).GetResponse().Status
-		return httpReader.GetResponse().Status
-	}
-	panic("Unable to get HTTP status from reader")
 }
 
 func (r *Reader) StatusCode() int {
-	if httpReader, ok := r.handle.(*HTTPReader); ok {
+	return r.handle.(*HTTPReader).GetResponse().StatusCode
-		return httpReader.GetResponse().StatusCode
-	}
-	panic("Unable to get HTTP status code from reader")
 }
 
 func (r *Reader) Response() *http.Response {

internal/types/types.go

@@ -105,19 +105,6 @@ func (t *Types[Product]) NewFromParsedURI(u *url.URL) (result Product, err error
 	return
 }
 
-// Returns an uninitialized resource for the given type
-func (t *Types[Product]) NewFromType(typename string) (result Product, err error) {
-	if r, ok := t.registry[typename]; ok {
-		if result = r(nil); result != any(nil) {
-			return result, nil
-		} else {
-			return result, fmt.Errorf("%w: factory failed creating %s", ErrInvalidProduct, typename)
-		}
-	}
-	err = fmt.Errorf("%w: %s", ErrUnknownType, typename)
-	return
-}
-
 func (t *Types[Product]) Has(typename string) bool {
 	if _, ok := t.registry[typename]; ok {
 		return true

internal/types/types_test.go

@@ -61,17 +61,3 @@ func TestTypeName(t *testing.T) {
 	assert.Equal(t, "file", string(fTypeName.Name))
 }
 */
-
-func TestNewFromType(t *testing.T) {
-	testTypes := New[string]()
-	assert.NotNil(t, testTypes)
-
-	testTypes.Register([]string{"foo"}, func(*url.URL) string { return "test" })
-
-	r, e := testTypes.NewFromType("foo")
-	assert.Nil(t, e)
-	assert.Equal(t, "test", r)
-	failr, faile := testTypes.NewFromType("bar")
-	assert.ErrorIs(t, faile, ErrUnknownType)
-	assert.Equal(t, "", failr)
-}